2022-05-23 07:11:26

by Tamseel Shams

Subject: [PATCH v2 1/3] dt-bindings: iio: adc: Add FSD-HW variant

From: Alim Akhtar <[email protected]>

This patch adds a new compatible string for FSD-HW's
ADC variant

Signed-off-by: Alim Akhtar <[email protected]>
Signed-off-by: Tamseel Shams <[email protected]>
---
- Changes since v1
* Addressed Krzysztof's comment to use soc-specific compatible

.../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
index 81c87295912c..ded0e3f85991 100644
--- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
@@ -14,6 +14,7 @@ properties:
enum:
- samsung,exynos-adc-v1 # Exynos5250
- samsung,exynos-adc-v2
+ - samsung,exynos-adc-fsd-hw
- samsung,exynos3250-adc
- samsung,exynos4212-adc # Exynos4212 and Exynos4412
- samsung,exynos7-adc
--
2.17.1

2022-05-23 10:16:59

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 1/3] dt-bindings: iio: adc: Add FSD-HW variant

On 20/05/2022 16:58, Tamseel Shams wrote:
> From: Alim Akhtar <[email protected]>
>
> This patch adds a new compatible string for FSD-HW's
> ADC variant
>
> Signed-off-by: Alim Akhtar <[email protected]>
> Signed-off-by: Tamseel Shams <[email protected]>
> ---
> - Changes since v1
> * Addressed Krzysztof's comment to use soc-specific compatible
>
> .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index 81c87295912c..ded0e3f85991 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -14,6 +14,7 @@ properties:
> enum:
> - samsung,exynos-adc-v1 # Exynos5250
> - samsung,exynos-adc-v2
> + - samsung,exynos-adc-fsd-hw

The soc is fsd, so compatible should rather be:
tesla,fsd-adc

What does the "HW" mean?

> - samsung,exynos3250-adc
> - samsung,exynos4212-adc # Exynos4212 and Exynos4412
> - samsung,exynos7-adc


Best regards,
Krzysztof

2022-06-01 19:50:07

by Tamseel Shams

Subject: RE: [PATCH v2 1/3] dt-bindings: iio: adc: Add FSD-HW variant

Hi Krzysztof,

On 20/05/2022 16:58, Tamseel Shams wrote:
>> From: Alim Akhtar <[email protected]>
>>
>> This patch adds a new compatible string for FSD-HW's ADC variant
>>
>> Signed-off-by: Alim Akhtar <[email protected]>
>> Signed-off-by: Tamseel Shams <[email protected]>
>> ---
>> - Changes since v1
>> * Addressed Krzysztof's comment to use soc-specific compatible
>>
>> .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
>> b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
>> index 81c87295912c..ded0e3f85991 100644
>> ---
>> a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yam
>> +++ l
>> @@ -14,6 +14,7 @@ properties:
>> enum:
>> - samsung,exynos-adc-v1 # Exynos5250
>> - samsung,exynos-adc-v2
>> + - samsung,exynos-adc-fsd-hw

> The soc is fsd, so compatible should rather be:
> tesla,fsd-adc

> What does the "HW" mean?

Will change the compatible to "tesla,fsd-adc" in the next version.
By HW, I meant Hardware


Thanks & Regards,
Tamseel Shams