2022-06-02 13:36:45

by Yihao Han

Subject: [PATCH] fbdev: simplefb: Check before clk_put() not needed

clk_put() already checks the clk ptr using !clk and IS_ERR()
so there is no need to check it again before calling it.

Signed-off-by: Yihao Han <[email protected]>
---
drivers/video/fbdev/simplefb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
index 2c198561c338..f96ce8801be4 100644
--- a/drivers/video/fbdev/simplefb.c
+++ b/drivers/video/fbdev/simplefb.c
@@ -237,8 +237,7 @@ static int simplefb_clocks_get(struct simplefb_par *par,
if (IS_ERR(clock)) {
if (PTR_ERR(clock) == -EPROBE_DEFER) {
while (--i >= 0) {
- if (par->clks[i])
- clk_put(par->clks[i]);
+ clk_put(par->clks[i]);
}
kfree(par->clks);
return -EPROBE_DEFER;
--
2.17.1

2022-06-03 00:54:46

by Hans de Goede

Subject: Re: [PATCH] fbdev: simplefb: Check before clk_put() not needed

Hi,

On 6/2/22 11:42, Yihao Han wrote:
> clk_put() already checks the clk ptr using !clk and IS_ERR()
> so there is no need to check it again before calling it.
>
> Signed-off-by: Yihao Han <[email protected]>
> ---
> drivers/video/fbdev/simplefb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
> index 2c198561c338..f96ce8801be4 100644
> --- a/drivers/video/fbdev/simplefb.c
> +++ b/drivers/video/fbdev/simplefb.c
> @@ -237,8 +237,7 @@ static int simplefb_clocks_get(struct simplefb_par *par,
> if (IS_ERR(clock)) {
> if (PTR_ERR(clock) == -EPROBE_DEFER) {
> while (--i >= 0) {
> - if (par->clks[i])
> - clk_put(par->clks[i]);
> + clk_put(par->clks[i]);
> }
> kfree(par->clks);
> return -EPROBE_DEFER;

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans

2022-06-20 19:22:26

by Helge Deller

Subject: Re: [PATCH] fbdev: simplefb: Check before clk_put() not needed

On 6/2/22 12:50, Hans de Goede wrote:
> Hi,
>
> On 6/2/22 11:42, Yihao Han wrote:
>> clk_put() already checks the clk ptr using !clk and IS_ERR()
>> so there is no need to check it again before calling it.
>>
>> Signed-off-by: Yihao Han <[email protected]>
>> ---
>> drivers/video/fbdev/simplefb.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
>> index 2c198561c338..f96ce8801be4 100644
>> --- a/drivers/video/fbdev/simplefb.c
>> +++ b/drivers/video/fbdev/simplefb.c
>> @@ -237,8 +237,7 @@ static int simplefb_clocks_get(struct simplefb_par *par,
>> if (IS_ERR(clock)) {
>> if (PTR_ERR(clock) == -EPROBE_DEFER) {
>> while (--i >= 0) {
>> - if (par->clks[i])
>> - clk_put(par->clks[i]);
>> + clk_put(par->clks[i]);
>> }
>> kfree(par->clks);
>> return -EPROBE_DEFER;
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <[email protected]>

applied to fbdev tree.

Thanks!
Helge