2022-07-05 02:31:24

by Xiubo Li

Subject: [RFC PATCH] netfs: do not get the folio reference twice

From: Xiubo Li <[email protected]>

And also the comment said it will drop the folio references but
the code was increasing it.

Signed-off-by: Xiubo Li <[email protected]>
---
fs/netfs/buffered_read.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c
index 5b93e22397fe..a44a5b3b8d4c 100644
--- a/fs/netfs/buffered_read.c
+++ b/fs/netfs/buffered_read.c
@@ -396,9 +396,6 @@ int netfs_write_begin(struct netfs_inode *ctx,
*/
ractl._nr_pages = folio_nr_pages(folio);
netfs_rreq_expand(rreq, &ractl);
-
- /* We hold the folio locks, so we can drop the references */
- folio_get(folio);
while (readahead_folio(&ractl))
;

--
2.36.0.rc1

2022-07-05 06:33:10

by Xiubo Li

Subject: Re: [RFC PATCH] netfs: do not get the folio reference twice

On 7/5/22 10:22 AM, [email protected] wrote:
> From: Xiubo Li <[email protected]>
>
> And also the comment said it will drop the folio references but
> the code was increasing it.
>
> Signed-off-by: Xiubo Li <[email protected]>
> ---
> fs/netfs/buffered_read.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c
> index 5b93e22397fe..a44a5b3b8d4c 100644
> --- a/fs/netfs/buffered_read.c
> +++ b/fs/netfs/buffered_read.c
> @@ -396,9 +396,6 @@ int netfs_write_begin(struct netfs_inode *ctx,
> */
> ractl._nr_pages = folio_nr_pages(folio);
> netfs_rreq_expand(rreq, &ractl);
> -
> - /* We hold the folio locks, so we can drop the references */
> - folio_get(folio);
> while (readahead_folio(&ractl))
> ;
>

Will drop this patch, the above fix it incorrect.

Thanks!