2022-05-14 02:41:46

by Zheng Bin

[permalink] [raw]
Subject: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind

ab8500_charger_bind misses destroy_workqueue in error path,
this patch fixes that.

Signed-off-by: Zheng Bin <[email protected]>
---
drivers/power/supply/ab8500_charger.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
index d04d087caa50..a5d055a628e7 100644
--- a/drivers/power/supply/ab8500_charger.c
+++ b/drivers/power/supply/ab8500_charger.c
@@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
ret = component_bind_all(dev, di);
if (ret) {
dev_err(dev, "can't bind component devices\n");
+ destroy_workqueue(di->charger_wq);
return ret;
}

--
2.31.1



2022-06-07 17:37:13

by Zheng Bin

[permalink] [raw]
Subject: Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind

friendly ping

On 2022/5/12 17:38, Zheng Bin wrote:
> ab8500_charger_bind misses destroy_workqueue in error path,
> this patch fixes that.
>
> Signed-off-by: Zheng Bin <[email protected]>
> ---
> drivers/power/supply/ab8500_charger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
> index d04d087caa50..a5d055a628e7 100644
> --- a/drivers/power/supply/ab8500_charger.c
> +++ b/drivers/power/supply/ab8500_charger.c
> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
> ret = component_bind_all(dev, di);
> if (ret) {
> dev_err(dev, "can't bind component devices\n");
> + destroy_workqueue(di->charger_wq);
> return ret;
> }
>
> --
> 2.31.1
>
> .
>

2022-06-09 22:45:58

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind

Hi,

On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
> ab8500_charger_bind misses destroy_workqueue in error path,
> this patch fixes that.
>
> Signed-off-by: Zheng Bin <[email protected]>
> ---

LGTM, but adding Linus to Cc and waiting a bit to give him time to
react.

-- Sebastian

> drivers/power/supply/ab8500_charger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
> index d04d087caa50..a5d055a628e7 100644
> --- a/drivers/power/supply/ab8500_charger.c
> +++ b/drivers/power/supply/ab8500_charger.c
> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
> ret = component_bind_all(dev, di);
> if (ret) {
> dev_err(dev, "can't bind component devices\n");
> + destroy_workqueue(di->charger_wq);
> return ret;
> }
>
> --
> 2.31.1
>

Attachments:
(No filename) (909.00 B)
 signature.asc (849.00 B)
 Download all attachments

2022-06-16 06:27:26

by Zheng Bin

[permalink] [raw]
Subject: Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind


On 2022/6/10 6:22, Sebastian Reichel wrote:
> Hi,
>
> On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
>> ab8500_charger_bind misses destroy_workqueue in error path,
>> this patch fixes that.
>>
>> Signed-off-by: Zheng Bin <[email protected]>
>> ---
> LGTM, but adding Linus to Cc and waiting a bit to give him time to
> react.
>
> -- Sebastian
ping
>
>> drivers/power/supply/ab8500_charger.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
>> index d04d087caa50..a5d055a628e7 100644
>> --- a/drivers/power/supply/ab8500_charger.c
>> +++ b/drivers/power/supply/ab8500_charger.c
>> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
>> ret = component_bind_all(dev, di);
>> if (ret) {
>> dev_err(dev, "can't bind component devices\n");
>> + destroy_workqueue(di->charger_wq);
>> return ret;
>> }
>>
>> --
>> 2.31.1
>>

2022-06-23 14:50:15

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind

On Fri, Jun 10, 2022 at 12:22 AM Sebastian Reichel
<[email protected]> wrote:
> On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
> > ab8500_charger_bind misses destroy_workqueue in error path,
> > this patch fixes that.
> >
> > Signed-off-by: Zheng Bin <[email protected]>
> > ---
>
> LGTM, but adding Linus to Cc and waiting a bit to give him time to
> react.

Don't have the original patch in my inbox so can't test it, but looks
reasonable so:
Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2022-07-16 23:12:40

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind

Hi,

On Thu, Jun 23, 2022 at 04:20:52PM +0200, Linus Walleij wrote:
> On Fri, Jun 10, 2022 at 12:22 AM Sebastian Reichel
> <[email protected]> wrote:
> > On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
> > > ab8500_charger_bind misses destroy_workqueue in error path,
> > > this patch fixes that.
> > >
> > > Signed-off-by: Zheng Bin <[email protected]>
> > > ---
> >
> > LGTM, but adding Linus to Cc and waiting a bit to give him time to
> > react.
>
> Don't have the original patch in my inbox so can't test it, but looks
> reasonable so:
> Acked-by: Linus Walleij <[email protected]>

Thanks, queued.

-- Sebastian

Attachments:
(No filename) (677.00 B)
 signature.asc (849.00 B)
 Download all attachments