The arch_get_kallsym() function is not used anywhere in the kernel
now, so it should at-least be static or just be removed as there
are no users. Making it static fixes the following sparse warning:
kernel/kallsyms.c:590:12: warning: symbol 'arch_get_kallsym' was not declared. Should it be static?
Signed-off-by: Ben Dooks <[email protected]>
---
kernel/kallsyms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c
index fbdf8d3279ac..14922fb21f7b 100644
--- a/kernel/kallsyms.c
+++ b/kernel/kallsyms.c
@@ -587,7 +587,7 @@ struct kallsym_iter {
int show_value;
};
-int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
+static int arch_get_kallsym(unsigned int symnum, unsigned long *value,
char *type, char *name)
{
return -EINVAL;
--
2.35.1
On Thu, Jul 21, 2022 at 04:10:40PM +0100, Ben Dooks wrote:
> The arch_get_kallsym() function is not used anywhere in the kernel
> now, so it should at-least be static or just be removed as there
> are no users. Making it static fixes the following sparse warning:
>
> kernel/kallsyms.c:590:12: warning: symbol 'arch_get_kallsym' was not declared. Should it be static?
It fixes the warning, but isn't exactly useful. Please just remove it,
get_ksymbol_arch and iter->pos_arch_end entirely instead.
On Thu, Jul 21, 2022 at 08:22:39AM -0700, Christoph Hellwig wrote:
> On Thu, Jul 21, 2022 at 04:10:40PM +0100, Ben Dooks wrote:
> > The arch_get_kallsym() function is not used anywhere in the kernel
> > now, so it should at-least be static or just be removed as there
> > are no users. Making it static fixes the following sparse warning:
> >
> > kernel/kallsyms.c:590:12: warning: symbol 'arch_get_kallsym' was not declared. Should it be static?
>
> It fixes the warning, but isn't exactly useful. Please just remove it,
> get_ksymbol_arch and iter->pos_arch_end entirely instead.
Ok, probably the best. I didn't have time to do any archeaology on it
to find out if it has ever been used.
--
Ben Dooks, [email protected], http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.