2022-08-24 12:16:43

by Jiapeng Chong

Subject: [PATCH] video: fbdev: omap: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because platform_get_irq()
already prints an error.

./drivers/video/fbdev/omap/omapfb_main.c:1653:2-9: line 1653 is redundant because platform_get_irq() already prints an error.
./drivers/video/fbdev/omap/omapfb_main.c:1646:2-9: line 1646 is redundant because platform_get_irq() already prints an error.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1957
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/video/fbdev/omap/omapfb_main.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index fbb3af883d4d..17cda5765683 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -1643,14 +1643,12 @@ static int omapfb_do_probe(struct platform_device *pdev,
}
fbdev->int_irq = platform_get_irq(pdev, 0);
if (fbdev->int_irq < 0) {
- dev_err(&pdev->dev, "unable to get irq\n");
r = ENXIO;
goto cleanup;
}

fbdev->ext_irq = platform_get_irq(pdev, 1);
if (fbdev->ext_irq < 0) {
- dev_err(&pdev->dev, "unable to get irq\n");
r = ENXIO;
goto cleanup;
}
--
2.20.1.7.g153144c

2022-08-24 20:30:17

by Helge Deller

Subject: Re: [PATCH] video: fbdev: omap: Remove unnecessary print function dev_err()

On 8/24/22 13:44, Jiapeng Chong wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> ./drivers/video/fbdev/omap/omapfb_main.c:1653:2-9: line 1653 is redundant because platform_get_irq() already prints an error.
> ./drivers/video/fbdev/omap/omapfb_main.c:1646:2-9: line 1646 is redundant because platform_get_irq() already prints an error.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1957
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

applied.

Thanks!
Helge

> ---
> drivers/video/fbdev/omap/omapfb_main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
> index fbb3af883d4d..17cda5765683 100644
> --- a/drivers/video/fbdev/omap/omapfb_main.c
> +++ b/drivers/video/fbdev/omap/omapfb_main.c
> @@ -1643,14 +1643,12 @@ static int omapfb_do_probe(struct platform_device *pdev,
> }
> fbdev->int_irq = platform_get_irq(pdev, 0);
> if (fbdev->int_irq < 0) {
> - dev_err(&pdev->dev, "unable to get irq\n");
> r = ENXIO;
> goto cleanup;
> }
>
> fbdev->ext_irq = platform_get_irq(pdev, 1);
> if (fbdev->ext_irq < 0) {
> - dev_err(&pdev->dev, "unable to get irq\n");
> r = ENXIO;
> goto cleanup;
> }