2022-09-13 15:30:22

by Marc Kleine-Budde

[permalink] [raw]

Subject: Re: [PATCH 5.19 123/192] net: fec: Use a spinlock to guard `fep->ptp_clk_on`

---

Hello Greg,

On 13.09.2022 16:03:49, Greg Kroah-Hartman wrote:
> From: Csókás Bence <[email protected]>
>
> [ Upstream commit b353b241f1eb9b6265358ffbe2632fdcb563354f ]
>
> Mutexes cannot be taken in a non-preemptible context,
> causing a panic in `fec_ptp_save_state()`. Replacing
> `ptp_clk_mutex` by `tmreg_lock` fixes this.
>
> Fixes: 6a4d7234ae9a ("net: fec: ptp: avoid register access when ipg clock is disabled")
> Fixes: f79959220fa5 ("fec: Restart PPS after link state change")
> Reported-by: Marc Kleine-Budde <[email protected]>
> Link: https://lore.kernel.org/all/[email protected]/
> Signed-off-by: Csókás Bence <[email protected]>
> Tested-by: Francesco Dolcini <[email protected]> # Toradex Apalis iMX6
> Link: https://lore.kernel.org/r/[email protected]
> Signed-off-by: Jakub Kicinski <[email protected]>
> Signed-off-by: Sasha Levin <[email protected]>

there's a revert pending for this patch:

| https://lore.kernel.org/all/[email protected]

...as it causes troubles in 6.0-rc4:

| https://lore.kernel.org/all/[email protected]/
| https://lore.kernel.org/all/CAHk-=wj1obPoTu1AHj9Bd_BGYjdjDyPP+vT5WMj8eheb3A9WHw@mail.gmail.com/

please drop this patch.

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

---

Attachments:

(No filename) (1.60 kB)
signature.asc (499.00 B)
Download all attachments

2022-09-13 17:51:29

by Greg Kroah-Hartman

[permalink] [raw]

Subject: Re: [PATCH 5.19 123/192] net: fec: Use a spinlock to guard `fep->ptp_clk_on`

---

On Tue, Sep 13, 2022 at 04:19:17PM +0200, Marc Kleine-Budde wrote:
> Hello Greg,
>
> On 13.09.2022 16:03:49, Greg Kroah-Hartman wrote:
> > From: Cs?k?s Bence <[email protected]>
> >
> > [ Upstream commit b353b241f1eb9b6265358ffbe2632fdcb563354f ]
> >
> > Mutexes cannot be taken in a non-preemptible context,
> > causing a panic in `fec_ptp_save_state()`. Replacing
> > `ptp_clk_mutex` by `tmreg_lock` fixes this.
> >
> > Fixes: 6a4d7234ae9a ("net: fec: ptp: avoid register access when ipg clock is disabled")
> > Fixes: f79959220fa5 ("fec: Restart PPS after link state change")
> > Reported-by: Marc Kleine-Budde <[email protected]>
> > Link: https://lore.kernel.org/all/[email protected]/
> > Signed-off-by: Cs?k?s Bence <[email protected]>
> > Tested-by: Francesco Dolcini <[email protected]> # Toradex Apalis iMX6
> > Link: https://lore.kernel.org/r/[email protected]
> > Signed-off-by: Jakub Kicinski <[email protected]>
> > Signed-off-by: Sasha Levin <[email protected]>
>
> there's a revert pending for this patch:
>
> | https://lore.kernel.org/all/[email protected]
>
> ...as it causes troubles in 6.0-rc4:
>
> | https://lore.kernel.org/all/[email protected]/
> | https://lore.kernel.org/all/CAHk-=wj1obPoTu1AHj9Bd_BGYjdjDyPP+vT5WMj8eheb3A9WHw@mail.gmail.com/
>
> please drop this patch.

Now dropped from all 3 queues, thanks.

greg k-h