Herbert Xu <[email protected]> wrote:
> On Mon, Sep 26, 2022 at 10:31:39AM +0200, Florian Westphal wrote:
> >
> > This patch is partial revert of
> > commit 93f976b5190d ("lib/rhashtable: simplify bucket_table_alloc()"),
> > to avoid kvmalloc for ATOMIC case.
>
> This patch should just be reverted. If kvzalloc fails we should
> definitely know about it.
No idea what you mean, I am no mind reader. Please consider
fixing this yourself, I am done with this crap.
On Mon, Sep 26, 2022 at 10:50:18AM +0200, Florian Westphal wrote:
> Herbert Xu <[email protected]> wrote:
> > On Mon, Sep 26, 2022 at 10:31:39AM +0200, Florian Westphal wrote:
> > >
> > > This patch is partial revert of
> > > commit 93f976b5190d ("lib/rhashtable: simplify bucket_table_alloc()"),
> > > to avoid kvmalloc for ATOMIC case.
> >
> > This patch should just be reverted. If kvzalloc fails we should
> > definitely know about it.
>
> No idea what you mean, I am no mind reader. Please consider
> fixing this yourself, I am done with this crap.
I just meant that the patch quoted above should be completely
reverted instead of partially reverted.
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Herbert Xu <[email protected]> wrote:
> On Mon, Sep 26, 2022 at 10:50:18AM +0200, Florian Westphal wrote:
> > Herbert Xu <[email protected]> wrote:
> > > On Mon, Sep 26, 2022 at 10:31:39AM +0200, Florian Westphal wrote:
> > > >
> > > > This patch is partial revert of
> > > > commit 93f976b5190d ("lib/rhashtable: simplify bucket_table_alloc()"),
> > > > to avoid kvmalloc for ATOMIC case.
> > >
> > > This patch should just be reverted. If kvzalloc fails we should
> > > definitely know about it.
> >
> > No idea what you mean, I am no mind reader. Please consider
> > fixing this yourself, I am done with this crap.
>
> I just meant that the patch quoted above should be completely
> reverted instead of partially reverted.
I don't understand that at all, since this means removal of
__GFP_NOWARN -- that makes no sense to me.
On Mon, Sep 26, 2022 at 12:05:50PM +0200, Florian Westphal wrote:
>
> I don't understand that at all, since this means removal of
> __GFP_NOWARN -- that makes no sense to me.
Only in the case of kvzalloc. We expect kzalloc to fail, that's
why it gets NOWARN. There is no sane reason for kvzalloc to fail
so it should warn.
Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt