2022-09-29 09:32:05

by haoxin

Subject: [PATCH v2] x86/mm/tlb: fix error word 'clleared' to 'cleared'

Just correct the wrong word 'clleared' to 'cleared'

Signed-off-by: Xin Hao <[email protected]>
---
arch/x86/include/asm/tlbflush.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
index cda3118f3b27..c80a15ef0cbc 100644
--- a/arch/x86/include/asm/tlbflush.h
+++ b/arch/x86/include/asm/tlbflush.h
@@ -291,7 +291,7 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
diff &= ~_PAGE_ACCESSED;

/*
- * Did any of the 'flush_on_clear' flags was clleared set from between
+ * Did any of the 'flush_on_clear' flags was cleared set from between
* 'oldflags' and 'newflags'?
*/
if (diff & oldflags & flush_on_clear)
--
2.31.0

2022-09-29 21:46:50

by Randy Dunlap

Subject: Re: [PATCH v2] x86/mm/tlb: fix error word 'clleared' to 'cleared'

Hi--

I would say let's fix the sentence grammar, but I don't know
what "cleared set" means.


On 9/29/22 02:10, Xin Hao wrote:
> Just correct the wrong word 'clleared' to 'cleared'
>
> Signed-off-by: Xin Hao <[email protected]>
> ---
> arch/x86/include/asm/tlbflush.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
> index cda3118f3b27..c80a15ef0cbc 100644
> --- a/arch/x86/include/asm/tlbflush.h
> +++ b/arch/x86/include/asm/tlbflush.h
> @@ -291,7 +291,7 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
> diff &= ~_PAGE_ACCESSED;
>
> /*
> - * Did any of the 'flush_on_clear' flags was clleared set from between
> + * Did any of the 'flush_on_clear' flags was cleared set from between

It should be more like:

* Were any of the 'flush_on_clear' flags changed between

X86 people, does that make sense to you?


> * 'oldflags' and 'newflags'?
> */
> if (diff & oldflags & flush_on_clear)
> --
> 2.31.0

--
~Randy

2022-09-29 23:08:00

by Nadav Amit

Subject: Re: [PATCH v2] x86/mm/tlb: fix error word 'clleared' to 'cleared'

On Sep 29, 2022, at 2:36 PM, Randy Dunlap <[email protected]> wrote:

> ⚠ External Email
>
> Hi--
>
> I would say let's fix the sentence grammar, but I don't know
> what "cleared set" means.
>
>
> On 9/29/22 02:10, Xin Hao wrote:
>> Just correct the wrong word 'clleared' to 'cleared'
>>
>> Signed-off-by: Xin Hao <[email protected]>
>> ---
>> arch/x86/include/asm/tlbflush.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
>> index cda3118f3b27..c80a15ef0cbc 100644
>> --- a/arch/x86/include/asm/tlbflush.h
>> +++ b/arch/x86/include/asm/tlbflush.h
>> @@ -291,7 +291,7 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
>> diff &= ~_PAGE_ACCESSED;
>>
>> /*
>> - * Did any of the 'flush_on_clear' flags was clleared set from between
>> + * Did any of the 'flush_on_clear' flags was cleared set from between
>
> It should be more like:
>
> * Were any of the 'flush_on_clear' flags changed between
>
> X86 people, does that make sense to you?

It’s not a test whether the flags are changed, but whether they are cleared.

Let’s see if we can make it clearer with shorter sentences. How about:
“Consider the ‘flush_on_clear’ flags that are set on ‘oldflags’; Flush if
any of these flags is cleared on ’newflags’”.

2022-09-30 00:23:03

by Randy Dunlap

Subject: Re: [PATCH v2] x86/mm/tlb: fix error word 'clleared' to 'cleared'

On 9/29/22 15:58, Nadav Amit wrote:
> On Sep 29, 2022, at 2:36 PM, Randy Dunlap <[email protected]> wrote:
>
>> ⚠ External Email
>>
>> Hi--
>>
>> I would say let's fix the sentence grammar, but I don't know
>> what "cleared set" means.
>>
>>
>> On 9/29/22 02:10, Xin Hao wrote:
>>> Just correct the wrong word 'clleared' to 'cleared'
>>>
>>> Signed-off-by: Xin Hao <[email protected]>
>>> ---
>>> arch/x86/include/asm/tlbflush.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
>>> index cda3118f3b27..c80a15ef0cbc 100644
>>> --- a/arch/x86/include/asm/tlbflush.h
>>> +++ b/arch/x86/include/asm/tlbflush.h
>>> @@ -291,7 +291,7 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
>>> diff &= ~_PAGE_ACCESSED;
>>>
>>> /*
>>> - * Did any of the 'flush_on_clear' flags was clleared set from between
>>> + * Did any of the 'flush_on_clear' flags was cleared set from between
>>
>> It should be more like:
>>
>> * Were any of the 'flush_on_clear' flags changed between
>>
>> X86 people, does that make sense to you?
>
> It’s not a test whether the flags are changed, but whether they are cleared.
>
> Let’s see if we can make it clearer with shorter sentences. How about:
> “Consider the ‘flush_on_clear’ flags that are set on ‘oldflags’; Flush if
> any of these flags is cleared on ’newflags’”.
>

Sounds good. Thanks for your help.

--
~Randy