2022-11-07 09:42:32

by Robert Marko

[permalink] [raw]
Subject: [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok"

Use "okay" instead of "ok" in USB nodes as "ok" is deprecated.

Signed-off-by: Robert Marko <[email protected]>
---
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
index db4b87944cdf..262b937e0bc6 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
@@ -22,7 +22,7 @@ memory {
};

&blsp1_spi1 {
- status = "ok";
+ status = "okay";

flash@0 {
#address-cells = <1>;
@@ -34,33 +34,33 @@ flash@0 {
};

&blsp1_uart5 {
- status = "ok";
+ status = "okay";
};

&pcie0 {
- status = "ok";
+ status = "okay";
perst-gpios = <&tlmm 58 0x1>;
};

&pcie1 {
- status = "ok";
+ status = "okay";
perst-gpios = <&tlmm 61 0x1>;
};

&pcie_phy0 {
- status = "ok";
+ status = "okay";
};

&pcie_phy1 {
- status = "ok";
+ status = "okay";
};

&qpic_bam {
- status = "ok";
+ status = "okay";
};

&qpic_nand {
- status = "ok";
+ status = "okay";

nand@0 {
reg = <0>;
--
2.38.1



2022-11-07 10:13:22

by Robert Marko

[permalink] [raw]
Subject: [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm

Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
harcoding the cell value.

Signed-off-by: Robert Marko <[email protected]>
---
arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
index 262b937e0bc6..651a231554e0 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
@@ -5,6 +5,7 @@
/dts-v1/;

#include "ipq8074.dtsi"
+#include <dt-bindings/gpio/gpio.h>

/ {
aliases {
@@ -39,12 +40,12 @@ &blsp1_uart5 {

&pcie0 {
status = "okay";
- perst-gpios = <&tlmm 58 0x1>;
+ perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
};

&pcie1 {
status = "okay";
- perst-gpios = <&tlmm 61 0x1>;
+ perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
};

&pcie_phy0 {
--
2.38.1


2022-11-07 10:18:37

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm



On 07/11/2022 10:29, Robert Marko wrote:
> Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
> harcoding the cell value.
>
> Signed-off-by: Robert Marko <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> index 262b937e0bc6..651a231554e0 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> @@ -5,6 +5,7 @@
> /dts-v1/;
>
> #include "ipq8074.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> aliases {
> @@ -39,12 +40,12 @@ &blsp1_uart5 {
>
> &pcie0 {
> status = "okay";
> - perst-gpios = <&tlmm 58 0x1>;
> + perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
> };
>
> &pcie1 {
> status = "okay";
> - perst-gpios = <&tlmm 61 0x1>;
> + perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
> };
>
> &pcie_phy0 {

2022-11-07 10:34:34

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok"



On 07/11/2022 10:29, Robert Marko wrote:
> Use "okay" instead of "ok" in USB nodes as "ok" is deprecated.
>
> Signed-off-by: Robert Marko <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> index db4b87944cdf..262b937e0bc6 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> @@ -22,7 +22,7 @@ memory {
> };
>
> &blsp1_spi1 {
> - status = "ok";
> + status = "okay";
>
> flash@0 {
> #address-cells = <1>;
> @@ -34,33 +34,33 @@ flash@0 {
> };
>
> &blsp1_uart5 {
> - status = "ok";
> + status = "okay";
> };
>
> &pcie0 {
> - status = "ok";
> + status = "okay";
> perst-gpios = <&tlmm 58 0x1>;
> };
>
> &pcie1 {
> - status = "ok";
> + status = "okay";
> perst-gpios = <&tlmm 61 0x1>;
> };
>
> &pcie_phy0 {
> - status = "ok";
> + status = "okay";
> };
>
> &pcie_phy1 {
> - status = "ok";
> + status = "okay";
> };
>
> &qpic_bam {
> - status = "ok";
> + status = "okay";
> };
>
> &qpic_nand {
> - status = "ok";
> + status = "okay";
>
> nand@0 {
> reg = <0>;

2022-11-07 10:39:26

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok"

On 07/11/2022 10:29, Robert Marko wrote:
> Use "okay" instead of "ok" in USB nodes as "ok" is deprecated.
>
> Signed-off-by: Robert Marko <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2022-11-07 10:39:34

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm



On 07/11/2022 10:29, Robert Marko wrote:
> Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
> harcoding the cell value.
>
> Signed-off-by: Robert Marko <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

KOnrad
> arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> index 262b937e0bc6..651a231554e0 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
> @@ -5,6 +5,7 @@
> /dts-v1/;
>
> #include "ipq8074.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> aliases {
> @@ -39,12 +40,12 @@ &blsp1_uart5 {
>
> &pcie0 {
> status = "okay";
> - perst-gpios = <&tlmm 58 0x1>;
> + perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
> };
>
> &pcie1 {
> status = "okay";
> - perst-gpios = <&tlmm 61 0x1>;
> + perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
> };
>
> &pcie_phy0 {

2022-11-07 10:58:21

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm

On 07/11/2022 10:29, Robert Marko wrote:
> Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
> harcoding the cell value.
>
> Signed-off-by: Robert Marko <[email protected]>


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2022-11-08 02:09:41

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok"

On Mon, 7 Nov 2022 10:29:28 +0100, Robert Marko wrote:
> Use "okay" instead of "ok" in USB nodes as "ok" is deprecated.
>
>

Applied, thanks!

[1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok"
commit: 7284a3943909606016128b79fb18dd107bc0fe26
[2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm
commit: 3f49bdaf6f84959bb8fc3ed5add7983907491240
[3/3] arm64: dts: qcom: hk01: use GPIO flags for tlmm
commit: 1bc6b7f26bc72c8fd5a49ff000bb76a234e75e11

Best regards,
--
Bjorn Andersson <[email protected]>