2022-11-29 03:34:37

by Jiapeng Chong

Subject: [PATCH] media: platform: Fix missing error code in rzg2l_cru_start_streaming_vq()

Failed to allocate scratch buffer, add the error code '-ENOMEM' to the
return value 'ret'.

drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:676 rzg2l_cru_start_streaming_vq() warn: missing error code 'ret'.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3275
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
index 9533e4069ecd..91b57c7c2e56 100644
--- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
+++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
@@ -673,6 +673,7 @@ static int rzg2l_cru_start_streaming_vq(struct vb2_queue *vq, unsigned int count
if (!cru->scratch) {
return_unused_buffers(cru, VB2_BUF_STATE_QUEUED);
dev_err(cru->dev, "Failed to allocate scratch buffer\n");
+ ret = -ENOMEM;
goto free_image_conv_irq;
}

--
2.20.1.7.g153144c

2022-11-29 07:48:29

by Hans Verkuil

Subject: Re: [PATCH] media: platform: Fix missing error code in rzg2l_cru_start_streaming_vq()

Hi Jiapeng Chong,

Please repost with a proper subject line prefix: "media: rzg2l-cru:".

The 'media: platform:' prefix suggests a media/platform-wide patch, not a patch
for a single driver.

Why is this so hard to do?

Regards,

Hans


On 29/11/2022 04:17, Jiapeng Chong wrote:
> Failed to allocate scratch buffer, add the error code '-ENOMEM' to the
> return value 'ret'.
>
> drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:676 rzg2l_cru_start_streaming_vq() warn: missing error code 'ret'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3275
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> index 9533e4069ecd..91b57c7c2e56 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> @@ -673,6 +673,7 @@ static int rzg2l_cru_start_streaming_vq(struct vb2_queue *vq, unsigned int count
> if (!cru->scratch) {
> return_unused_buffers(cru, VB2_BUF_STATE_QUEUED);
> dev_err(cru->dev, "Failed to allocate scratch buffer\n");
> + ret = -ENOMEM;
> goto free_image_conv_irq;
> }
>