2023-01-02 11:42:35

by Tom Fitzhenry

Subject: [PATCH v2] mfd: rk808: re-add rk808-clkout to RK818

Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.

This line was removed in commit 3633daacea2e
("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818.

Changes in v2:
- Add a Fixes tag (Javier Martinez Canillas).
- Add Javier Martinez Canillas's Reviewed-by tag.
- Add Neil Armstrong's Acked-by tag.

Fixes: 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances")
Signed-off-by: Tom Fitzhenry <[email protected]>
Reviewed-by: Javier Martinez Canillas <[email protected]>
Acked-by: Neil Armstrong <[email protected]>
---
drivers/mfd/rk808.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
index f44fc3f080a8..0f22ef61e817 100644
--- a/drivers/mfd/rk808.c
+++ b/drivers/mfd/rk808.c
@@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = {
};

static const struct mfd_cell rk818s[] = {
+ { .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, },
{ .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, },
{
.name = "rk808-rtc",

base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5
--
2.38.1

2023-01-03 10:49:50

by Lee Jones

Subject: Re: [PATCH v2] mfd: rk808: re-add rk808-clkout to RK818

On Mon, 02 Jan 2023, Tom Fitzhenry wrote:

> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
>
> This line was removed in commit 3633daacea2e
> ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818.
>
> Changes in v2:
> - Add a Fixes tag (Javier Martinez Canillas).
> - Add Javier Martinez Canillas's Reviewed-by tag.
> - Add Neil Armstrong's Acked-by tag.

Change-logs should live under the "---" below.

I'll ship this out for you this time.

> Fixes: 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances")
> Signed-off-by: Tom Fitzhenry <[email protected]>
> Reviewed-by: Javier Martinez Canillas <[email protected]>
> Acked-by: Neil Armstrong <[email protected]>
> ---
> drivers/mfd/rk808.c | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.

--
Lee Jones [李琼斯]