The APSS clock controller in IPQ9574 based devices supports cpu with
frequencies above 800Mhz
This patch series adds the support for the same
This series depends on the below patchset
https://lore.kernel.org/linux-arm-msm/[email protected]/
devi priya (6):
dt-bindings: clock: Add YAML schemas for QCOM A73 PLL
clk: qcom: ipq9574: Enable APSS clock driver
arm64: defconfig: Enable ipq6018 apss clock and PLL controller
arm64: dts: qcom: ipq9574: Add support for APSS clock controller
dt-bindings: mailbox: Add compatible for IPQ9574
clk: qcom: Fix APSS PLL and RCG Configuration
.../bindings/clock/qcom,a73pll.yaml | 52 +++++++++++++++++++
.../mailbox/qcom,apcs-kpss-global.yaml | 3 ++
arch/arm64/boot/dts/qcom/ipq9574.dtsi | 17 ++++++
arch/arm64/configs/defconfig | 1 +
drivers/clk/qcom/apss-ipq-pll.c | 14 +++++
drivers/clk/qcom/apss-ipq6018.c | 8 ++-
drivers/mailbox/qcom-apcs-ipc-mailbox.c | 5 ++
7 files changed, 99 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/clock/qcom,a73pll.yaml
base-commit: 1fe4fd6f5cad346e598593af36caeadc4f5d4fa9
--
2.17.1
Enable APSS clock controller in IPQ9574
Co-developed-by: Praveenkumar I <[email protected]>
Signed-off-by: Praveenkumar I <[email protected]>
Signed-off-by: devi priya <[email protected]>
---
arch/arm64/boot/dts/qcom/ipq9574.dtsi | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index 188d18688a77..5a2244b437ed 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -247,6 +247,23 @@
};
};
+ apcs_glb: mailbox@b111000 {
+ compatible = "qcom,ipq9574-apcs-apps-global";
+ reg = <0x0b111000 0x1000>;
+ #clock-cells = <1>;
+ clocks = <&a73pll>, <&xo_board_clk>;
+ clock-names = "pll", "xo";
+ #mbox-cells = <1>;
+ };
+
+ a73pll: clock@b116000 {
+ compatible = "qcom,ipq9574-a73pll";
+ reg = <0x0b116000 0x40>;
+ #clock-cells = <0>;
+ clocks = <&xo_board_clk>;
+ clock-names = "xo";
+ };
+
timer@b120000 {
compatible = "arm,armv7-timer-mem";
reg = <0xb120000 0x1000>;
--
2.17.1
Add the mailbox compatible string for IPQ9574 SoC
Co-developed-by: Praveenkumar I <[email protected]>
Signed-off-by: Praveenkumar I <[email protected]>
Signed-off-by: devi priya <[email protected]>
---
.../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
index 943f9472ae10..9e076758a58a 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
@@ -20,6 +20,7 @@ properties:
- enum:
- qcom,ipq6018-apcs-apps-global
- qcom,ipq8074-apcs-apps-global
+ - qcom,ipq9574-apcs-apps-global
- qcom,msm8976-apcs-kpss-global
- qcom,msm8996-apcs-hmss-global
- qcom,msm8998-apcs-hmss-global
@@ -113,6 +114,7 @@ allOf:
enum:
- qcom,ipq6018-apcs-apps-global
- qcom,ipq8074-apcs-apps-global
+ - qcom,ipq9574-apcs-apps-global
then:
properties:
clocks:
@@ -129,6 +131,7 @@ allOf:
enum:
- qcom,ipq6018-apcs-apps-global
- qcom,ipq8074-apcs-apps-global
+ - qcom,ipq9574-apcs-apps-global
then:
properties:
'#clock-cells':
--
2.17.1
On 13/01/2023 15:36, devi priya wrote:
> Add the mailbox compatible string for IPQ9574 SoC
>
> Co-developed-by: Praveenkumar I <[email protected]>
> Signed-off-by: Praveenkumar I <[email protected]>
> Signed-off-by: devi priya <[email protected]>
> ---
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 13.01.2023 15:36, devi priya wrote:
> Add the mailbox compatible string for IPQ9574 SoC
>
> Co-developed-by: Praveenkumar I <[email protected]>
> Signed-off-by: Praveenkumar I <[email protected]>
> Signed-off-by: devi priya <[email protected]>
> ---
Binding changes should come before driver changes, so that
you're not introducing an "illegal" compatible and only
"legalize" it later - please reorder the patch.
Konrad
> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> index 943f9472ae10..9e076758a58a 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> @@ -20,6 +20,7 @@ properties:
> - enum:
> - qcom,ipq6018-apcs-apps-global
> - qcom,ipq8074-apcs-apps-global
> + - qcom,ipq9574-apcs-apps-global
> - qcom,msm8976-apcs-kpss-global
> - qcom,msm8996-apcs-hmss-global
> - qcom,msm8998-apcs-hmss-global
> @@ -113,6 +114,7 @@ allOf:
> enum:
> - qcom,ipq6018-apcs-apps-global
> - qcom,ipq8074-apcs-apps-global
> + - qcom,ipq9574-apcs-apps-global
> then:
> properties:
> clocks:
> @@ -129,6 +131,7 @@ allOf:
> enum:
> - qcom,ipq6018-apcs-apps-global
> - qcom,ipq8074-apcs-apps-global
> + - qcom,ipq9574-apcs-apps-global
> then:
> properties:
> '#clock-cells':
On 1/13/2023 8:43 PM, Konrad Dybcio wrote:
>
>
> On 13.01.2023 15:36, devi priya wrote:
>> Add the mailbox compatible string for IPQ9574 SoC
>>
>> Co-developed-by: Praveenkumar I <[email protected]>
>> Signed-off-by: Praveenkumar I <[email protected]>
>> Signed-off-by: devi priya <[email protected]>
>> ---
> Binding changes should come before driver changes, so that
> you're not introducing an "illegal" compatible and only
> "legalize" it later - please reorder the patch.
>
> Konrad
Understood, will reorder the patches in V2
>> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>> index 943f9472ae10..9e076758a58a 100644
>> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>> @@ -20,6 +20,7 @@ properties:
>> - enum:
>> - qcom,ipq6018-apcs-apps-global
>> - qcom,ipq8074-apcs-apps-global
>> + - qcom,ipq9574-apcs-apps-global
>> - qcom,msm8976-apcs-kpss-global
>> - qcom,msm8996-apcs-hmss-global
>> - qcom,msm8998-apcs-hmss-global
>> @@ -113,6 +114,7 @@ allOf:
>> enum:
>> - qcom,ipq6018-apcs-apps-global
>> - qcom,ipq8074-apcs-apps-global
>> + - qcom,ipq9574-apcs-apps-global
>> then:
>> properties:
>> clocks:
>> @@ -129,6 +131,7 @@ allOf:
>> enum:
>> - qcom,ipq6018-apcs-apps-global
>> - qcom,ipq8074-apcs-apps-global
>> + - qcom,ipq9574-apcs-apps-global
>> then:
>> properties:
>> '#clock-cells':
Best Regards,
Devi Priya