Hi,
Resending after all dependencies got merged. The DTS changes are not
compatible with kernel older than v6.3-rc1 (where the driver changes were
merged).
Description
===========
The WSA881x shutdown GPIO is active low (SD_N), but Linux driver assumed
DTS always comes with active high. Since Linux driver were updated to
handle proper flag, correct the DTS.
Best regards,
Krzysztof
Krzysztof Kozlowski (4):
arm64: dts: qcom: sdm850-lenovo-yoga-c630: Use proper WSA881x shutdown
GPIO polarity
arm64: dts: qcom: sdm850-samsung-w737: Use proper WSA881x shutdown
GPIO polarity
arm64: dts: qcom: sm8250-mtp: Use proper WSA881x shutdown GPIO
polarity
arm64: dts: qcom: qrb5165-rb5: Use proper WSA881x shutdown GPIO
polarity
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 4 ++--
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++--
arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
--
2.34.1
The WSA881x shutdown GPIO is active low (SD_N), but Linux driver assumed
DTS always comes with active high. Since Linux drivers were updated to
handle proper flag, correct the DTS.
The change is not backwards compatible with older Linux kernel.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index 67d2a663ce75..5c688cb6a7ce 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -753,7 +753,7 @@ swm: swm@c85 {
left_spkr: speaker@0,3 {
compatible = "sdw10217211000";
reg = <0 3>;
- powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>;
+ powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_LOW>;
#thermal-sensor-cells = <0>;
sound-name-prefix = "SpkrLeft";
#sound-dai-cells = <0>;
@@ -761,7 +761,7 @@ left_spkr: speaker@0,3 {
right_spkr: speaker@0,4 {
compatible = "sdw10217211000";
- powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>;
+ powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_LOW>;
reg = <0 4>;
#thermal-sensor-cells = <0>;
sound-name-prefix = "SpkrRight";
--
2.34.1
The WSA881x shutdown GPIO is active low (SD_N), but Linux driver assumed
DTS always comes with active high. Since Linux drivers were updated to
handle proper flag, correct the DTS.
The change is not backwards compatible with older Linux kernel.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
index 9850140514ba..41f59e32af64 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
@@ -662,7 +662,7 @@ swm: swm@c85 {
left_spkr: speaker@0,3 {
compatible = "sdw10217211000";
reg = <0 3>;
- powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>;
+ powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_LOW>;
#thermal-sensor-cells = <0>;
sound-name-prefix = "SpkrLeft";
#sound-dai-cells = <0>;
@@ -670,7 +670,7 @@ left_spkr: speaker@0,3 {
right_spkr: speaker@0,4 {
compatible = "sdw10217211000";
- powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>;
+ powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_LOW>;
reg = <0 4>;
#thermal-sensor-cells = <0>;
sound-name-prefix = "SpkrRight";
--
2.34.1
The WSA881x shutdown GPIO is active low (SD_N), but Linux driver assumed
DTS always comes with active high. Since Linux drivers were updated to
handle proper flag, correct the DTS.
The change is not backwards compatible with older Linux kernel.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
index aa0a7bd7307c..dd924331b0ee 100644
--- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
+++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
@@ -1012,7 +1012,7 @@ &swr0 {
left_spkr: speaker@0,3 {
compatible = "sdw10217211000";
reg = <0 3>;
- powerdown-gpios = <&tlmm 130 GPIO_ACTIVE_HIGH>;
+ powerdown-gpios = <&tlmm 130 GPIO_ACTIVE_LOW>;
#thermal-sensor-cells = <0>;
sound-name-prefix = "SpkrLeft";
#sound-dai-cells = <0>;
@@ -1021,7 +1021,7 @@ left_spkr: speaker@0,3 {
right_spkr: speaker@0,4 {
compatible = "sdw10217211000";
reg = <0 4>;
- powerdown-gpios = <&tlmm 130 GPIO_ACTIVE_HIGH>;
+ powerdown-gpios = <&tlmm 130 GPIO_ACTIVE_LOW>;
#thermal-sensor-cells = <0>;
sound-name-prefix = "SpkrRight";
#sound-dai-cells = <0>;
--
2.34.1
The WSA881x shutdown GPIO is active low (SD_N), but Linux driver assumed
DTS always comes with active high. Since Linux drivers were updated to
handle proper flag, correct the DTS.
The change is not backwards compatible with older Linux kernel.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
index e54cdc8bc31f..4c9de236676d 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
@@ -764,7 +764,7 @@ &swr0 {
left_spkr: speaker@0,3 {
compatible = "sdw10217211000";
reg = <0 3>;
- powerdown-gpios = <&tlmm 26 GPIO_ACTIVE_HIGH>;
+ powerdown-gpios = <&tlmm 26 GPIO_ACTIVE_LOW>;
#thermal-sensor-cells = <0>;
sound-name-prefix = "SpkrLeft";
#sound-dai-cells = <0>;
@@ -773,7 +773,7 @@ left_spkr: speaker@0,3 {
right_spkr: speaker@0,4 {
compatible = "sdw10217211000";
reg = <0 4>;
- powerdown-gpios = <&tlmm 127 GPIO_ACTIVE_HIGH>;
+ powerdown-gpios = <&tlmm 127 GPIO_ACTIVE_LOW>;
#thermal-sensor-cells = <0>;
sound-name-prefix = "SpkrRight";
#sound-dai-cells = <0>;
--
2.34.1
On Wed, 22 Mar 2023 20:30:47 +0100, Krzysztof Kozlowski wrote:
> Resending after all dependencies got merged. The DTS changes are not
> compatible with kernel older than v6.3-rc1 (where the driver changes were
> merged).
>
> Description
> ===========
> The WSA881x shutdown GPIO is active low (SD_N), but Linux driver assumed
> DTS always comes with active high. Since Linux driver were updated to
> handle proper flag, correct the DTS.
>
> [...]
Applied, thanks!
[1/4] arm64: dts: qcom: sdm850-lenovo-yoga-c630: Use proper WSA881x shutdown GPIO polarity
commit: a246c20c45a0a2bf5e865a4c3a76822b79b38c80
[2/4] arm64: dts: qcom: sdm850-samsung-w737: Use proper WSA881x shutdown GPIO polarity
commit: 5b91fab8eae27d1436eacde60107bab9987bbd9d
[3/4] arm64: dts: qcom: sm8250-mtp: Use proper WSA881x shutdown GPIO polarity
commit: 4ded91530544afdbac350f609e6597076f569e52
[4/4] arm64: dts: qcom: qrb5165-rb5: Use proper WSA881x shutdown GPIO polarity
commit: 41841f120345be87a12a4096ebcc2d2959c484ef
Best regards,
--
Bjorn Andersson <[email protected]>