2023-03-29 06:46:04

by Apurva Nandan

[permalink] [raw]
Subject: [PATCH 0/2] arm64: dts: ti: k3-j72xx-main: Switch MAIN R5F clusters to Split-mode

J721E and J7200 SoCs have two R5F clusters in the MAIN domain, and both
of these are configured for LockStep mode at the moment. Switch both of
these R5F clusters to Split mode by default to maximize the number of
R5F cores. The MCU R5F cluster continues to be in the preferred LockStep
mode.

Note that this configuration is the default for remoteproc mode (kernel
driver boots the R5F processors). These will be overridden for early-
booted remoteprocs through the corresponding IPC-only support in the K3
R5F remoteproc driver.

Suman Anna (2):
arm64: dts: ti: k3-j721e-main: Switch MAIN R5F clusters to Split-mode
arm64: dts: ti: k3-j7200-main: Switch MAIN R5F cluster to Split-mode

arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 2 +-
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

--
2.34.1


2023-03-29 06:46:22

by Apurva Nandan

[permalink] [raw]
Subject: [PATCH 1/2] arm64: dts: ti: k3-j721e-main: Switch MAIN R5F clusters to Split-mode

From: Suman Anna <[email protected]>

J721E SoCs have two R5F clusters in the MAIN domain, and both of these
are configured for LockStep mode at the moment. Switch both of these R5F
clusters to Split mode by default to maximize the number of R5F cores.
The MCU R5F cluster continues to be in the preferred LockStep mode.

Note that this configuration is the default for remoteproc mode (kernel
driver boots the R5F processors). These will be overridden for early-booted
remoteprocs through the corresponding IPC-only support in the K3 R5F
remoteproc driver.

Signed-off-by: Suman Anna <[email protected]>
Signed-off-by: Apurva Nandan <[email protected]>
---
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index c935622f0102..31dadbdc0d5a 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -1722,7 +1722,7 @@ watchdog1: watchdog@2210000 {

main_r5fss0: r5fss@5c00000 {
compatible = "ti,j721e-r5fss";
- ti,cluster-mode = <1>;
+ ti,cluster-mode = <0>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x5c00000 0x00 0x5c00000 0x20000>,
@@ -1762,7 +1762,7 @@ main_r5fss0_core1: r5f@5d00000 {

main_r5fss1: r5fss@5e00000 {
compatible = "ti,j721e-r5fss";
- ti,cluster-mode = <1>;
+ ti,cluster-mode = <0>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x5e00000 0x00 0x5e00000 0x20000>,
--
2.34.1

2023-03-29 06:47:17

by Apurva Nandan

[permalink] [raw]
Subject: [PATCH 2/2] arm64: dts: ti: k3-j7200-main: Switch MAIN R5F cluster to Split-mode

From: Suman Anna <[email protected]>

J7200 SoCs has a R5F cluster in each of the MAIN and MCU domains, and both
of these are configured for LockStep mode at the moment. Switch the MAIN
R5F cluster to Split mode by default to maximize the number of R5F cores.
The MCU R5F cluster continues to be in the preferred LockStep mode.

Note that this configuration is the default for remoteproc mode (kernel
driver boots the R5F processors). These will be overridden for early-booted
remoteprocs through the corresponding IPC-only support in the K3 R5F
remoteproc driver.

Signed-off-by: Suman Anna <[email protected]>
Signed-off-by: Apurva Nandan <[email protected]>
---
arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
index 138381f43ce4..573a7f949b1d 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
@@ -797,7 +797,7 @@ watchdog1: watchdog@2210000 {

main_r5fss0: r5fss@5c00000 {
compatible = "ti,j7200-r5fss";
- ti,cluster-mode = <1>;
+ ti,cluster-mode = <0>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x5c00000 0x00 0x5c00000 0x20000>,
--
2.34.1

2023-03-29 12:51:39

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-j721e-main: Switch MAIN R5F clusters to Split-mode

On 12:07-20230329, Apurva Nandan wrote:
> From: Suman Anna <[email protected]>
>
> J721E SoCs have two R5F clusters in the MAIN domain, and both of these
> are configured for LockStep mode at the moment. Switch both of these R5F
> clusters to Split mode by default to maximize the number of R5F cores.
> The MCU R5F cluster continues to be in the preferred LockStep mode.
>
> Note that this configuration is the default for remoteproc mode (kernel
> driver boots the R5F processors). These will be overridden for early-booted
> remoteprocs through the corresponding IPC-only support in the K3 R5F
> remoteproc driver.
>

This looks like a firmware specific behavior, best done in overlay along
with any custom memory map controls you may have to do for that specific
firmware.

If this is indeed a fixes, the commit message needs to clearly indicate
why this is a fix and use the Fixes tag to propogate the fixes.

> Signed-off-by: Suman Anna <[email protected]>
> Signed-off-by: Apurva Nandan <[email protected]>
> ---
> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)


>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index c935622f0102..31dadbdc0d5a 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -1722,7 +1722,7 @@ watchdog1: watchdog@2210000 {
>
> main_r5fss0: r5fss@5c00000 {
> compatible = "ti,j721e-r5fss";
> - ti,cluster-mode = <1>;
> + ti,cluster-mode = <0>;
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <0x5c00000 0x00 0x5c00000 0x20000>,
> @@ -1762,7 +1762,7 @@ main_r5fss0_core1: r5f@5d00000 {
>
> main_r5fss1: r5fss@5e00000 {
> compatible = "ti,j721e-r5fss";
> - ti,cluster-mode = <1>;
> + ti,cluster-mode = <0>;
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <0x5e00000 0x00 0x5e00000 0x20000>,
> --
> 2.34.1
>

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

2023-03-29 12:52:12

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-main: Switch MAIN R5F cluster to Split-mode

On 12:07-20230329, Apurva Nandan wrote:
> From: Suman Anna <[email protected]>
>
> J7200 SoCs has a R5F cluster in each of the MAIN and MCU domains, and both
> of these are configured for LockStep mode at the moment. Switch the MAIN
> R5F cluster to Split mode by default to maximize the number of R5F cores.
> The MCU R5F cluster continues to be in the preferred LockStep mode.
>
> Note that this configuration is the default for remoteproc mode (kernel
> driver boots the R5F processors). These will be overridden for early-booted
> remoteprocs through the corresponding IPC-only support in the K3 R5F
> remoteproc driver.

Same comment as #1.

>
> Signed-off-by: Suman Anna <[email protected]>
> Signed-off-by: Apurva Nandan <[email protected]>
> ---
> arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> index 138381f43ce4..573a7f949b1d 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> @@ -797,7 +797,7 @@ watchdog1: watchdog@2210000 {
>
> main_r5fss0: r5fss@5c00000 {
> compatible = "ti,j7200-r5fss";
> - ti,cluster-mode = <1>;
> + ti,cluster-mode = <0>;
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <0x5c00000 0x00 0x5c00000 0x20000>,
> --
> 2.34.1
>

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D