2023-06-01 18:46:55

by Nishanth Menon

Subject: [PATCH 6/9] arm64: dts: ti: k3-j721e-beagleboneai64: Add wakeup_uart pinmux

Define the wakeup uart pin-mux for completeness. This allows the
device tree usage in bootloader and firmwares that can configure the
same appropriately.

Signed-off-by: Nishanth Menon <[email protected]>
---
arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
index c13246a9ed8f..bc53ca566a68 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
@@ -531,6 +531,13 @@ J721E_WKUP_IOPAD(0xfc, PIN_INPUT_PULLUP, 0) /* (H24) WKUP_I2C0_SDA */
>;
};

+ wkup_uart0_pins_default: wkup-uart0-pins-default {
+ pinctrl-single,pins = <
+ J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */
+ J721E_WKUP_IOPAD(0xa4, PIN_OUTPUT, 0) /* (J28) WKUP_UART0_TXD */
+ >;
+ };
+
mcu_usbss1_pins_default: mcu-usbss1-pins-default {
pinctrl-single,pins = <
J721E_WKUP_IOPAD(0x3c, PIN_OUTPUT_PULLUP, 5) /* (A23) MCU_OSPI1_LBCLKO.WKUP_GPIO0_30 */
@@ -541,6 +548,8 @@ J721E_WKUP_IOPAD(0x3c, PIN_OUTPUT_PULLUP, 5) /* (A23) MCU_OSPI1_LBCLKO.WKUP_GPIO
&wkup_uart0 {
/* Wakeup UART is used by TIFS firmware. */
status = "reserved";
+ pinctrl-names = "default";
+ pinctrl-0 = <&wkup_uart0_pins_default>;
};

&main_uart0 {
--
2.40.0

2023-06-13 14:04:47

by Kumar, Udit

Subject: Re: [PATCH 6/9] arm64: dts: ti: k3-j721e-beagleboneai64: Add wakeup_uart pinmux

Hi Nishanth,

On 6/2/2023 12:01 AM, Nishanth Menon wrote:
> Define the wakeup uart pin-mux for completeness. This allows the
> device tree usage in bootloader and firmwares that can configure the
> same appropriately.
>
> Signed-off-by: Nishanth Menon <[email protected]>
> ---
> arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> index c13246a9ed8f..bc53ca566a68 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> @@ -531,6 +531,13 @@ J721E_WKUP_IOPAD(0xfc, PIN_INPUT_PULLUP, 0) /* (H24) WKUP_I2C0_SDA */
> >;
> };
>
> + wkup_uart0_pins_default: wkup-uart0-pins-default {
> + pinctrl-single,pins = <
> + J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */
> + J721E_WKUP_IOPAD(0xa4, PIN_OUTPUT, 0) /* (J28) WKUP_UART0_TXD */
> + >;
> + };
> +
> mcu_usbss1_pins_default: mcu-usbss1-pins-default {
> pinctrl-single,pins = <
> J721E_WKUP_IOPAD(0x3c, PIN_OUTPUT_PULLUP, 5) /* (A23) MCU_OSPI1_LBCLKO.WKUP_GPIO0_30 */
> @@ -541,6 +548,8 @@ J721E_WKUP_IOPAD(0x3c, PIN_OUTPUT_PULLUP, 5) /* (A23) MCU_OSPI1_LBCLKO.WKUP_GPIO
> &wkup_uart0 {
> /* Wakeup UART is used by TIFS firmware. */
> status = "reserved";
> + pinctrl-names = "default";
> + pinctrl-0 = <&wkup_uart0_pins_default>;
> };


If you like to consider alias for wkup_uart0 for this board ,

Just to align with other boards for this SOC family.  I understand
wkup_uart0 is not being used.


>
> &main_uart0 {

2023-06-14 12:14:44

by Nishanth Menon

Subject: Re: [PATCH 6/9] arm64: dts: ti: k3-j721e-beagleboneai64: Add wakeup_uart pinmux

On 19:26-20230613, Kumar, Udit wrote:
> Hi Nishanth,
>
> On 6/2/2023 12:01 AM, Nishanth Menon wrote:
> > Define the wakeup uart pin-mux for completeness. This allows the
> > device tree usage in bootloader and firmwares that can configure the
> > same appropriately.
> >
> > Signed-off-by: Nishanth Menon <[email protected]>
> > ---
> > arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> > index c13246a9ed8f..bc53ca566a68 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> > @@ -531,6 +531,13 @@ J721E_WKUP_IOPAD(0xfc, PIN_INPUT_PULLUP, 0) /* (H24) WKUP_I2C0_SDA */
> > >;
> > };
> > + wkup_uart0_pins_default: wkup-uart0-pins-default {
> > + pinctrl-single,pins = <
> > + J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */
> > + J721E_WKUP_IOPAD(0xa4, PIN_OUTPUT, 0) /* (J28) WKUP_UART0_TXD */
> > + >;
> > + };
> > +
> > mcu_usbss1_pins_default: mcu-usbss1-pins-default {
> > pinctrl-single,pins = <
> > J721E_WKUP_IOPAD(0x3c, PIN_OUTPUT_PULLUP, 5) /* (A23) MCU_OSPI1_LBCLKO.WKUP_GPIO0_30 */
> > @@ -541,6 +548,8 @@ J721E_WKUP_IOPAD(0x3c, PIN_OUTPUT_PULLUP, 5) /* (A23) MCU_OSPI1_LBCLKO.WKUP_GPIO
> > &wkup_uart0 {
> > /* Wakeup UART is used by TIFS firmware. */
> > status = "reserved";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&wkup_uart0_pins_default>;
> > };
>
>
> If you like to consider alias for wkup_uart0 for this board ,
>
> Just to align with other boards for this SOC family.? I understand
> wkup_uart0 is not being used.

Vignesh,
could you squash this locally OR if you like, I can post a v2:

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
index 3304460f6a0b..9922d7bb061f 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
@@ -20,6 +20,7 @@ / {
model = "BeagleBoard.org BeagleBone AI-64";

aliases {
+ serial0 = &wkup_uart0;
serial2 = &main_uart0;
mmc0 = &main_sdhci0;
mmc1 = &main_sdhci1;

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

2023-06-15 14:23:56

by Vignesh Raghavendra

Subject: Re: [PATCH 6/9] arm64: dts: ti: k3-j721e-beagleboneai64: Add wakeup_uart pinmux

On 14/06/23 17:33, Nishanth Menon wrote:
> On 19:26-20230613, Kumar, Udit wrote:
>> Hi Nishanth,
>>
>> On 6/2/2023 12:01 AM, Nishanth Menon wrote:
>>> Define the wakeup uart pin-mux for completeness. This allows the
>>> device tree usage in bootloader and firmwares that can configure the
>>> same appropriately.
>>>
>>> Signed-off-by: Nishanth Menon <[email protected]>
>>> ---
>>> arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
>>> index c13246a9ed8f..bc53ca566a68 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
>>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
>>> @@ -531,6 +531,13 @@ J721E_WKUP_IOPAD(0xfc, PIN_INPUT_PULLUP, 0) /* (H24) WKUP_I2C0_SDA */
>>> >;
>>> };
>>> + wkup_uart0_pins_default: wkup-uart0-pins-default {
>>> + pinctrl-single,pins = <
>>> + J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */
>>> + J721E_WKUP_IOPAD(0xa4, PIN_OUTPUT, 0) /* (J28) WKUP_UART0_TXD */
>>> + >;
>>> + };
>>> +
>>> mcu_usbss1_pins_default: mcu-usbss1-pins-default {
>>> pinctrl-single,pins = <
>>> J721E_WKUP_IOPAD(0x3c, PIN_OUTPUT_PULLUP, 5) /* (A23) MCU_OSPI1_LBCLKO.WKUP_GPIO0_30 */
>>> @@ -541,6 +548,8 @@ J721E_WKUP_IOPAD(0x3c, PIN_OUTPUT_PULLUP, 5) /* (A23) MCU_OSPI1_LBCLKO.WKUP_GPIO
>>> &wkup_uart0 {
>>> /* Wakeup UART is used by TIFS firmware. */
>>> status = "reserved";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&wkup_uart0_pins_default>;
>>> };
>>
>>
>> If you like to consider alias for wkup_uart0 for this board ,
>>
>> Just to align with other boards for this SOC family.  I understand
>> wkup_uart0 is not being used.
>
> Vignesh,
> could you squash this locally OR if you like, I can post a v2:
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> index 3304460f6a0b..9922d7bb061f 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> @@ -20,6 +20,7 @@ / {
> model = "BeagleBoard.org BeagleBone AI-64";
>
> aliases {
> + serial0 = &wkup_uart0;
> serial2 = &main_uart0;
> mmc0 = &main_sdhci0;
> mmc1 = &main_sdhci1;
>

Squashed locally before queuing, no need to resend

--
Regards
Vignesh