2023-06-02 07:41:17

by Jiasheng Jiang

Subject: [PATCH v2] gpio: ath79: Add missing check for platform_get_irq

Add the missing check for platform_get_irq and return error code
if it fails.

Signed-off-by: Jiasheng Jiang <[email protected]>
---
Changelog:

v1 -> v2:

1. Return "girq->parents[0]" instead of "-ENODEV".
---
drivers/gpio/gpio-ath79.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
index aa0a954b8392..31ce2d5c6ba0 100644
--- a/drivers/gpio/gpio-ath79.c
+++ b/drivers/gpio/gpio-ath79.c
@@ -286,6 +286,8 @@ static int ath79_gpio_probe(struct platform_device *pdev)
if (!girq->parents)
return -ENOMEM;
girq->parents[0] = platform_get_irq(pdev, 0);
+ if (girq->parents[0] < 0)
+ return girq->parents[0];
girq->default_type = IRQ_TYPE_NONE;
girq->handler = handle_simple_irq;
}
--
2.25.1

2023-06-02 13:11:27

by Andy Shevchenko

Subject: Re: [PATCH v2] gpio: ath79: Add missing check for platform_get_irq

On Fri, Jun 2, 2023 at 10:33 AM Jiasheng Jiang <[email protected]> wrote:
>
> Add the missing check for platform_get_irq and return error code
> if it fails.

The template for function references is func().
Otherwise looks fine to me
Reviewed-by: Andy Shevchenko <[email protected]>

> Signed-off-by: Jiasheng Jiang <[email protected]>
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. Return "girq->parents[0]" instead of "-ENODEV".
> ---
> drivers/gpio/gpio-ath79.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
> index aa0a954b8392..31ce2d5c6ba0 100644
> --- a/drivers/gpio/gpio-ath79.c
> +++ b/drivers/gpio/gpio-ath79.c
> @@ -286,6 +286,8 @@ static int ath79_gpio_probe(struct platform_device *pdev)
> if (!girq->parents)
> return -ENOMEM;
> girq->parents[0] = platform_get_irq(pdev, 0);
> + if (girq->parents[0] < 0)
> + return girq->parents[0];
> girq->default_type = IRQ_TYPE_NONE;
> girq->handler = handle_simple_irq;
> }
> --
> 2.25.1
>


--
With Best Regards,
Andy Shevchenko