2023-06-05 14:54:57

by Andy Shevchenko

Subject: [PATCH v1 1/1] pinctrl: cherryview: Return correct value if pin in push-pull mode

Currently the getter returns ENOTSUPP on pin configured in
the push-pull mode. Fix this by adding the missed switch case.

Fixes: ccdf81d08dbe ("pinctrl: cherryview: add option to set open-drain pin config")
Fixes: 6e08d6bbebeb ("pinctrl: Add Intel Cherryview/Braswell pin controller support")
Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/pinctrl/intel/pinctrl-cherryview.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
index ee333337bc1b..b25717d54f69 100644
--- a/drivers/pinctrl/intel/pinctrl-cherryview.c
+++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
@@ -949,11 +949,6 @@ static int chv_config_get(struct pinctrl_dev *pctldev, unsigned int pin,

break;

- case PIN_CONFIG_DRIVE_OPEN_DRAIN:
- if (!(ctrl1 & CHV_PADCTRL1_ODEN))
- return -EINVAL;
- break;
-
case PIN_CONFIG_BIAS_HIGH_IMPEDANCE: {
u32 cfg;

@@ -963,6 +958,16 @@ static int chv_config_get(struct pinctrl_dev *pctldev, unsigned int pin,
return -EINVAL;

break;
+
+ case PIN_CONFIG_DRIVE_PUSH_PULL:
+ if (ctrl1 & CHV_PADCTRL1_ODEN)
+ return -EINVAL;
+ break;
+
+ case PIN_CONFIG_DRIVE_OPEN_DRAIN:
+ if (!(ctrl1 & CHV_PADCTRL1_ODEN))
+ return -EINVAL;
+ break;
}

default:
--
2.40.0.1.gaa8946217a0b

2023-06-06 05:16:08

by Mika Westerberg

Subject: Re: [PATCH v1 1/1] pinctrl: cherryview: Return correct value if pin in push-pull mode

On Mon, Jun 05, 2023 at 05:37:34PM +0300, Andy Shevchenko wrote:
> Currently the getter returns ENOTSUPP on pin configured in
> the push-pull mode. Fix this by adding the missed switch case.
>
> Fixes: ccdf81d08dbe ("pinctrl: cherryview: add option to set open-drain pin config")
> Fixes: 6e08d6bbebeb ("pinctrl: Add Intel Cherryview/Braswell pin controller support")
> Signed-off-by: Andy Shevchenko <[email protected]>

Acked-by: Mika Westerberg <[email protected]>

2023-06-06 13:26:32

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] pinctrl: cherryview: Return correct value if pin in push-pull mode

On Tue, Jun 06, 2023 at 08:11:16AM +0300, Mika Westerberg wrote:
> On Mon, Jun 05, 2023 at 05:37:34PM +0300, Andy Shevchenko wrote:
> > Currently the getter returns ENOTSUPP on pin configured in
> > the push-pull mode. Fix this by adding the missed switch case.
> >
> > Fixes: ccdf81d08dbe ("pinctrl: cherryview: add option to set open-drain pin config")
> > Fixes: 6e08d6bbebeb ("pinctrl: Add Intel Cherryview/Braswell pin controller support")
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
> Acked-by: Mika Westerberg <[email protected]>

Pushed to my review and testing queue, thanks!

--
With Best Regards,
Andy Shevchenko