2023-06-11 12:15:51

by Tom Rix

Subject: [PATCH] sysctl: set variable sysctl_mount_point storage-class-specifier to static

smatch reports
fs/proc/proc_sysctl.c:32:18: warning: symbol
'sysctl_mount_point' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static.

Signed-off-by: Tom Rix <[email protected]>
---
fs/proc/proc_sysctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index 2715e6114933..67872cbc0517 100644
--- a/fs/proc/proc_sysctl.c
+++ b/fs/proc/proc_sysctl.c
@@ -29,7 +29,7 @@ static const struct file_operations proc_sys_dir_file_operations;
static const struct inode_operations proc_sys_dir_operations;

/* Support for permanently empty directories */
-struct ctl_table sysctl_mount_point[] = {
+static struct ctl_table sysctl_mount_point[] = {
{.flags = SYSCTL_PERM_EMPTY_DIR }
};

--
2.27.0

2023-06-13 20:48:57

by Kees Cook

Subject: Re: [PATCH] sysctl: set variable sysctl_mount_point storage-class-specifier to static

On Sun, Jun 11, 2023 at 08:07:25AM -0400, Tom Rix wrote:
> smatch reports
> fs/proc/proc_sysctl.c:32:18: warning: symbol
> 'sysctl_mount_point' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static.
>
> Signed-off-by: Tom Rix <[email protected]>

Reviewed-by: Kees Cook <[email protected]>

--
Kees Cook

2023-06-30 23:55:05

by Luis Chamberlain

Subject: Re: [PATCH] sysctl: set variable sysctl_mount_point storage-class-specifier to static

On Tue, Jun 13, 2023 at 01:30:47PM -0700, Kees Cook wrote:
> On Sun, Jun 11, 2023 at 08:07:25AM -0400, Tom Rix wrote:
> > smatch reports
> > fs/proc/proc_sysctl.c:32:18: warning: symbol
> > 'sysctl_mount_point' was not declared. Should it be static?
> >
> > This variable is only used in its defining file, so it should be static.
> >
> > Signed-off-by: Tom Rix <[email protected]>
>
> Reviewed-by: Kees Cook <[email protected]>

Queued up, thanks!

Luis