2023-07-05 09:16:46

by Minjie Du

Subject: [PATCH v1] sound: seq: check struct system assignment problem

make data->system.parm1 avoid double assignment.
but note writes "RT message with two parameters to UMP"
is one of assignment is for system.parm2?
I'm not sure, Could you help check it out?
Thank you!


Signed-off-by: Minjie Du <[email protected]>
---
sound/core/seq/seq_ump_convert.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c
index eb1d86ff6..60e637149 100644
--- a/sound/core/seq/seq_ump_convert.c
+++ b/sound/core/seq/seq_ump_convert.c
@@ -713,7 +713,6 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event,
unsigned char status)
{
data->system.status = status;
- data->system.parm1 = (event->data.control.value >> 7) & 0x7f;
data->system.parm1 = event->data.control.value & 0x7f;
return 1;
}
--
2.39.0

2023-07-05 09:19:12

by Takashi Iwai

Subject: Re: [PATCH v1] sound: seq: check struct system assignment problem

On Wed, 05 Jul 2023 10:50:22 +0200,
Minjie Du wrote:
>
> make data->system.parm1 avoid double assignment.
> but note writes "RT message with two parameters to UMP"
> is one of assignment is for system.parm2?

Yes, that should be rather parm2.
Could you resubmit with that typo fix instead?


Thanks!

Takashi

> I'm not sure, Could you help check it out?
> Thank you!
>
>
> Signed-off-by: Minjie Du <[email protected]>
> ---
> sound/core/seq/seq_ump_convert.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c
> index eb1d86ff6..60e637149 100644
> --- a/sound/core/seq/seq_ump_convert.c
> +++ b/sound/core/seq/seq_ump_convert.c
> @@ -713,7 +713,6 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event,
> unsigned char status)
> {
> data->system.status = status;
> - data->system.parm1 = (event->data.control.value >> 7) & 0x7f;
> data->system.parm1 = event->data.control.value & 0x7f;
> return 1;
> }
> --
> 2.39.0
>