2023-07-05 11:50:15

by Minjie Du

Subject: [PATCH v2] dmaengine: xilinx: xdma: Fix Judgment of the return value

Fix: make IS_ERR() judge the devm_ioremap_resource() function return.

Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver")
Signed-off-by: Minjie Du <[email protected]>
---
drivers/dma/xilinx/xdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
index 93ee298d5..ad5ff6335 100644
--- a/drivers/dma/xilinx/xdma.c
+++ b/drivers/dma/xilinx/xdma.c
@@ -892,7 +892,7 @@ static int xdma_probe(struct platform_device *pdev)
}

reg_base = devm_ioremap_resource(&pdev->dev, res);
- if (!reg_base) {
+ if (IS_ERR(reg_base)) {
xdma_err(xdev, "ioremap failed");
goto failed;
}
--
2.39.0

2023-07-07 05:15:30

by Michal Simek

Subject: Re: [PATCH v2] dmaengine: xilinx: xdma: Fix Judgment of the return value

On 7/5/23 13:39, Minjie Du wrote:
> Fix: make IS_ERR() judge the devm_ioremap_resource() function return.
>
> Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver")
> Signed-off-by: Minjie Du <[email protected]>
> ---
> drivers/dma/xilinx/xdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
> index 93ee298d5..ad5ff6335 100644
> --- a/drivers/dma/xilinx/xdma.c
> +++ b/drivers/dma/xilinx/xdma.c
> @@ -892,7 +892,7 @@ static int xdma_probe(struct platform_device *pdev)
> }
>
> reg_base = devm_ioremap_resource(&pdev->dev, res);
> - if (!reg_base) {
> + if (IS_ERR(reg_base)) {
> xdma_err(xdev, "ioremap failed");
> goto failed;
> }

Acked-by: Michal Simek <[email protected]>

M

2023-07-11 16:52:23

by Vinod Koul

Subject: Re: [PATCH v2] dmaengine: xilinx: xdma: Fix Judgment of the return value

On Wed, 05 Jul 2023 19:39:12 +0800, Minjie Du wrote:
> Fix: make IS_ERR() judge the devm_ioremap_resource() function return.
>
>

Applied, thanks!

[1/1] dmaengine: xilinx: xdma: Fix Judgment of the return value
commit: 625758896cc84ce0e5dc9842c34d4b9fa23b8b36

Best regards,
--
~Vinod