2023-07-06 16:27:08

by Henning Schild

Subject: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header

This was found with giving the file to checkpatch.

Signed-off-by: Henning Schild <[email protected]>
---
drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h b/drivers/leds/simple/simatic-ipc-leds-gpio.h
index bf258c32f83d..3d4877aa4e0c 100644
--- a/drivers/leds/simple/simatic-ipc-leds-gpio.h
+++ b/drivers/leds/simple/simatic-ipc-leds-gpio.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Siemens SIMATIC IPC driver for GPIO based LEDs
*
--
2.39.3

2023-07-12 12:18:11

by Lee Jones

Subject: Re: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header

On Thu, 06 Jul 2023, Henning Schild wrote:

> This was found with giving the file to checkpatch.
>
> Signed-off-by: Henning Schild <[email protected]>
> ---
> drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h b/drivers/leds/simple/simatic-ipc-leds-gpio.h
> index bf258c32f83d..3d4877aa4e0c 100644
> --- a/drivers/leds/simple/simatic-ipc-leds-gpio.h
> +++ b/drivers/leds/simple/simatic-ipc-leds-gpio.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */

What prompted this change?

% git grep -F "// SPDX-License-Identifier:" -- drivers/leds | wc -l
117
% git grep -F "/* SPDX-License-Identifier:" -- drivers/leds | wc -l
2

--
Lee Jones [李琼斯]

2023-07-12 12:37:44

by Henning Schild

Subject: Re: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header

Am Wed, 12 Jul 2023 12:52:52 +0100
schrieb Lee Jones <[email protected]>:

> On Thu, 06 Jul 2023, Henning Schild wrote:
>
> > This was found with giving the file to checkpatch.
> >
> > Signed-off-by: Henning Schild <[email protected]>
> > ---
> > drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h
> > b/drivers/leds/simple/simatic-ipc-leds-gpio.h index
> > bf258c32f83d..3d4877aa4e0c 100644 ---
> > a/drivers/leds/simple/simatic-ipc-leds-gpio.h +++
> > b/drivers/leds/simple/simatic-ipc-leds-gpio.h @@ -1,4 +1,4 @@
> > -// SPDX-License-Identifier: GPL-2.0
> > +/* SPDX-License-Identifier: GPL-2.0 */
>
> What prompted this change?
>
> % git grep -F "// SPDX-License-Identifier:" -- drivers/leds | wc -l
> 117
> % git grep -F "/* SPDX-License-Identifier:" -- drivers/leds | wc -l
> 2
>

./scripts/checkpatch.pl --no-tree --file
drivers/leds/simple/simatic-ipc-leds-gpio.h

it boils down to header versus c-file, not sure why headers prefer that
other style

Henning

2023-07-13 16:03:37

by Lee Jones

Subject: Re: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header

On Wed, 12 Jul 2023, Henning Schild wrote:

> Am Wed, 12 Jul 2023 12:52:52 +0100
> schrieb Lee Jones <[email protected]>:
>
> > On Thu, 06 Jul 2023, Henning Schild wrote:
> >
> > > This was found with giving the file to checkpatch.
> > >
> > > Signed-off-by: Henning Schild <[email protected]>
> > > ---
> > > drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h
> > > b/drivers/leds/simple/simatic-ipc-leds-gpio.h index
> > > bf258c32f83d..3d4877aa4e0c 100644 ---
> > > a/drivers/leds/simple/simatic-ipc-leds-gpio.h +++
> > > b/drivers/leds/simple/simatic-ipc-leds-gpio.h @@ -1,4 +1,4 @@
> > > -// SPDX-License-Identifier: GPL-2.0
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> >
> > What prompted this change?
> >
> > % git grep -F "// SPDX-License-Identifier:" -- drivers/leds | wc -l
> > 117
> > % git grep -F "/* SPDX-License-Identifier:" -- drivers/leds | wc -l
> > 2
> >
>
> ./scripts/checkpatch.pl --no-tree --file
> drivers/leds/simple/simatic-ipc-leds-gpio.h
>
> it boils down to header versus c-file, not sure why headers prefer that
> other style

Ah yes, that one. Okay.

--
Lee Jones [李琼斯]

2023-07-13 16:26:20

by Lee Jones

Subject: Re: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header

On Thu, 06 Jul 2023, Henning Schild wrote:

> This was found with giving the file to checkpatch.
>
> Signed-off-by: Henning Schild <[email protected]>
> ---
> drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

--
Lee Jones [李琼斯]