2023-07-10 06:26:24

by John Sanpe

Subject: [PATCH v2 2/2] libbpf: fix some typo of hashmap init

Remove the whole HASHMAP_INIT. It's not used anywhere in libbpf.

Signed-off-by: John Sanpe <[email protected]>
---
tools/lib/bpf/hashmap.h | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/tools/lib/bpf/hashmap.h b/tools/lib/bpf/hashmap.h
index bae3feaf29d0..c12f8320e668 100644
--- a/tools/lib/bpf/hashmap.h
+++ b/tools/lib/bpf/hashmap.h
@@ -80,16 +80,6 @@ struct hashmap {
size_t sz;
};

-#define HASHMAP_INIT(_hash_fn, _equal_fn, _ctx) { \
- .hash_fn = (_hash_fn), \
- .equal_fn = (_equal_fn), \
- .ctx = (_ctx), \
- .buckets = NULL, \
- .cap = 0, \
- .cap_bits = 0, \
- .sz = 0, \
-}
-
void hashmap__init(struct hashmap *map, hashmap_hash_fn hash_fn,
hashmap_equal_fn equal_fn, void *ctx);
struct hashmap *hashmap__new(hashmap_hash_fn hash_fn,
--
2.40.1

2023-07-10 17:29:41

by Stanislav Fomichev

Subject: Re: [PATCH v2 2/2] libbpf: fix some typo of hashmap init

On 07/10, John Sanpe wrote:
> Remove the whole HASHMAP_INIT. It's not used anywhere in libbpf.
>
> Signed-off-by: John Sanpe <[email protected]>

Acked-by: Stanislav Fomichev <[email protected]>

Doesn't look like it was ever used.

2023-07-10 21:50:47

by Andrii Nakryiko

Subject: Re: [PATCH v2 2/2] libbpf: fix some typo of hashmap init

On Mon, Jul 10, 2023 at 10:25 AM Stanislav Fomichev <[email protected]> wrote:
>
> On 07/10, John Sanpe wrote:
> > Remove the whole HASHMAP_INIT. It's not used anywhere in libbpf.
> >
> > Signed-off-by: John Sanpe <[email protected]>
>
> Acked-by: Stanislav Fomichev <[email protected]>
>
> Doesn't look like it was ever used.

Ack for the change, but the subject doesn't correspond to the change
itself. You are not fixing typo, you are removing static
initialization helper.

2023-07-11 07:16:35

by John Sanpe

Subject: Re: [PATCH v2 2/2] libbpf: fix some typo of hashmap init

On 7/11/23 05:12, Andrii Nakryiko wrote:

> On Mon, Jul 10, 2023 at 10:25 AM Stanislav Fomichev<[email protected]> wrote:
>> On 07/10, John Sanpe wrote:
>>> Remove the whole HASHMAP_INIT. It's not used anywhere in libbpf.
>>>
>>> Signed-off-by: John Sanpe<[email protected]>
>> Acked-by: Stanislav Fomichev<[email protected]>
>>
>> Doesn't look like it was ever used.
> Ack for the change, but the subject doesn't correspond to the change
> itself. You are not fixing typo, you are removing static
> initialization helper.

Thanks for your suggestion, I have merged the two commits and used a
more reasonable subject in v3:

https://lore.kernel.org/all/[email protected]