2023-07-25 10:36:29

by Andrei Coardos

Subject: [PATCH v2] gpio: lp3943: remove unneeded platform_set_drvdata() call

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call, to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <[email protected]>
Signed-off-by: Andrei Coardos <[email protected]>
---

Changelog V1->V2:
* https://lore.kernel.org/linux-gpio/CAHp75VdU1c1vUoRpbekPXoLg2DDcbSThwUmkdHRT2FaZ9kagRA@mail.gmail.com/T/#t
* https://lore.kernel.org/linux-gpio/ZLpdOYxo2U+uO%[email protected]/T/#t
* fixed subject line: adjusted colons where needed

drivers/gpio/gpio-lp3943.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-lp3943.c b/drivers/gpio/gpio-lp3943.c
index 79edd5db49d2..8e58242f5123 100644
--- a/drivers/gpio/gpio-lp3943.c
+++ b/drivers/gpio/gpio-lp3943.c
@@ -199,8 +199,6 @@ static int lp3943_gpio_probe(struct platform_device *pdev)
lp3943_gpio->chip = lp3943_gpio_chip;
lp3943_gpio->chip.parent = &pdev->dev;

- platform_set_drvdata(pdev, lp3943_gpio);
-
return devm_gpiochip_add_data(&pdev->dev, &lp3943_gpio->chip,
lp3943_gpio);
}
--
2.34.1

2023-07-25 10:56:16

by Andy Shevchenko

Subject: Re: [PATCH v2] gpio: lp3943: remove unneeded platform_set_drvdata() call

On Tue, Jul 25, 2023 at 01:25:32PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call, to access the private data of the driver.
> Also, the private data is defined in this driver, so there is no risk of
> it being accessed outside of this driver file.

Reviewed-by: Andy Shevchenko <[email protected]>


--
With Best Regards,
Andy Shevchenko

2023-08-01 19:41:03

by Bartosz Golaszewski

Subject: Re: [PATCH v2] gpio: lp3943: remove unneeded platform_set_drvdata() call

On Tue, Jul 25, 2023 at 12:25 PM Andrei Coardos <[email protected]> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call, to access the private data of the driver.
> Also, the private data is defined in this driver, so there is no risk of
> it being accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <[email protected]>
> Signed-off-by: Andrei Coardos <[email protected]>
> ---
>
> Changelog V1->V2:
> * https://lore.kernel.org/linux-gpio/CAHp75VdU1c1vUoRpbekPXoLg2DDcbSThwUmkdHRT2FaZ9kagRA@mail.gmail.com/T/#t
> * https://lore.kernel.org/linux-gpio/ZLpdOYxo2U+uO%[email protected]/T/#t
> * fixed subject line: adjusted colons where needed
>
> drivers/gpio/gpio-lp3943.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-lp3943.c b/drivers/gpio/gpio-lp3943.c
> index 79edd5db49d2..8e58242f5123 100644
> --- a/drivers/gpio/gpio-lp3943.c
> +++ b/drivers/gpio/gpio-lp3943.c
> @@ -199,8 +199,6 @@ static int lp3943_gpio_probe(struct platform_device *pdev)
> lp3943_gpio->chip = lp3943_gpio_chip;
> lp3943_gpio->chip.parent = &pdev->dev;
>
> - platform_set_drvdata(pdev, lp3943_gpio);
> -
> return devm_gpiochip_add_data(&pdev->dev, &lp3943_gpio->chip,
> lp3943_gpio);
> }
> --
> 2.34.1
>

Applied, thanks!

Bartosz