From: Shixiong Ou <[email protected]>
If PCI_ATS isn't set, then pdev->physfn is not defined.
it causes a compilation issue:
../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’?
165 | __func__, pci_dev_id(pdev->physfn), pci_id, vf_id,
| ^~~~~~
So adding PCI_IOV depends to select PCI_ATS.
Signed-off-by: Shixiong Ou <[email protected]>
---
drivers/vfio/pci/pds/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vfio/pci/pds/Kconfig b/drivers/vfio/pci/pds/Kconfig
index 407b3fd32733..6eceef7b028a 100644
--- a/drivers/vfio/pci/pds/Kconfig
+++ b/drivers/vfio/pci/pds/Kconfig
@@ -3,7 +3,7 @@
config PDS_VFIO_PCI
tristate "VFIO support for PDS PCI devices"
- depends on PDS_CORE
+ depends on PDS_CORE && PCI_IOV
select VFIO_PCI_CORE
help
This provides generic PCI support for PDS devices using the VFIO
--
2.25.1
On Wed, 6 Sep 2023 09:49:42 +0800
oushixiong <[email protected]> wrote:
> From: Shixiong Ou <[email protected]>
>
> If PCI_ATS isn't set, then pdev->physfn is not defined.
> it causes a compilation issue:
>
> ../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’?
> 165 | __func__, pci_dev_id(pdev->physfn), pci_id, vf_id,
> | ^~~~~~
>
> So adding PCI_IOV depends to select PCI_ATS.
>
> Signed-off-by: Shixiong Ou <[email protected]>
> ---
> drivers/vfio/pci/pds/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to vfio for-linus branch for v6.6. Thanks,
Alex
>
> diff --git a/drivers/vfio/pci/pds/Kconfig b/drivers/vfio/pci/pds/Kconfig
> index 407b3fd32733..6eceef7b028a 100644
> --- a/drivers/vfio/pci/pds/Kconfig
> +++ b/drivers/vfio/pci/pds/Kconfig
> @@ -3,7 +3,7 @@
>
> config PDS_VFIO_PCI
> tristate "VFIO support for PDS PCI devices"
> - depends on PDS_CORE
> + depends on PDS_CORE && PCI_IOV
> select VFIO_PCI_CORE
> help
> This provides generic PCI support for PDS devices using the VFIO