On Tue, Sep 19, 2023 at 04:02:08PM +0800, Edward AD wrote:
> When the call to gsm_register_devices() fails, we need to reclaim the memory
> requested in gsm_dlci_alloc().
>
> Fixes: 01aecd917114 ("tty: n_gsm: fix tty registration before control channel open")
> Reported-and-tested-by: [email protected]
> Signed-off-by: Edward AD <[email protected]>
Please use your company name/email address, and then just set a manual
"From:" line as the first line in the changelog as the documentation
asks. That's how developers work around their broken corporate email
systems (but really, you should go and poke your IT group to fix it.)
thanks,
greg k-h
On Tue, 19 Sep 2023 10:29:08 +0200 Greg KH wrote:
> > When the call to gsm_register_devices() fails, we need to reclaim the memory
> > requested in gsm_dlci_alloc().
> >
> > Fixes: 01aecd917114 ("tty: n_gsm: fix tty registration before control channel open")
> > Reported-and-tested-by: [email protected]
> > Signed-off-by: Edward AD <[email protected]>
>
> Please use your company name/email address, and then just set a manual
> "From:" line as the first line in the changelog as the documentation
> asks. That's how developers work around their broken corporate email
> systems (but really, you should go and poke your IT group to fix it.)
This repair was completed in my personal time. Additionally, there may be a
possibility of the company's email being thrown away by 'lore.kernel.org'.
If you are not very strict with this, I will continue to use my private email.
I will only keep one line starting with 'From:' in the patch.
Thanks,
edward
On Tue, Sep 19, 2023 at 05:22:26PM +0800, Edward AD wrote:
> On Tue, 19 Sep 2023 10:29:08 +0200 Greg KH wrote:
> > > When the call to gsm_register_devices() fails, we need to reclaim the memory
> > > requested in gsm_dlci_alloc().
> > >
> > > Fixes: 01aecd917114 ("tty: n_gsm: fix tty registration before control channel open")
> > > Reported-and-tested-by: [email protected]
> > > Signed-off-by: Edward AD <[email protected]>
> >
> > Please use your company name/email address, and then just set a manual
> > "From:" line as the first line in the changelog as the documentation
> > asks. That's how developers work around their broken corporate email
> > systems (but really, you should go and poke your IT group to fix it.)
> This repair was completed in my personal time. Additionally, there may be a
> possibility of the company's email being thrown away by 'lore.kernel.org'.
> If you are not very strict with this, I will continue to use my private email.
As you previously submitted this under your company name/address, we
have to be strict for obvious reasons, sorry.
> I will only keep one line starting with 'From:' in the patch.
I don't understand what you mean by this.
greg k-h
On Tue, 19 Sep 2023 11:31:57 +0200 Greg KH wrote:
> > On Tue, 19 Sep 2023 10:29:08 +0200 Greg KH wrote:
> > > > When the call to gsm_register_devices() fails, we need to reclaim the memory
> > > > requested in gsm_dlci_alloc().
> > > >
> > > > Fixes: 01aecd917114 ("tty: n_gsm: fix tty registration before control channel open")
> > > > Reported-and-tested-by: [email protected]
> > > > Signed-off-by: Edward AD <[email protected]>
> > >
> > > Please use your company name/email address, and then just set a manual
> > > "From:" line as the first line in the changelog as the documentation
> > > asks. That's how developers work around their broken corporate email
> > > systems (but really, you should go and poke your IT group to fix it.)
> > This repair was completed in my personal time. Additionally, there may be a
> > possibility of the company's email being thrown away by 'lore.kernel.org'.
> > If you are not very strict with this, I will continue to use my private email.
>
> As you previously submitted this under your company name/address, we
> have to be strict for obvious reasons, sorry.
Before sending this email, according to your reply, I sent a new patch via email [email protected].
But we can't see that email in lore.kernel.org
>
> > I will only keep one line starting with 'From:' in the patch.
>
> I don't understand what you mean by this.
Just set a manual "From:" line as the first line in the changelog as the
documentation asks.
Thanks,
edward