2023-09-25 02:42:03

by Dinghao Liu

Subject: [PATCH] mfd: dln2: Fix double put in dln2_probe

The dln2_free() already contains usb_put_dev(). Therefore,
the redundant usb_put_dev() before dln2_free() may lead to
a double free.

Fixes: 96da8f148396 ("mfd: dln2: Fix memory leak in dln2_probe()")
Signed-off-by: Dinghao Liu <[email protected]>
---
drivers/mfd/dln2.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c
index c7510434380a..fbbe82c6e75b 100644
--- a/drivers/mfd/dln2.c
+++ b/drivers/mfd/dln2.c
@@ -826,7 +826,6 @@ static int dln2_probe(struct usb_interface *interface,
dln2_stop_rx_urbs(dln2);

out_free:
- usb_put_dev(dln2->usb_dev);
dln2_free(dln2);

return ret;
--
2.17.1

2023-09-28 13:39:28

by Lee Jones

Subject: Re: (subset) [PATCH] mfd: dln2: Fix double put in dln2_probe

On Mon, 25 Sep 2023 10:41:33 +0800, Dinghao Liu wrote:
> The dln2_free() already contains usb_put_dev(). Therefore,
> the redundant usb_put_dev() before dln2_free() may lead to
> a double free.
>
>

Applied, thanks!

[1/1] mfd: dln2: Fix double put in dln2_probe
commit: 20890756e8753844de76afdf757cb74c6bab3e8b

--
Lee Jones [李琼斯]