2023-09-28 16:44:49

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v1] misc: fastrpc: Reset metadata buffer to avoid incorrect free

On Thu, Aug 31, 2023 at 12:05:23PM +0530, Ekansh Gupta wrote:
> Metadata buffer is allocated during get_args for any remote call.
> This buffer carries buffers, fdlists and other payload information
> for the call. If the buffer is not reset, put_args might find some
> garbage FDs in the fdlist which might have an existing mapping in
> the list. This could result in improper freeing of FD map when DSP
> might still be using the buffer. Added change to reset the metadata
> buffer after allocation.
>
> Signed-off-by: Ekansh Gupta <[email protected]>

What commit id does this fix?

And you sent 3 patches, but not in a list, what order are they to be
applied in?

thanks,

greg k-h


2023-09-29 19:35:55

by Ekansh Gupta

[permalink] [raw]
Subject: Re: [PATCH v1] misc: fastrpc: Reset metadata buffer to avoid incorrect free



On 9/28/2023 6:38 PM, Greg KH wrote:
> On Thu, Aug 31, 2023 at 12:05:23PM +0530, Ekansh Gupta wrote:
>> Metadata buffer is allocated during get_args for any remote call.
>> This buffer carries buffers, fdlists and other payload information
>> for the call. If the buffer is not reset, put_args might find some
>> garbage FDs in the fdlist which might have an existing mapping in
>> the list. This could result in improper freeing of FD map when DSP
>> might still be using the buffer. Added change to reset the metadata
>> buffer after allocation.
>>
>> Signed-off-by: Ekansh Gupta <[email protected]>
>
> What commit id does this fix?
>
> And you sent 3 patches, but not in a list, what order are they to be
> applied in?
>
Thanks for reviewing the patches, Greg. I'll send the 3 patches as a
patch series for better understanding.

-ekansh
> thanks,
>
> greg k-h