On Thu, 09 Nov 2023 09:50:32 +0100, Florian Eckert wrote:
> Changes in v8:
> ==============
> - As requested by greg k-h [6], I have send the patch 2/7 of this series
> about the memory leak also to stable.vger.kernel.org [7]. This has
> already received a 'Reviewed-by' from Uwe [8].
> - As requested by Maarten, I have adopted his suggestion to invert the LED
> blink, so that I do not have to save the 'state' in the tty data
> struct [9].
>
> [...]
Applied, thanks!
[1/6] tty: add new helper function tty_get_tiocm
commit: 5d11a4709f552fa139c2439fead05daeb064a6f4
[2/6] leds: ledtrig-tty: free allocated ttyname buffer on deactivate
(no commit info)
[3/6] leds: ledtrig-tty: change logging if get icount failed
(no commit info)
[4/6] leds: ledtrig-tty: replace mutex with completion
(no commit info)
[5/6] leds: ledtrig-tty: make rx tx activitate configurable
(no commit info)
[6/6] leds: ledtrig-tty: add additional line state evaluation
(no commit info)
--
Lee Jones [李琼斯]
On 2023-12-01 11:40, Lee Jones wrote:
> On Thu, 09 Nov 2023 09:50:32 +0100, Florian Eckert wrote:
>> Changes in v8:
>> ==============
>> - As requested by greg k-h [6], I have send the patch 2/7 of this
>> series
>> about the memory leak also to stable.vger.kernel.org [7]. This has
>> already received a 'Reviewed-by' from Uwe [8].
>> - As requested by Maarten, I have adopted his suggestion to invert the
>> LED
>> blink, so that I do not have to save the 'state' in the tty data
>> struct [9].
>>
>> [...]
>
> Applied, thanks!
>
> [1/6] tty: add new helper function tty_get_tiocm
> commit: 5d11a4709f552fa139c2439fead05daeb064a6f4
> [2/6] leds: ledtrig-tty: free allocated ttyname buffer on deactivate
> (no commit info)
> [3/6] leds: ledtrig-tty: change logging if get icount failed
> (no commit info)
> [4/6] leds: ledtrig-tty: replace mutex with completion
> (no commit info)
> [5/6] leds: ledtrig-tty: make rx tx activitate configurable
> (no commit info)
> [6/6] leds: ledtrig-tty: add additional line state evaluation
> (no commit info)
I think that was a mistake? Patchset v9 is the correct patchset [1]?
Thanks for applying v9 [1]
Best regards
Florian
Links:
[1]
https://lore.kernel.org/all/[email protected]/
On Fri, 01 Dec 2023, Florian Eckert wrote:
>
>
> On 2023-12-01 11:40, Lee Jones wrote:
> > On Thu, 09 Nov 2023 09:50:32 +0100, Florian Eckert wrote:
> > > Changes in v8:
> > > ==============
> > > - As requested by greg k-h [6], I have send the patch 2/7 of this
> > > series
> > > about the memory leak also to stable.vger.kernel.org [7]. This has
> > > already received a 'Reviewed-by' from Uwe [8].
> > > - As requested by Maarten, I have adopted his suggestion to invert
> > > the LED
> > > blink, so that I do not have to save the 'state' in the tty data
> > > struct [9].
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/6] tty: add new helper function tty_get_tiocm
> > commit: 5d11a4709f552fa139c2439fead05daeb064a6f4
> > [2/6] leds: ledtrig-tty: free allocated ttyname buffer on deactivate
> > (no commit info)
> > [3/6] leds: ledtrig-tty: change logging if get icount failed
> > (no commit info)
> > [4/6] leds: ledtrig-tty: replace mutex with completion
> > (no commit info)
> > [5/6] leds: ledtrig-tty: make rx tx activitate configurable
> > (no commit info)
> > [6/6] leds: ledtrig-tty: add additional line state evaluation
> > (no commit info)
>
> I think that was a mistake? Patchset v9 is the correct patchset [1]?
>
> Thanks for applying v9 [1]
It's automated. Not sure what happened now.
Please check to ensure the correct set was applied.
--
Lee Jones [李琼斯]
On 2023-12-06 14:47, Lee Jones wrote:
> On Fri, 01 Dec 2023, Florian Eckert wrote:
>> On 2023-12-01 11:40, Lee Jones wrote:
>> > Applied, thanks!
>> >
>> > [1/6] tty: add new helper function tty_get_tiocm
>> > commit: 5d11a4709f552fa139c2439fead05daeb064a6f4
>> > [2/6] leds: ledtrig-tty: free allocated ttyname buffer on deactivate
>> > (no commit info)
>> > [3/6] leds: ledtrig-tty: change logging if get icount failed
>> > (no commit info)
>> > [4/6] leds: ledtrig-tty: replace mutex with completion
>> > (no commit info)
>> > [5/6] leds: ledtrig-tty: make rx tx activitate configurable
>> > (no commit info)
>> > [6/6] leds: ledtrig-tty: add additional line state evaluation
>> > (no commit info)
>>
>> I think that was a mistake? Patchset v9 is the correct patchset [1]?
>>
>> Thanks for applying v9 [1]
>
> It's automated. Not sure what happened now.
>
> Please check to ensure the correct set was applied.
I have checked that v9 is appled to the branch for-leds-next [1].
I can confirm that v9 patchset is applied there.
Thanks
Best regards
Florian
Links:
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/log/?h=for-leds-next