2023-12-12 03:18:27

by Ji Sheng Teoh

[permalink] [raw]
Subject: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100

Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100
watchdog.
Since JH8100 watchdog only has 1 reset signal, update binding
document to support one reset for "starfive,jh8100-wdt" compatible.

Signed-off-by: Ley Foon Tan <[email protected]>
Signed-off-by: Ji Sheng Teoh <[email protected]>
---
.../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
index 68f3f6fd08a6..02572b16ac08 100644
--- a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
@@ -27,6 +27,7 @@ properties:
enum:
- starfive,jh7100-wdt
- starfive,jh7110-wdt
+ - starfive,jh8100-wdt

reg:
maxItems: 1
@@ -45,6 +46,7 @@ properties:
- const: core

resets:
+ minItems: 1
items:
- description: APB reset
- description: Core reset
--
2.25.1


2023-12-12 16:46:22

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100

On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote:
> Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100
> watchdog.
> Since JH8100 watchdog only has 1 reset signal, update binding
> document to support one reset for "starfive,jh8100-wdt" compatible.
>
> Signed-off-by: Ley Foon Tan <[email protected]>
> Signed-off-by: Ji Sheng Teoh <[email protected]>
> ---
> .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> index 68f3f6fd08a6..02572b16ac08 100644
> --- a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> @@ -27,6 +27,7 @@ properties:
> enum:
> - starfive,jh7100-wdt
> - starfive,jh7110-wdt
> + - starfive,jh8100-wdt
>
> reg:
> maxItems: 1
> @@ -45,6 +46,7 @@ properties:
> - const: core
>
> resets:
> + minItems: 1
> items:
> - description: APB reset
> - description: Core reset

This relaxes the constraints for the existing devices, please add per
compatible constraints to avoid doing so.

Attachments:
(No filename) (1.33 kB)
 signature.asc (235.00 B)
 Download all attachments

2023-12-12 16:48:15

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100

On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote:
> On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote:
> > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100
> > watchdog.
> > Since JH8100 watchdog only has 1 reset signal, update binding
> > document to support one reset for "starfive,jh8100-wdt" compatible.
> >
> > Signed-off-by: Ley Foon Tan <[email protected]>
> > Signed-off-by: Ji Sheng Teoh <[email protected]>
> > ---
> > .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > index 68f3f6fd08a6..02572b16ac08 100644
> > --- a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > @@ -27,6 +27,7 @@ properties:
> > enum:
> > - starfive,jh7100-wdt
> > - starfive,jh7110-wdt
> > + - starfive,jh8100-wdt
> >
> > reg:
> > maxItems: 1
> > @@ -45,6 +46,7 @@ properties:
> > - const: core
> >
> > resets:
> > + minItems: 1
> > items:
> > - description: APB reset
> > - description: Core reset
>
> This relaxes the constraints for the existing devices, please add per
> compatible constraints to avoid doing so.

Also, you do not appear to have implemented the request from Krzysztof
to express compatibility with the jh7110.

Attachments:
(No filename) (1.57 kB)
 signature.asc (235.00 B)
 Download all attachments

2023-12-13 02:58:44

by Ji Sheng Teoh

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100

On Tue, 12 Dec 2023 16:47:59 +0000
Conor Dooley <[email protected]> wrote:

> On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote:
> > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote:
> > > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100
> > > watchdog.
> > > Since JH8100 watchdog only has 1 reset signal, update binding
> > > document to support one reset for "starfive,jh8100-wdt"
> > > compatible.
> > >
> > > Signed-off-by: Ley Foon Tan <[email protected]>
> > > Signed-off-by: Ji Sheng Teoh <[email protected]>
> > > ---
> > > .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > | 2 ++ 1 file changed, 2 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > index 68f3f6fd08a6..02572b16ac08 100644 ---
> > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > +++
> > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > @@ -27,6 +27,7 @@ properties: enum:
> > > - starfive,jh7100-wdt
> > > - starfive,jh7110-wdt
> > > + - starfive,jh8100-wdt
> > >
> > > reg:
> > > maxItems: 1
> > > @@ -45,6 +46,7 @@ properties:
> > > - const: core
> > >
> > > resets:
> > > + minItems: 1
> > > items:
> > > - description: APB reset
> > > - description: Core reset
> >
> > This relaxes the constraints for the existing devices, please add
> > per compatible constraints to avoid doing so.
>
Thanks Conor. Just to clarify, are you suggesting to add what was done
in v1?
v1:
https://lore.kernel.org/all/[email protected]/

> Also, you do not appear to have implemented the request from Krzysztof
> to express compatibility with the jh7110.
>
Ok, fix that up.

2023-12-13 16:36:17

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100

On Wed, Dec 13, 2023 at 10:57:59AM +0800, Ji Sheng Teoh wrote:
> On Tue, 12 Dec 2023 16:47:59 +0000
> Conor Dooley <[email protected]> wrote:
>
> > On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote:
> > > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote:
> > > > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100
> > > > watchdog.
> > > > Since JH8100 watchdog only has 1 reset signal, update binding
> > > > document to support one reset for "starfive,jh8100-wdt"
> > > > compatible.
> > > >
> > > > Signed-off-by: Ley Foon Tan <[email protected]>
> > > > Signed-off-by: Ji Sheng Teoh <[email protected]>
> > > > ---
> > > > .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > | 2 ++ 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > index 68f3f6fd08a6..02572b16ac08 100644 ---
> > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > +++
> > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > @@ -27,6 +27,7 @@ properties: enum:
> > > > - starfive,jh7100-wdt
> > > > - starfive,jh7110-wdt
> > > > + - starfive,jh8100-wdt
> > > >
> > > > reg:
> > > > maxItems: 1
> > > > @@ -45,6 +46,7 @@ properties:
> > > > - const: core
> > > >
> > > > resets:
> > > > + minItems: 1
> > > > items:
> > > > - description: APB reset
> > > > - description: Core reset
> > >
> > > This relaxes the constraints for the existing devices, please add
> > > per compatible constraints to avoid doing so.
> >
> Thanks Conor. Just to clarify, are you suggesting to add what was done
> in v1?
> v1:
> https://lore.kernel.org/all/[email protected]/

No, but similar. Add numerical constraints that vary per SoC without
changing the names of the resets on a per-SoC basis.:wq

Attachments:
(No filename) (2.07 kB)
 signature.asc (235.00 B)
 Download all attachments

2023-12-14 05:18:23

by Ji Sheng Teoh

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100

On Wed, 13 Dec 2023 16:35:39 +0000
Conor Dooley <[email protected]> wrote:

> On Wed, Dec 13, 2023 at 10:57:59AM +0800, Ji Sheng Teoh wrote:
> > On Tue, 12 Dec 2023 16:47:59 +0000
> > Conor Dooley <[email protected]> wrote:
> >
> > > On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote:
> > > > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote:
> > > >
> > > > > Add "starfive,jh8100-wdt" compatible string for StarFive's
> > > > > JH8100 watchdog.
> > > > > Since JH8100 watchdog only has 1 reset signal, update binding
> > > > > document to support one reset for "starfive,jh8100-wdt"
> > > > > compatible.
> > > > >
> > > > > Signed-off-by: Ley Foon Tan <[email protected]>
> > > > > Signed-off-by: Ji Sheng Teoh <[email protected]>
> > > > > ---
> > > > > .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > | 2 ++ 1 file changed, 2 insertions(+)
> > > > >
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > index 68f3f6fd08a6..02572b16ac08 100644 ---
> > > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > +++
> > > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > @@ -27,6 +27,7 @@ properties: enum:
> > > > > - starfive,jh7100-wdt
> > > > > - starfive,jh7110-wdt
> > > > > + - starfive,jh8100-wdt
> > > > >
> > > > > reg:
> > > > > maxItems: 1
> > > > > @@ -45,6 +46,7 @@ properties:
> > > > > - const: core
> > > > >
> > > > > resets:
> > > > > + minItems: 1
> > > > > items:
> > > > > - description: APB reset
> > > > > - description: Core reset
> > > >
> > > > This relaxes the constraints for the existing devices, please
> > > > add per compatible constraints to avoid doing so.
> > >
> > Thanks Conor. Just to clarify, are you suggesting to add what was
> > done in v1?
> > v1:
> > https://lore.kernel.org/all/[email protected]/
> >
>
> No, but similar. Add numerical constraints that vary per SoC without
> changing the names of the resets on a per-SoC basis.:wq
>
Sent out v3, hope it addresses the comments.
v3:
https://lore.kernel.org/all/[email protected]/