Hi all,
After merging the thermal tree, today's linux-next build (x86_64
allmodconfig) failed like this:
ERROR: modpost: "__hw_protection_shutdown" [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!
Caused by commit
726edaad90f6 ("thermal/core: Prepare for introduction of thermal reboot")
I have used the thermal tree from next-20231218 for today.
--
Cheers,
Stephen Rothwell
Hi Stephen,
On 18/12/2023 20:34, Stephen Rothwell wrote:
> Hi all,
>
> After merging the thermal tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: modpost: "__hw_protection_shutdown"
> [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!
>
> Caused by commit
>
> 726edaad90f6 ("thermal/core: Prepare for introduction of thermal
> reboot")
Thanks for reporting.
Daniel,
Could you please squash the following fix to the commit above?
diff --git a/kernel/reboot.c b/kernel/reboot.c
index 07eb6537ed8b..f814568525f1 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -1002,6 +1002,7 @@ void __hw_protection_shutdown(const char *reason,
int ms_until_forced, bool shut
if (shutdown)
orderly_poweroff(true);
}
+EXPORT_SYMBOL_GPL(__hw_protection_shutdown);
static int __init reboot_setup(char *str)
{
x86_64 allmodconfig builds successfully with this change.
Thanks,
Fabio Estevam
On 19/12/2023 03:10, Fabio Estevam wrote:
> Hi Stephen,
>
> On 18/12/2023 20:34, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the thermal tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> ERROR: modpost: "__hw_protection_shutdown"
>> [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!
>>
>> Caused by commit
>>
>> 726edaad90f6 ("thermal/core: Prepare for introduction of thermal
>> reboot")
>
> Thanks for reporting.
>
> Daniel,
>
> Could you please squash the following fix to the commit above?
>
> diff --git a/kernel/reboot.c b/kernel/reboot.c
> index 07eb6537ed8b..f814568525f1 100644
> --- a/kernel/reboot.c
> +++ b/kernel/reboot.c
> @@ -1002,6 +1002,7 @@ void __hw_protection_shutdown(const char *reason,
> int ms_until_forced, bool shut
> if (shutdown)
> orderly_poweroff(true);
> }
> +EXPORT_SYMBOL_GPL(__hw_protection_shutdown);
Yeah, I've done it
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Hi Daniel,
On Tue, 19 Dec 2023 18:59:14 +0100 Daniel Lezcano <[email protected]> wrote:
>
> On 19/12/2023 03:10, Fabio Estevam wrote:
> >
> > On 18/12/2023 20:34, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> After merging the thermal tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >>
> >> ERROR: modpost: "__hw_protection_shutdown"
> >> [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!
> >>
> >> Caused by commit
> >>
> >> 726edaad90f6 ("thermal/core: Prepare for introduction of thermal >> reboot")
> >
> > Thanks for reporting.
> >
> > Daniel,
> >
> > Could you please squash the following fix to the commit above?
> >
> > diff --git a/kernel/reboot.c b/kernel/reboot.c
> > index 07eb6537ed8b..f814568525f1 100644
> > --- a/kernel/reboot.c
> > +++ b/kernel/reboot.c
> > @@ -1002,6 +1002,7 @@ void __hw_protection_shutdown(const char *reason, > int ms_until_forced, bool shut
> > if (shutdown)
> > orderly_poweroff(true);
> > }
> > +EXPORT_SYMBOL_GPL(__hw_protection_shutdown);
>
> Yeah, I've done it
Forgot to push out?
--
Cheers,
Stephen Rothwell
Hi Stephen,
On 20/12/2023 22:17, Stephen Rothwell wrote:
>> > diff --git a/kernel/reboot.c b/kernel/reboot.c
>> > index 07eb6537ed8b..f814568525f1 100644
>> > --- a/kernel/reboot.c
>> > +++ b/kernel/reboot.c
>> > @@ -1002,6 +1002,7 @@ void __hw_protection_shutdown(const char *reason, > int ms_until_forced, bool shut
>> > if (shutdown)
>> > orderly_poweroff(true);
>> > }
>> > +EXPORT_SYMBOL_GPL(__hw_protection_shutdown);
>>
>> Yeah, I've done it
>
> Forgot to push out?
The 'bleeding-edge' branch contains the fix now:
https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=f21b0d185f75e15561047312dd4b8306eac8ad71