2024-01-03 08:47:43

by Chen Ni

Subject: [PATCH] pinctrl: st: Return pinctrl_gpio_direction_output to transfer the error

Return pinctrl_gpio_direction_output() in order to transfer the error
if it fails.

Fixes: b679d6c06b2b ("treewide: rename pinctrl_gpio_direction_output_new()")
Signed-off-by: Chen Ni <[email protected]>
---
drivers/pinctrl/pinctrl-st.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 1485573b523c..5d9abd6547d0 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -723,9 +723,8 @@ static int st_gpio_direction_output(struct gpio_chip *chip,
struct st_gpio_bank *bank = gpiochip_get_data(chip);

__st_gpio_set(bank, offset, value);
- pinctrl_gpio_direction_output(chip, offset);

- return 0;
+ return pinctrl_gpio_direction_output(chip, offset);
}

static int st_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
--
2.25.1

2024-01-03 08:56:43

by Bartosz Golaszewski

Subject: Re: [PATCH] pinctrl: st: Return pinctrl_gpio_direction_output to transfer the error

On Wed, 3 Jan 2024 at 09:47, Chen Ni <[email protected]> wrote:
>
> Return pinctrl_gpio_direction_output() in order to transfer the error
> if it fails.
>
> Fixes: b679d6c06b2b ("treewide: rename pinctrl_gpio_direction_output_new()")

It doesn't technically fix this commit as the return value was never
propagated here in the first place.

Anyway:

Reviewed-by: Bartosz Golaszewski <[email protected]>

Bart

> Signed-off-by: Chen Ni <[email protected]>
> ---
> drivers/pinctrl/pinctrl-st.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 1485573b523c..5d9abd6547d0 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -723,9 +723,8 @@ static int st_gpio_direction_output(struct gpio_chip *chip,
> struct st_gpio_bank *bank = gpiochip_get_data(chip);
>
> __st_gpio_set(bank, offset, value);
> - pinctrl_gpio_direction_output(chip, offset);
>
> - return 0;
> + return pinctrl_gpio_direction_output(chip, offset);
> }
>
> static int st_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
> --
> 2.25.1
>

2024-01-27 22:45:46

by Linus Walleij

Subject: Re: [PATCH] pinctrl: st: Return pinctrl_gpio_direction_output to transfer the error

On Wed, Jan 3, 2024 at 9:47 AM Chen Ni <[email protected]> wrote:

> Return pinctrl_gpio_direction_output() in order to transfer the error
> if it fails.
>
> Fixes: b679d6c06b2b ("treewide: rename pinctrl_gpio_direction_output_new()")
> Signed-off-by: Chen Ni <[email protected]>

Patch applied.

Yours,
Linus Walleij