Hi Jim,
Jim Quinlan <[email protected]> (2023-11-13):
> V8 -- Un-advertise L1SS capability when in "no-l1ss" mode (Bjorn)
> -- Squashed last two commits of v7 (Bjorn)
> -- Fix DT binding description text wrapping (Bjorn)
> -- Fix incorrect Spec reference (Bjorn)
> s/PCIe Spec/PCIe Express Mini CEM 2.1 specification/
> -- Text substitutions (Bjorn)
> s/WRT/With respect to/
> s/Tclron/T_CLRon/
>
> v7 -- Manivannan Sadhasivam suggested (a) making the property look like a
> network phy-mode and (b) keeping the code simple (not counting clkreq
> signal appearances, un-advertising capabilites, etc). This is
> what I have done. The property is now "brcm,clkreq-mode" and
> the values may be one of "safe", "default", and "no-l1ss". The
> default setting is to employ the most capable power savings mode.
Still:
Tested-by: Cyril Brulebois <[email protected]>
I've just run my big test matrix again, and I can confirm everything is
still looking good with the updated series and the updated base commit.
Test setup:
-----------
- using a $CM with the 20230111 EEPROM
- on the same CM4 IO Board
- with a $PCIE board (PCIe to multiple USB ports)
- and the same Samsung USB flash drive + Logitech keyboard.
where $CM is one of:
- CM4 Lite Rev 1.0
- CM4 8/32 Rev 1.0
- CM4 4/32 Rev 1.1
and $PCIE is one of:
- SupaHub PCE6U1C-R02, VER 006
- SupaHub PCE6U1C-R02, VER 006S
- Waveshare VIA VL805/806-based
Results:
--------
1. With an unpatched kernel, I'm getting either a successful boot
*without* seeing the devices plugged on the PCIe-to-USB board
or the dreaded SError in most cases, using a locally-built
v6.4-rc7-194-g8a28a0b6f1a1d kernel.
2. With a patched kernel (v6.6-15365-g305230142ae0 + this series),
for all $CM/$PCIE combinations, I'm getting a system that boots,
sees the flash drive, and gives decent read/write performance on
it (plus a functional keyboard).
Cheers,
--
Cyril Brulebois ([email protected]) <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant
On 11/26/23 12:19, Cyril Brulebois wrote:
> Hi Jim,
>
> Jim Quinlan <[email protected]> (2023-11-13):
>> V8 -- Un-advertise L1SS capability when in "no-l1ss" mode (Bjorn)
>> -- Squashed last two commits of v7 (Bjorn)
>> -- Fix DT binding description text wrapping (Bjorn)
>> -- Fix incorrect Spec reference (Bjorn)
>> s/PCIe Spec/PCIe Express Mini CEM 2.1 specification/
>> -- Text substitutions (Bjorn)
>> s/WRT/With respect to/
>> s/Tclron/T_CLRon/
>>
>> v7 -- Manivannan Sadhasivam suggested (a) making the property look like a
>> network phy-mode and (b) keeping the code simple (not counting clkreq
>> signal appearances, un-advertising capabilites, etc). This is
>> what I have done. The property is now "brcm,clkreq-mode" and
>> the values may be one of "safe", "default", and "no-l1ss". The
>> default setting is to employ the most capable power savings mode.
>
> Still:
>
> Tested-by: Cyril Brulebois <[email protected]>
Thanks Cyril! Bjorn, Lorenzo, any chance this can be applied soon? Thanks!
--
Florian
On Tue, Dec 12, 2023 at 03:51:12PM -0800, Florian Fainelli wrote:
> On 11/26/23 12:19, Cyril Brulebois wrote:
> > Hi Jim,
> >
> > Jim Quinlan <[email protected]> (2023-11-13):
> > > V8 -- Un-advertise L1SS capability when in "no-l1ss" mode (Bjorn)
> > > -- Squashed last two commits of v7 (Bjorn)
> > > -- Fix DT binding description text wrapping (Bjorn)
> > > -- Fix incorrect Spec reference (Bjorn)
> > > s/PCIe Spec/PCIe Express Mini CEM 2.1 specification/
> > > -- Text substitutions (Bjorn)
> > > s/WRT/With respect to/
> > > s/Tclron/T_CLRon/
> > >
> > > v7 -- Manivannan Sadhasivam suggested (a) making the property look like a
> > > network phy-mode and (b) keeping the code simple (not counting clkreq
> > > signal appearances, un-advertising capabilites, etc). This is
> > > what I have done. The property is now "brcm,clkreq-mode" and
> > > the values may be one of "safe", "default", and "no-l1ss". The
> > > default setting is to employ the most capable power savings mode.
> >
> > Still:
> >
> > Tested-by: Cyril Brulebois <[email protected]>
>
> Thanks Cyril! Bjorn, Lorenzo, any chance this can be applied soon? Thanks!
Seems OK to me if Lorenzo or Krzysztof W. are OK with it.
On Wed, Dec 13, 2023 at 2:59 PM Bjorn Helgaas <[email protected]> wrote:
>
> On Tue, Dec 12, 2023 at 03:51:12PM -0800, Florian Fainelli wrote:
> > On 11/26/23 12:19, Cyril Brulebois wrote:
> > > Hi Jim,
> > >
> > > Jim Quinlan <[email protected]> (2023-11-13):
> > > > V8 -- Un-advertise L1SS capability when in "no-l1ss" mode (Bjorn)
> > > > -- Squashed last two commits of v7 (Bjorn)
> > > > -- Fix DT binding description text wrapping (Bjorn)
> > > > -- Fix incorrect Spec reference (Bjorn)
> > > > s/PCIe Spec/PCIe Express Mini CEM 2.1 specification/
> > > > -- Text substitutions (Bjorn)
> > > > s/WRT/With respect to/
> > > > s/Tclron/T_CLRon/
> > > >
> > > > v7 -- Manivannan Sadhasivam suggested (a) making the property look like a
> > > > network phy-mode and (b) keeping the code simple (not counting clkreq
> > > > signal appearances, un-advertising capabilites, etc). This is
> > > > what I have done. The property is now "brcm,clkreq-mode" and
> > > > the values may be one of "safe", "default", and "no-l1ss". The
> > > > default setting is to employ the most capable power savings mode.
> > >
> > > Still:
> > >
> > > Tested-by: Cyril Brulebois <[email protected]>
> >
> > Thanks Cyril! Bjorn, Lorenzo, any chance this can be applied soon? Thanks!
>
> Seems OK to me if Lorenzo or Krzysztof W. are OK with it.
>
Bjorn,
What is the status of this submission? Stock Linux on RPi4 CM4
systems with a PCIe device panic on boot until this commit is
applied.
Regards,
Jim Quinilan
Broadcom STB/CM
Hello,
[...]
> What is the status of this submission?
Looks good! I apologise for the delay.
Bjorn is keen to pick this up for 6.8 with other changes, so it should land
there shortly, given that we have a merge window open now.
Krzysztof