2024-01-25 11:22:11

by Hariprasad Kelam

Subject: [net-next PATCH] octeontx2-pf: Add support to read eeprom information

Add support to read/decode EEPROM module information using ethtool.

Usage: ethtool -m <interface>

Signed-off-by: Christina Jacob <[email protected]>
Signed-off-by: Hariprasad Kelam <[email protected]>
Signed-off-by: Sunil Goutham <[email protected]>
---
.../marvell/octeontx2/nic/otx2_ethtool.c | 33 +++++++++++++++++++
1 file changed, 33 insertions(+)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
index 2928898c7f8d..8e4e22a2817b 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
@@ -1185,6 +1185,37 @@ static void otx2_get_link_mode_info(u64 link_mode_bmap,
otx2_link_modes);
}

+static int otx2_get_module_info(struct net_device *netdev,
+ struct ethtool_modinfo *modinfo)
+{
+ struct otx2_nic *pfvf = netdev_priv(netdev);
+ struct cgx_fw_data *rsp;
+
+ rsp = otx2_get_fwdata(pfvf);
+ if (IS_ERR(rsp))
+ return PTR_ERR(rsp);
+
+ modinfo->type = rsp->fwdata.sfp_eeprom.sff_id;
+ modinfo->eeprom_len = SFP_EEPROM_SIZE;
+ return 0;
+}
+
+static int otx2_get_module_eeprom(struct net_device *netdev,
+ struct ethtool_eeprom *ee,
+ u8 *data)
+{
+ struct otx2_nic *pfvf = netdev_priv(netdev);
+ struct cgx_fw_data *rsp;
+
+ rsp = otx2_get_fwdata(pfvf);
+ if (IS_ERR(rsp))
+ return PTR_ERR(rsp);
+
+ memcpy(data, &rsp->fwdata.sfp_eeprom.buf, ee->len);
+
+ return 0;
+}
+
static int otx2_get_link_ksettings(struct net_device *netdev,
struct ethtool_link_ksettings *cmd)
{
@@ -1343,6 +1374,8 @@ static const struct ethtool_ops otx2_ethtool_ops = {
.set_fecparam = otx2_set_fecparam,
.get_link_ksettings = otx2_get_link_ksettings,
.set_link_ksettings = otx2_set_link_ksettings,
+ .get_module_info = otx2_get_module_info,
+ .get_module_eeprom = otx2_get_module_eeprom,
};

void otx2_set_ethtool_ops(struct net_device *netdev)
--
2.17.1

2024-01-26 11:43:30

by Andrew Lunn

Subject: Re: [net-next PATCH] octeontx2-pf: Add support to read eeprom information

On Thu, Jan 25, 2024 at 04:51:33PM +0530, Hariprasad Kelam wrote:
> Add support to read/decode EEPROM module information using ethtool.

It looks like you have a very primitive firmware here, which can only
return the first page of the SFPs EEPROM. What are your plans to make
this fully featured? Ideally you should not be using this API, but the
newer API which indicates what page you would like to read.

> Signed-off-by: Christina Jacob <[email protected]>
> Signed-off-by: Hariprasad Kelam <[email protected]>
> Signed-off-by: Sunil Goutham <[email protected]>

These seem to be in the wrong order.

Andrew

2024-01-31 11:41:59

by Hariprasad Kelam

Subject: Re: [net-next PATCH] octeontx2-pf: Add support to read eeprom information

> On Thu, Jan 25, 2024 at 04:51:33PM +0530, Hariprasad Kelam wrote:
> > Add support to read/decode EEPROM module information using ethtool.
>
> It looks like you have a very primitive firmware here, which can only return the
> first page of the SFPs EEPROM. What are your plans to make this fully
> featured? Ideally you should not be using this API, but the newer API which
> indicates what page you would like to read.
>
Our firmware currently supports reading only first page.
Will submit V2 which uses new API considering the len/offset fields.

> > Signed-off-by: Christina Jacob <[email protected]>
> > Signed-off-by: Hariprasad Kelam <[email protected]>
> > Signed-off-by: Sunil Goutham <[email protected]>
>
> These seem to be in the wrong order.
>
I will fix in next version.
Thanks,
Hariprasad k
> Andrew