Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
a const *"), the driver core can properly handle constant struct
bus_type. Move the siox_bus_type variable to be a constant structure as
well, placing it into read-only memory which can not be modified at
runtime.
Cc: Greg Kroah-Hartman <[email protected]>
Suggested-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
---
Changes in v2:
- Fixed changelog: mentioned commit d492cc2573a0 instead of the word
"Now".
- Link to v1: https://lore.kernel.org/r/[email protected]
---
drivers/siox/siox-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
index 561408583b2b..a1eda7bd76ed 100644
--- a/drivers/siox/siox-core.c
+++ b/drivers/siox/siox-core.c
@@ -543,7 +543,7 @@ static void siox_shutdown(struct device *dev)
sdriver->shutdown(sdevice);
}
-static struct bus_type siox_bus_type = {
+static const struct bus_type siox_bus_type = {
.name = "siox",
.match = siox_match,
.probe = siox_probe,
---
base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7
change-id: 20240204-bus_cleanup-siox-ccf8775bf069
Best regards,
--
Ricardo B. Marliere <[email protected]>
Hello Ricardo,
On Sun, Feb 04, 2024 at 07:26:42PM -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> a const *"), the driver core can properly handle constant struct
> bus_type. Move the siox_bus_type variable to be a constant structure as
> well, placing it into read-only memory which can not be modified at
> runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>
I currently have no setup to test this, but compilation is fine, and I
don't expect any surprises.
Acked-by: Uwe Kleine-König <[email protected]>
Thanks for your patch,
Uwe
PS: b4 gave me:
✗ [PATCH v2] siox: make siox_bus_type const
✗ No key: openpgp/[email protected]
✗ BADSIG: DKIM/marliere.net
when applying your patch. I didn't check the details of the DKIM issue. I
quickly tried to find your pgp key, but failed (wks, kernel-pgpkeys
repo, keyserver).
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
On 5 Feb 10:03, Uwe Kleine-König wrote:
> Hello Ricardo,
>
> On Sun, Feb 04, 2024 at 07:26:42PM -0300, Ricardo B. Marliere wrote:
> > Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> > a const *"), the driver core can properly handle constant struct
> > bus_type. Move the siox_bus_type variable to be a constant structure as
> > well, placing it into read-only memory which can not be modified at
> > runtime.
> >
> > Cc: Greg Kroah-Hartman <[email protected]>
> > Suggested-by: Greg Kroah-Hartman <[email protected]>
> > Signed-off-by: Ricardo B. Marliere <[email protected]>
>
> I currently have no setup to test this, but compilation is fine, and I
> don't expect any surprises.
>
> Acked-by: Uwe Kleine-König <[email protected]>
>
> Thanks for your patch,
> Uwe
>
> PS: b4 gave me:
>
> ✗ [PATCH v2] siox: make siox_bus_type const
> ✗ No key: openpgp/[email protected]
> ✗ BADSIG: DKIM/marliere.net
>
> when applying your patch. I didn't check the details of the DKIM issue. I
> quickly tried to find your pgp key, but failed (wks, kernel-pgpkeys
> repo, keyserver).
Thanks for the heads up, I'll go check what's wrong. I think I only
published the @gmail.com one.!
Best regards,
- Ricardo.
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | https://www.pengutronix.de/ |
On Sun, Feb 04, 2024 at 07:26:42PM -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> a const *"), the driver core can properly handle constant struct
> bus_type. Move the siox_bus_type variable to be a constant structure as
> well, placing it into read-only memory which can not be modified at
> runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>
Reviewed-by: Greg Kroah-Hartman <[email protected]>
Hello,
On Sun, Feb 04, 2024 at 07:26:42PM -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> a const *"), the driver core can properly handle constant struct
> bus_type. Move the siox_bus_type variable to be a constant structure as
> well, placing it into read-only memory which can not be modified at
> runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>
Acked-by: Thorsten Scherer <[email protected]>
@Ricardo: Thank you!
@gregkh: Would you please pick up this patch?
> ---
> Changes in v2:
> - Fixed changelog: mentioned commit d492cc2573a0 instead of the word
> "Now".
> - Link to v1: https://lore.kernel.org/r/[email protected]
> ---
> drivers/siox/siox-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
> index 561408583b2b..a1eda7bd76ed 100644
> --- a/drivers/siox/siox-core.c
> +++ b/drivers/siox/siox-core.c
> @@ -543,7 +543,7 @@ static void siox_shutdown(struct device *dev)
> sdriver->shutdown(sdevice);
> }
>
> -static struct bus_type siox_bus_type = {
> +static const struct bus_type siox_bus_type = {
> .name = "siox",
> .match = siox_match,
> .probe = siox_probe,
>
> ---
> base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7
> change-id: 20240204-bus_cleanup-siox-ccf8775bf069
>
> Best regards,
> --
> Ricardo B. Marliere <[email protected]>
>
Best regards
Thorsten