This series aims to keep the git status clean after building the
selftests by adding some missing .gitignore files and object inclusion
in existing .gitignore files. This is one of the requirements listed in
the selftests documentation for new tests, but it is not always followed
as desired.
After adding these .gitignore files and including the generated objects,
the working tree appears clean again.
The new version includes a missing entry fot the .gitignore in damon,
which was reported by Bernd Edlinger <[email protected]>, who
also proposed a patch for it as well as for other missing .gitignore
files covered by v1. Bernd has been added to the corresponding patch as
the reporter. If a different tag is desired, I am fine with it.
To: Shuah Khan <[email protected]>
To: SeongJae Park <[email protected]>
To: Bernd Edlinger <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Javier Carrasco <[email protected]>
Changes in v2:
- Remove patch for netfilter (not relevant anymore).
- Add patch for damon (missing binary in .gitignore).
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Javier Carrasco (4):
selftests: uevent: add missing gitignore
selftests: thermal: intel: power_floor: add missing gitignore
selftests: thermal: intel: workload_hint: add missing gitignore
selftests: damon: add access_memory to .gitignore
tools/testing/selftests/damon/.gitignore | 1 +
tools/testing/selftests/thermal/intel/power_floor/.gitignore | 1 +
tools/testing/selftests/thermal/intel/workload_hint/.gitignore | 1 +
tools/testing/selftests/uevent/.gitignore | 1 +
4 files changed, 4 insertions(+)
---
base-commit: 716f4aaa7b48a55c73d632d0657b35342b1fefd7
change-id: 20240101-selftest_gitignore-7da2c503766e
Best regards,
--
Javier Carrasco <[email protected]>
The 'power_floor' test generates an object with the same name,
but there is no .gitignore file in the directory to add the object as
stated in the selftest documentation.
Add the missing .gitignore file and include 'power_floor'.
Signed-off-by: Javier Carrasco <[email protected]>
---
tools/testing/selftests/thermal/intel/power_floor/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/thermal/intel/power_floor/.gitignore b/tools/testing/selftests/thermal/intel/power_floor/.gitignore
new file mode 100644
index 000000000000..1b9a76406f18
--- /dev/null
+++ b/tools/testing/selftests/thermal/intel/power_floor/.gitignore
@@ -0,0 +1 @@
+power_floor_test
--
2.40.1
The 'workload_hint_test' test generates an object with the same name,
but there is no .gitignore file in the directory to add the object as
stated in the selftest documentation.
Add the missing .gitignore file and include 'workload_hint_test'.
Signed-off-by: Javier Carrasco <[email protected]>
---
tools/testing/selftests/thermal/intel/workload_hint/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/thermal/intel/workload_hint/.gitignore b/tools/testing/selftests/thermal/intel/workload_hint/.gitignore
new file mode 100644
index 000000000000..d697b034a3a8
--- /dev/null
+++ b/tools/testing/selftests/thermal/intel/workload_hint/.gitignore
@@ -0,0 +1 @@
+workload_hint_test
--
2.40.1
This binary is missing in the .gitignore and stays as an untracked file.
Reported-by: Bernd Edlinger <[email protected]>
Signed-off-by: Javier Carrasco <[email protected]>
---
tools/testing/selftests/damon/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/damon/.gitignore b/tools/testing/selftests/damon/.gitignore
index c6c2965a6607..79b32e30fce3 100644
--- a/tools/testing/selftests/damon/.gitignore
+++ b/tools/testing/selftests/damon/.gitignore
@@ -1,2 +1,3 @@
# SPDX-License-Identifier: GPL-2.0-only
huge_count_read_write
+access_memory
--
2.40.1
The 'uevent_filtering' test generates an object with the same name,
but there is no .gitignore file in the directory to add the object
as stated in the selftest documentation.
Add the missing .gitignore file and include 'uevent_filtering'.
Signed-off-by: Javier Carrasco <[email protected]>
---
tools/testing/selftests/uevent/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/uevent/.gitignore b/tools/testing/selftests/uevent/.gitignore
new file mode 100644
index 000000000000..382afb74cd40
--- /dev/null
+++ b/tools/testing/selftests/uevent/.gitignore
@@ -0,0 +1 @@
+uevent_filtering
--
2.40.1
Hello,
On Mon, 12 Feb 2024 20:43:39 +0100 Javier Carrasco <[email protected]> wrote:
> This binary is missing in the .gitignore and stays as an untracked file.
>
> Reported-by: Bernd Edlinger <[email protected]>
> Signed-off-by: Javier Carrasco <[email protected]>
'checkpatch.pl' complains as below:
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#11:
Reported-by: Bernd Edlinger <[email protected]>
Signed-off-by: Javier Carrasco <[email protected]>
I guess the 'Closes:' could this link?
https://lore.kernel.org/r/AS8P193MB1285C963658008F1B2702AF7E4792@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM
Also, note that this conflicts on mm-unstable.
Other than those,
Reviewed-by: SeongJae Park <[email protected]>
Thanks,
SJ
> ---
> tools/testing/selftests/damon/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/damon/.gitignore b/tools/testing/selftests/damon/.gitignore
> index c6c2965a6607..79b32e30fce3 100644
> --- a/tools/testing/selftests/damon/.gitignore
> +++ b/tools/testing/selftests/damon/.gitignore
> @@ -1,2 +1,3 @@
> # SPDX-License-Identifier: GPL-2.0-only
> huge_count_read_write
> +access_memory
>
> --
> 2.40.1
On 12.02.24 20:53, SeongJae Park wrote:
> Hello,
>
> On Mon, 12 Feb 2024 20:43:39 +0100 Javier Carrasco <[email protected]> wrote:
>
>> This binary is missing in the .gitignore and stays as an untracked file.
>>
>> Reported-by: Bernd Edlinger <[email protected]>
>> Signed-off-by: Javier Carrasco <[email protected]>
>
> 'checkpatch.pl' complains as below:
>
> WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
> #11:
> Reported-by: Bernd Edlinger <[email protected]>
> Signed-off-by: Javier Carrasco <[email protected]>
>
> I guess the 'Closes:' could this link?
> https://lore.kernel.org/r/AS8P193MB1285C963658008F1B2702AF7E4792@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM
>
I will add the Closes tag with the right link, thank you.
> Also, note that this conflicts on mm-unstable.
Should I use mm-unstable as basis to make sure no conflicts are introduced?
>
> Other than those,
>
> Reviewed-by: SeongJae Park <[email protected]>
>
>
> Thanks,
> SJ
>
>
>> ---
>> tools/testing/selftests/damon/.gitignore | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/damon/.gitignore b/tools/testing/selftests/damon/.gitignore
>> index c6c2965a6607..79b32e30fce3 100644
>> --- a/tools/testing/selftests/damon/.gitignore
>> +++ b/tools/testing/selftests/damon/.gitignore
>> @@ -1,2 +1,3 @@
>> # SPDX-License-Identifier: GPL-2.0-only
>> huge_count_read_write
>> +access_memory
>>
>> --
>> 2.40.1
Best regards,
Javier Carrasco
On Mon, 12 Feb 2024 21:07:34 +0100 Javier Carrasco <[email protected]> wrote:
>
>
> On 12.02.24 20:53, SeongJae Park wrote:
> > Hello,
> >
> > On Mon, 12 Feb 2024 20:43:39 +0100 Javier Carrasco <[email protected]> wrote:
> >
> >> This binary is missing in the .gitignore and stays as an untracked file.
> >>
> >> Reported-by: Bernd Edlinger <[email protected]>
> >> Signed-off-by: Javier Carrasco <[email protected]>
> >
> > 'checkpatch.pl' complains as below:
> >
> > WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
> > #11:
> > Reported-by: Bernd Edlinger <[email protected]>
> > Signed-off-by: Javier Carrasco <[email protected]>
> >
> > I guess the 'Closes:' could this link?
> > https://lore.kernel.org/r/AS8P193MB1285C963658008F1B2702AF7E4792@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM
> >
>
> I will add the Closes tag with the right link, thank you.
Thank you :)
>
> > Also, note that this conflicts on mm-unstable.
>
> Should I use mm-unstable as basis to make sure no conflicts are introduced?
DAMON selftest patches could be merged in mm-unstable or linux-kselftest
depending on cases.
If you rebase this on mm-unstable, it might conflict on linux-kselftest.
Letting Shuah merge this on linux-kselftest and asking Linus Torvalds to fix
the conflict in next merge window could be one possible option.
Or, making this split out of this series, rebase on mm-unstable, and asking
Andrew Morton to carry may be another option.
Andrew and Shuah, may I ask your opinions?
Thanks,
SJ
[...]
On Mon, 12 Feb 2024 12:23:56 -0800 SeongJae Park <[email protected]> wrote:
> >
> > > Also, note that this conflicts on mm-unstable.
> >
> > Should I use mm-unstable as basis to make sure no conflicts are introduced?
>
> DAMON selftest patches could be merged in mm-unstable or linux-kselftest
> depending on cases.
>
> If you rebase this on mm-unstable, it might conflict on linux-kselftest.
> Letting Shuah merge this on linux-kselftest and asking Linus Torvalds to fix
> the conflict in next merge window could be one possible option.
>
> Or, making this split out of this series, rebase on mm-unstable, and asking
> Andrew Morton to carry may be another option.
>
> Andrew and Shuah, may I ask your opinions?
I'd say base it on mm-unstable so we don't have conflicts for people to
deal with?