2024-02-23 10:35:52

by Lee Jones

[permalink] [raw]
Subject: Re: (subset) [PATCH v2 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend

On Fri, 23 Feb 2024, Lee Jones wrote:

> On Tue, 06 Feb 2024 13:13:17 -0500, Aren Moynihan wrote:
> > If none of the managed leds enable LED_CORE_SUSPENDRESUME, then we
> > shouldn't need to set it here. This makes it possible to use multicolor
> > groups with gpio leds that enable retain-state-suspended in the device
> > tree.
> >
> >
>
> Applied, thanks!
>
> [1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend
> commit: 68552911e71d59e62dd5e50e9ac56ebfc32f0c71

Note that I changed a bunch of grammatical issues.

led => LED
gpio => GPIO

Capitalised the first word of the comment, etc.

--
Lee Jones [李琼斯]


2024-02-23 15:32:48

by Aren

[permalink] [raw]
Subject: Re: (subset) [PATCH v2 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend

On Fri, Feb 23, 2024 at 10:35:37AM +0000, Lee Jones wrote:
> On Fri, 23 Feb 2024, Lee Jones wrote:
>
> > On Tue, 06 Feb 2024 13:13:17 -0500, Aren Moynihan wrote:
> > > If none of the managed leds enable LED_CORE_SUSPENDRESUME, then we
> > > shouldn't need to set it here. This makes it possible to use multicolor
> > > groups with gpio leds that enable retain-state-suspended in the device
> > > tree.
> > >
> > >
> >
> > Applied, thanks!
> >
> > [1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend
> > commit: 68552911e71d59e62dd5e50e9ac56ebfc32f0c71
>
> Note that I changed a bunch of grammatical issues.
>
> led => LED
> gpio => GPIO
>
> Capitalised the first word of the comment, etc.

Awesome, thank you
- Aren

> --
> Lee Jones [李琼斯]