LinuxLists.cc - [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt

2024-02-26 13:01:00

Subject: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt

From: Peng Fan <[email protected]>

Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
so drop it.

Signed-off-by: Peng Fan <[email protected]>
---
Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
index dacc526dc695..dfc3f512918f 100644
--- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
@@ -31,7 +31,6 @@ properties:
- description: normal conversion, include EOC (End of Conversion),
ECH (End of Chain), JEOC (End of Injected Conversion) and
JECH (End of injected Chain).
- - description: Self-testing Interrupts.

clocks:
maxItems: 1
@@ -70,8 +69,7 @@ examples:
reg = <0x44530000 0x10000>;
interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
+ <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX93_CLK_ADC1_GATE>;
clock-names = "ipg";
vref-supply = <&reg_vref_1v8>;
--
2.37.1

2024-02-26 13:03:30

by Peng Fan (OSS)

[permalink] [raw]

Subject: [PATCH 2/2] arm64: dts: imx93: drop the 4th interrupt for ADC

From: Peng Fan <[email protected]>

Per i.MX93 Reference Mannual Rev.4, 12/2023, there is no interrupt 268,
drop it.

Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx93.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 601c94e1fac8..b8ef9b938856 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -509,8 +509,7 @@ adc1: adc@44530000 {
reg = <0x44530000 0x10000>;
interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
+ <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX93_CLK_ADC1_GATE>;
clock-names = "ipg";
#io-channel-cells = <1>;
--
2.37.1

2024-02-26 16:33:01

by Conor Dooley

[permalink] [raw]

Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt

On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> so drop it.

Don't just remove it from the example, drop it from the binding too?
It does permit a 4th "self testing" interrupt.

Thanks,
Conor.

>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> index dacc526dc695..dfc3f512918f 100644
> --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> @@ -31,7 +31,6 @@ properties:
> - description: normal conversion, include EOC (End of Conversion),
> ECH (End of Chain), JEOC (End of Injected Conversion) and
> JECH (End of injected Chain).
> - - description: Self-testing Interrupts.
>
> clocks:
> maxItems: 1
> @@ -70,8 +69,7 @@ examples:
> reg = <0x44530000 0x10000>;
> interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> + <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clk IMX93_CLK_ADC1_GATE>;
> clock-names = "ipg";
> vref-supply = <&reg_vref_1v8>;
> --
> 2.37.1
>

Attachments:

(No filename) (1.67 kB)
signature.asc (235.00 B)
Download all attachments

2024-02-26 19:21:33

by Jonathan Cameron

[permalink] [raw]

Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt

On Mon, 26 Feb 2024 16:24:47 +0000
Conor Dooley <[email protected]> wrote:

> On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <[email protected]>
> >
> > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> > so drop it.
>
> Don't just remove it from the example, drop it from the binding too?
> It does permit a 4th "self testing" interrupt.

I'm missing something. See below...
>
> Thanks,
> Conor.
>
> >
> > Signed-off-by: Peng Fan <[email protected]>
> > ---
> > Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > index dacc526dc695..dfc3f512918f 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > @@ -31,7 +31,6 @@ properties:
> > - description: normal conversion, include EOC (End of Conversion),
> > ECH (End of Chain), JEOC (End of Injected Conversion) and
> > JECH (End of injected Chain).
> > - - description: Self-testing Interrupts.

Eyes skipped over this maybe? The 4th interrupt is removed from binding here...

> >
> > clocks:
> > maxItems: 1
> > @@ -70,8 +69,7 @@ examples:
> > reg = <0x44530000 0x10000>;
> > interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
> > - <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
> > - <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> > + <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&clk IMX93_CLK_ADC1_GATE>;
> > clock-names = "ipg";
> > vref-supply = <&reg_vref_1v8>;
> > --
> > 2.37.1
> >

2024-02-26 21:17:27

by Conor Dooley

[permalink] [raw]

Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt

On Mon, Feb 26, 2024 at 07:20:55PM +0000, Jonathan Cameron wrote:
> On Mon, 26 Feb 2024 16:24:47 +0000
> Conor Dooley <[email protected]> wrote:
>
> > On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <[email protected]>
> > >
> > > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> > > so drop it.
> >
> > Don't just remove it from the example, drop it from the binding too?
> > It does permit a 4th "self testing" interrupt.
>
> I'm missing something. See below...
> >
> > Thanks,
> > Conor.
> >
> > >
> > > Signed-off-by: Peng Fan <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > index dacc526dc695..dfc3f512918f 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > @@ -31,7 +31,6 @@ properties:
> > > - description: normal conversion, include EOC (End of Conversion),
> > > ECH (End of Chain), JEOC (End of Injected Conversion) and
> > > JECH (End of injected Chain).
> > > - - description: Self-testing Interrupts.
>
> Eyes skipped over this maybe? The 4th interrupt is removed from binding here...

Huh, wonder how I missed that. I thought I double checked...
Acked-by: Conor Dooley <[email protected]>

Cheers,
Conor.

Attachments:

(No filename) (1.61 kB)
signature.asc (235.00 B)
Download all attachments

2024-02-26 22:07:02

by Jonathan Cameron

[permalink] [raw]

Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt

On Mon, 26 Feb 2024 21:17:06 +0000
Conor Dooley <[email protected]> wrote:

> On Mon, Feb 26, 2024 at 07:20:55PM +0000, Jonathan Cameron wrote:
> > On Mon, 26 Feb 2024 16:24:47 +0000
> > Conor Dooley <[email protected]> wrote:
> >
> > > On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> > > > From: Peng Fan <[email protected]>
> > > >
> > > > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> > > > so drop it.
> > >
> > > Don't just remove it from the example, drop it from the binding too?
> > > It does permit a 4th "self testing" interrupt.
> >
> > I'm missing something. See below...
> > >
> > > Thanks,
> > > Conor.
> > >
> > > >
> > > > Signed-off-by: Peng Fan <[email protected]>
> > > > ---
> > > > Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> > > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > index dacc526dc695..dfc3f512918f 100644
> > > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > @@ -31,7 +31,6 @@ properties:
> > > > - description: normal conversion, include EOC (End of Conversion),
> > > > ECH (End of Chain), JEOC (End of Injected Conversion) and
> > > > JECH (End of injected Chain).
> > > > - - description: Self-testing Interrupts.
> >
> > Eyes skipped over this maybe? The 4th interrupt is removed from binding here...
>
> Huh, wonder how I missed that. I thought I double checked...
> Acked-by: Conor Dooley <[email protected]>
>
> Cheers,
> Conor.

Happens to us all! Applied patch 1 to the togreg branch of iio.git and pushed
it out as testing so 0-day can poke at it.
Thanks,

Jonathan

2024-03-15 01:01:21

by Peng Fan

[permalink] [raw]

Subject: RE: [PATCH 2/2] arm64: dts: imx93: drop the 4th interrupt for ADC

Hi Shawn,

> Subject: [PATCH 2/2] arm64: dts: imx93: drop the 4th interrupt for ADC

The Patch 1/2 has been accepted. Would you please check this dts part?

Thanks,
Peng.

>
> From: Peng Fan <[email protected]>
>
> Per i.MX93 Reference Mannual Rev.4, 12/2023, there is no interrupt 268,
> drop it.
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx93.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 601c94e1fac8..b8ef9b938856 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -509,8 +509,7 @@ adc1: adc@44530000 {
> reg = <0x44530000 0x10000>;
> interrupts = <GIC_SPI 217
> IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 218
> IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 219
> IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 268
> IRQ_TYPE_LEVEL_HIGH>;
> + <GIC_SPI 219
> IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clk IMX93_CLK_ADC1_GATE>;
> clock-names = "ipg";
> #io-channel-cells = <1>;
> --
> 2.37.1

2024-03-28 12:50:04

by Shawn Guo

[permalink] [raw]

Subject: Re: [PATCH 2/2] arm64: dts: imx93: drop the 4th interrupt for ADC

On Mon, Feb 26, 2024 at 09:08:26PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Per i.MX93 Reference Mannual Rev.4, 12/2023, there is no interrupt 268,
> drop it.
>
> Signed-off-by: Peng Fan <[email protected]>

Applied, thanks!