2024-02-29 13:59:17

by Mark Brown

[permalink] [raw]

Subject: Re: [PATCH v2 12/14] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators

---

On Fri, Feb 23, 2024 at 03:06:59PM +0530, Bhargav Raviprakash wrote:

> +static struct tps6594_regulator_irq_type tps65224_ext_regulator_irq_types[] = {
> + { TPS65224_IRQ_NAME_VCCA_UVOV, "VCCA", "voltage out of range",
> + REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> + { TPS65224_IRQ_NAME_VMON1_UVOV, "VMON1", "voltage out of range",
> + REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> + { TPS65224_IRQ_NAME_VMON2_UVOV, "VMON2", "voltage out of range",
> + REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> +};

These should be REGULATOR_EVENT_REGULATION_OUT I think - they look like
they could be warning on either under or over voltage.

---

Attachments:

(No filename) (634.00 B)
signature.asc (499.00 B)
Download all attachments

2024-03-07 09:16:19

by Bhargav Raviprakash

[permalink] [raw]

Subject: Re: [PATCH v2 12/14] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators

---

Hi,
On Thu, 29 Feb 2024 13:58:54 +0000, Mark Brown wrote:
> On Fri, Feb 23, 2024 at 03:06:59PM +0530, Bhargav Raviprakash wrote:
>
> > +static struct tps6594_regulator_irq_type tps65224_ext_regulator_irq_types[] = {
> > + { TPS65224_IRQ_NAME_VCCA_UVOV, "VCCA", "voltage out of range",
> > + REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> > + { TPS65224_IRQ_NAME_VMON1_UVOV, "VMON1", "voltage out of range",
> > + REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> > + { TPS65224_IRQ_NAME_VMON2_UVOV, "VMON2", "voltage out of range",
> > + REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> > +};
>
> These should be REGULATOR_EVENT_REGULATION_OUT I think - they look like
> they could be warning on either under or over voltage.

Thanks for the feedback.
In the next version we will use REGULATOR_EVENT_REGULATION_OUT.

Regards,
Bhargav