Add StarFive JH8100 DMA support.
Tan Chun Hau (2):
dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support
dmaengine: dw-axi-dmac: Add support for StarFive JH8100 DMA
Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 +
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 3 +++
2 files changed, 4 insertions(+)
--
2.25.1
Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
controller.
Signed-off-by: Tan Chun Hau <[email protected]>
---
Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
index 363cf8bd150d..525f5f3932f5 100644
--- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
+++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
@@ -21,6 +21,7 @@ properties:
- snps,axi-dma-1.01a
- intel,kmb-axi-dma
- starfive,jh7110-axi-dma
+ - starfive,jh8100-axi-dma
reg:
minItems: 1
--
2.25.1
JH8100 requires reset operation only in device probe.
Signed-off-by: Tan Chun Hau <[email protected]>
---
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index a86a81ff0caa..abb3523ba8ab 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -1653,6 +1653,9 @@ static const struct of_device_id dw_dma_of_id_table[] = {
}, {
.compatible = "starfive,jh7110-axi-dma",
.data = (void *)(AXI_DMA_FLAG_HAS_RESETS | AXI_DMA_FLAG_USE_CFG2),
+ }, {
+ .compatible = "starfive,jh8100-axi-dma",
+ .data = (void *)AXI_DMA_FLAG_HAS_RESETS,
},
{}
};
--
2.25.1
On Tue, Mar 26, 2024 at 02:54:56AM -0700, Tan Chun Hau wrote:
> Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
> controller.
Your commit message should explain what makes this incompatible with
existing devices. That inforatiion does appear to be in the driver
patch, but should also be here. Otherwise,
Acked-by: Conor Dooley <[email protected]>
>
> Signed-off-by: Tan Chun Hau <[email protected]>
> ---
> Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 363cf8bd150d..525f5f3932f5 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -21,6 +21,7 @@ properties:
> - snps,axi-dma-1.01a
> - intel,kmb-axi-dma
> - starfive,jh7110-axi-dma
> + - starfive,jh8100-axi-dma
>
> reg:
> minItems: 1
> --
> 2.25.1
>
> -----Original Message-----
> From: Conor Dooley <[email protected]>
> Sent: Wednesday, 27 March, 2024 2:33 AM
> To: ChunHau Tan <[email protected]>
> Cc: Eugeniy Paltsev <[email protected]>; Vinod Koul
> <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski
> <[email protected]>; Conor Dooley <[email protected]>;
> Leyfoon Tan <[email protected]>; JeeHeng Sia
> <[email protected]>; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100
> support
>
> On Tue, Mar 26, 2024 at 02:54:56AM -0700, Tan Chun Hau wrote:
> > Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
> > controller.
>
> Your commit message should explain what makes this incompatible with existing
> devices. That inforatiion does appear to be in the driver patch, but should also be
> here. Otherwise,
> Acked-by: Conor Dooley <[email protected]>
Okay, thank you for the feedback.
>
> >
> > Signed-off-by: Tan Chun Hau <[email protected]>
> > ---
> > Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > index 363cf8bd150d..525f5f3932f5 100644
> > --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > @@ -21,6 +21,7 @@ properties:
> > - snps,axi-dma-1.01a
> > - intel,kmb-axi-dma
> > - starfive,jh7110-axi-dma
> > + - starfive,jh8100-axi-dma
> >
> > reg:
> > minItems: 1
> > --
> > 2.25.1
> >