2024-04-15 01:50:06

by yebin (H)

Subject: [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable()

If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.

Fixes: 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
Signed-off-by: Ye Bin <[email protected]>
---
drivers/vfio/pci/vfio_pci_intrs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
index fb5392b749ff..e80c5d75b541 100644
--- a/drivers/vfio/pci/vfio_pci_intrs.c
+++ b/drivers/vfio/pci/vfio_pci_intrs.c
@@ -277,8 +277,10 @@ static int vfio_intx_enable(struct vfio_pci_core_device *vdev,
return -ENOMEM;

ctx = vfio_irq_ctx_alloc(vdev, 0);
- if (!ctx)
+ if (!ctx) {
+ kfree(name);
return -ENOMEM;
+ }

ctx->name = name;
ctx->trigger = trigger;
--
2.31.1

2024-04-17 05:03:12

by Tian, Kevin

Subject: RE: [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable()

> From: Ye Bin <[email protected]>
> Sent: Monday, April 15, 2024 9:50 AM
>
> If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.
>
> Fixes: 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
> Signed-off-by: Ye Bin <[email protected]>

Reviewed-by: Kevin Tian <[email protected]>

2024-04-18 03:19:02

by Reinette Chatre

Subject: Re: [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable()

On 4/14/2024 6:50 PM, Ye Bin wrote:
> If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.
>
> Fixes: 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
> Signed-off-by: Ye Bin <[email protected]>
> ---

Thank you for catching this.

Acked-by: Reinette Chatre <[email protected]>

Reinette

2024-04-23 20:25:22

by Alex Williamson

Subject: Re: [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable()

On Mon, 15 Apr 2024 09:50:29 +0800
Ye Bin <[email protected]> wrote:

> If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.
>
> Fixes: 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
> Signed-off-by: Ye Bin <[email protected]>
> ---
> drivers/vfio/pci/vfio_pci_intrs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Applied to vfio next branch for v6.10. Thanks!

Alex