2024-04-15 12:56:28

by Herman van Hazendonk

Subject: [PATCH] mfd: pm8xxx: add support for PM8901

Add support for the pm8901 PMIC used by msm8660.

Signed-off-by: Herman van Hazendonk <[email protected]>
---
drivers/mfd/qcom-pm8xxx.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
index 8b6285f687da..9cca14d54d8d 100644
--- a/drivers/mfd/qcom-pm8xxx.c
+++ b/drivers/mfd/qcom-pm8xxx.c
@@ -501,6 +501,7 @@ static const struct pm_irq_data pm8821_data = {
static const struct of_device_id pm8xxx_id_table[] = {
{ .compatible = "qcom,pm8058", .data = &pm8xxx_data},
{ .compatible = "qcom,pm8821", .data = &pm8821_data},
+ { .compatible = "qcom,pm8901", .data = &pm8xxx_data},
{ .compatible = "qcom,pm8921", .data = &pm8xxx_data},
{ }
};

2024-04-15 19:32:00

by Konrad Dybcio

Subject: Re: [PATCH] mfd: pm8xxx: add support for PM8901

On 4/15/24 14:39, Herman van Hazendonk wrote:
> Add support for the pm8901 PMIC used by msm8660.
>
> Signed-off-by: Herman van Hazendonk <[email protected]>
> ---
> drivers/mfd/qcom-pm8xxx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
> index 8b6285f687da..9cca14d54d8d 100644
> --- a/drivers/mfd/qcom-pm8xxx.c
> +++ b/drivers/mfd/qcom-pm8xxx.c
> @@ -501,6 +501,7 @@ static const struct pm_irq_data pm8821_data = {
> static const struct of_device_id pm8xxx_id_table[] = {
> { .compatible = "qcom,pm8058", .data = &pm8xxx_data},
> { .compatible = "qcom,pm8821", .data = &pm8821_data},
> + { .compatible = "qcom,pm8901", .data = &pm8xxx_data},
> { .compatible = "qcom,pm8921", .data = &pm8xxx_data},

Please refrain from adding this new compatible, instead add a new,
generic one and modify the dt-bindings such that we go like:

compatible = "qcom,pm8901", "qcom,pm8xxx-ssbi-pmic"

(or similar, +CC Krzysztof, please chime in)

Konrad

2024-04-17 07:10:26

by Dmitry Baryshkov

Subject: Re: [PATCH] mfd: pm8xxx: add support for PM8901

On Mon, 15 Apr 2024 at 22:31, Konrad Dybcio <[email protected]> wrote:
>
>
>
> On 4/15/24 14:39, Herman van Hazendonk wrote:
> > Add support for the pm8901 PMIC used by msm8660.
> >
> > Signed-off-by: Herman van Hazendonk <[email protected]>
> > ---
> > drivers/mfd/qcom-pm8xxx.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
> > index 8b6285f687da..9cca14d54d8d 100644
> > --- a/drivers/mfd/qcom-pm8xxx.c
> > +++ b/drivers/mfd/qcom-pm8xxx.c
> > @@ -501,6 +501,7 @@ static const struct pm_irq_data pm8821_data = {
> > static const struct of_device_id pm8xxx_id_table[] = {
> > { .compatible = "qcom,pm8058", .data = &pm8xxx_data},
> > { .compatible = "qcom,pm8821", .data = &pm8821_data},
> > + { .compatible = "qcom,pm8901", .data = &pm8xxx_data},
> > { .compatible = "qcom,pm8921", .data = &pm8xxx_data},
>
> Please refrain from adding this new compatible, instead add a new,
> generic one and modify the dt-bindings such that we go like:
>
> compatible = "qcom,pm8901", "qcom,pm8xxx-ssbi-pmic"

I'd suggest against this. These PMICs were similar by nature, but not
fully compatible. Also we should not be using wildcards in compatible
strings.
I think the proposed string is fine.

Herman, I see that these patches are not properly threaded. Please
consider using the 'b4' tool for preparing and sending patches.
See https://b4.docs.kernel.org/en/latest/contributor/prep.html and
https://b4.docs.kernel.org/en/latest/contributor/send.html


--
With best wishes
Dmitry