2024-04-25 13:33:59

by Joshua Yeong

Subject: cpufreq: Fix printing large cpu and cpufreq number

Fix printing negative number when CPU frequency
with large number.

Signed-off-by: Joshua Yeong <[email protected]>
---
drivers/cpufreq/freq_table.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c
index c17dc51a5a02..9b9568023f3c 100644
--- a/drivers/cpufreq/freq_table.c
+++ b/drivers/cpufreq/freq_table.c
@@ -194,7 +194,7 @@ int cpufreq_table_index_unsorted(struct cpufreq_policy *policy,
}
if (optimal.driver_data > i) {
if (suboptimal.driver_data > i) {
- WARN(1, "Invalid frequency table: %d\n", policy->cpu);
+ WARN(1, "Invalid frequency table: %u\n", policy->cpu);
return 0;
}

@@ -254,7 +254,7 @@ static ssize_t show_available_freqs(struct cpufreq_policy *policy, char *buf,
if (show_boost ^ (pos->flags & CPUFREQ_BOOST_FREQ))
continue;

- count += sprintf(&buf[count], "%d ", pos->frequency);
+ count += sprintf(&buf[count], "%u ", pos->frequency);
}
count += sprintf(&buf[count], "\n");

--
2.25.1

2024-04-25 14:18:59

by Thorsten Blum

Subject: Re: cpufreq: Fix printing large cpu and cpufreq number

On 25. Apr 2024, at 13:00, Joshua Yeong <[email protected]> wrote:
>
> Fix printing negative number when CPU frequency
> with large number.
>
> Signed-off-by: Joshua Yeong <[email protected]>

Reviewed-by: Thorsten Blum <[email protected]>

2024-04-29 03:22:02

by Viresh Kumar

Subject: Re: cpufreq: Fix printing large cpu and cpufreq number

On 25-04-24, 19:00, Joshua Yeong wrote:
> Fix printing negative number when CPU frequency
> with large number.
>
> Signed-off-by: Joshua Yeong <[email protected]>
> ---
> drivers/cpufreq/freq_table.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c
> index c17dc51a5a02..9b9568023f3c 100644
> --- a/drivers/cpufreq/freq_table.c
> +++ b/drivers/cpufreq/freq_table.c
> @@ -194,7 +194,7 @@ int cpufreq_table_index_unsorted(struct cpufreq_policy *policy,
> }
> if (optimal.driver_data > i) {
> if (suboptimal.driver_data > i) {
> - WARN(1, "Invalid frequency table: %d\n", policy->cpu);
> + WARN(1, "Invalid frequency table: %u\n", policy->cpu);
> return 0;
> }
>
> @@ -254,7 +254,7 @@ static ssize_t show_available_freqs(struct cpufreq_policy *policy, char *buf,
> if (show_boost ^ (pos->flags & CPUFREQ_BOOST_FREQ))
> continue;
>
> - count += sprintf(&buf[count], "%d ", pos->frequency);
> + count += sprintf(&buf[count], "%u ", pos->frequency);
> }
> count += sprintf(&buf[count], "\n");

Acked-by: Viresh Kumar <[email protected]>

--
viresh

2024-04-30 10:58:00

by Rafael J. Wysocki

Subject: Re: cpufreq: Fix printing large cpu and cpufreq number

On Mon, Apr 29, 2024 at 5:21 AM Viresh Kumar <[email protected]> wrote:
>
> On 25-04-24, 19:00, Joshua Yeong wrote:
> > Fix printing negative number when CPU frequency
> > with large number.
> >
> > Signed-off-by: Joshua Yeong <[email protected]>
> > ---
> > drivers/cpufreq/freq_table.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c
> > index c17dc51a5a02..9b9568023f3c 100644
> > --- a/drivers/cpufreq/freq_table.c
> > +++ b/drivers/cpufreq/freq_table.c
> > @@ -194,7 +194,7 @@ int cpufreq_table_index_unsorted(struct cpufreq_policy *policy,
> > }
> > if (optimal.driver_data > i) {
> > if (suboptimal.driver_data > i) {
> > - WARN(1, "Invalid frequency table: %d\n", policy->cpu);
> > + WARN(1, "Invalid frequency table: %u\n", policy->cpu);
> > return 0;
> > }
> >
> > @@ -254,7 +254,7 @@ static ssize_t show_available_freqs(struct cpufreq_policy *policy, char *buf,
> > if (show_boost ^ (pos->flags & CPUFREQ_BOOST_FREQ))
> > continue;
> >
> > - count += sprintf(&buf[count], "%d ", pos->frequency);
> > + count += sprintf(&buf[count], "%u ", pos->frequency);
> > }
> > count += sprintf(&buf[count], "\n");
>
> Acked-by: Viresh Kumar <[email protected]>
>
> --

Applied as 6.10 material with edited subject and changelog, thanks!