Allow the Dynamic Interrupt Moderation (DIM) library to be built as a
module. This is particularly useful in an Android GKI (Google Kernel
Image) configuration where everything is built as a module, including
Ethernet controller drivers. Having to build DIMLIB into the kernel
image with potentially no user is wasteful.
Signed-off-by: Florian Fainelli <[email protected]>
---
Changes in v2:
- Added MODULE_DESCRIPTION()
lib/Kconfig | 2 +-
lib/dim/Makefile | 4 ++--
lib/dim/dim.c | 3 +++
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/Kconfig b/lib/Kconfig
index 4557bb8a5256..d33a268bc256 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -628,7 +628,7 @@ config SIGNATURE
Implementation is done using GnuPG MPI library
config DIMLIB
- bool
+ tristate
help
Dynamic Interrupt Moderation library.
Implements an algorithm for dynamically changing CQ moderation values
diff --git a/lib/dim/Makefile b/lib/dim/Makefile
index 1d6858a108cb..c4cc4026c451 100644
--- a/lib/dim/Makefile
+++ b/lib/dim/Makefile
@@ -2,6 +2,6 @@
# DIM Dynamic Interrupt Moderation library
#
-obj-$(CONFIG_DIMLIB) += dim.o
+obj-$(CONFIG_DIMLIB) += dimlib.o
-dim-y := dim.o net_dim.o rdma_dim.o
+dimlib-objs := dim.o net_dim.o rdma_dim.o
diff --git a/lib/dim/dim.c b/lib/dim/dim.c
index e89aaf07bde5..83b65ac74d73 100644
--- a/lib/dim/dim.c
+++ b/lib/dim/dim.c
@@ -82,3 +82,6 @@ bool dim_calc_stats(struct dim_sample *start, struct dim_sample *end,
return true;
}
EXPORT_SYMBOL(dim_calc_stats);
+
+MODULE_DESCRIPTION("Dynamic Interrupt Moderation (DIM) library");
+MODULE_LICENSE("Dual BSD/GPL");
--
2.34.1
From: Florian Fainelli <[email protected]>
Date: Mon, 6 May 2024 10:50:40 -0700
> Allow the Dynamic Interrupt Moderation (DIM) library to be built as a
> module. This is particularly useful in an Android GKI (Google Kernel
> Image) configuration where everything is built as a module, including
> Ethernet controller drivers. Having to build DIMLIB into the kernel
> image with potentially no user is wasteful.
Some bloat-o-meter -c vmlinux.{before,after} would be good to have here.
The library is small, but I personally would like to see it modular.
>
> Signed-off-by: Florian Fainelli <[email protected]>
Reviewed-by: Alexander Lobakin <[email protected]>
> ---
> Changes in v2:
>
> - Added MODULE_DESCRIPTION()
>
> lib/Kconfig | 2 +-
> lib/dim/Makefile | 4 ++--
> lib/dim/dim.c | 3 +++
> 3 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 4557bb8a5256..d33a268bc256 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -628,7 +628,7 @@ config SIGNATURE
> Implementation is done using GnuPG MPI library
>
> config DIMLIB
> - bool
> + tristate
> help
> Dynamic Interrupt Moderation library.
> Implements an algorithm for dynamically changing CQ moderation values
> diff --git a/lib/dim/Makefile b/lib/dim/Makefile
> index 1d6858a108cb..c4cc4026c451 100644
> --- a/lib/dim/Makefile
> +++ b/lib/dim/Makefile
> @@ -2,6 +2,6 @@
> # DIM Dynamic Interrupt Moderation library
> #
>
> -obj-$(CONFIG_DIMLIB) += dim.o
> +obj-$(CONFIG_DIMLIB) += dimlib.o
I guess you renamed it due to that there's already a module named 'dim'?
>
> -dim-y := dim.o net_dim.o rdma_dim.o
> +dimlib-objs := dim.o net_dim.o rdma_dim.o
> diff --git a/lib/dim/dim.c b/lib/dim/dim.c
> index e89aaf07bde5..83b65ac74d73 100644
> --- a/lib/dim/dim.c
> +++ b/lib/dim/dim.c
> @@ -82,3 +82,6 @@ bool dim_calc_stats(struct dim_sample *start, struct dim_sample *end,
> return true;
> }
> EXPORT_SYMBOL(dim_calc_stats);
> +
> +MODULE_DESCRIPTION("Dynamic Interrupt Moderation (DIM) library");
> +MODULE_LICENSE("Dual BSD/GPL");
Thanks,
Olek
On 5/7/24 06:13, Alexander Lobakin wrote:
> From: Florian Fainelli <[email protected]>
> Date: Mon, 6 May 2024 10:50:40 -0700
>
>> Allow the Dynamic Interrupt Moderation (DIM) library to be built as a
>> module. This is particularly useful in an Android GKI (Google Kernel
>> Image) configuration where everything is built as a module, including
>> Ethernet controller drivers. Having to build DIMLIB into the kernel
>> image with potentially no user is wasteful.
>
> Some bloat-o-meter -c vmlinux.{before,after} would be good to have here.
> The library is small, but I personally would like to see it modular.
/scripts/bloat-o-meter vmlinux vmlinux.after
add/remove: 1/16 grow/shrink: 0/0 up/down: 8/-1980 (-1972)
Function old new delta
e843419@0740_00005048_4014 - 8 +8
e843419@07b3_000055c6_5944 8 - -8
dim_park_on_top 8 - -8
dim_park_tired 16 - -16
net_dim_get_def_tx_moderation 24 - -24
net_dim_get_def_rx_moderation 24 - -24
dim_turn 52 - -52
net_dim_get_rx_moderation 60 - -60
net_dim_get_tx_moderation 64 - -64
tx_profile 80 - -80
rx_profile 80 - -80
dim_on_top 84 - -84
net_dim_step 132 - -132
dim_calc_stats 172 - -172
net_dim_stats_compare 176 - -176
net_dim 464 - -464
rdma_dim 536 - -536
Total: Before=12668884, After=12666912, chg -0.02%
This is on arm64 FWIW.
>
>>
>> Signed-off-by: Florian Fainelli <[email protected]>
>
> Reviewed-by: Alexander Lobakin <[email protected]>
>
>> ---
>> Changes in v2:
>>
>> - Added MODULE_DESCRIPTION()
>>
>> lib/Kconfig | 2 +-
>> lib/dim/Makefile | 4 ++--
>> lib/dim/dim.c | 3 +++
>> 3 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/Kconfig b/lib/Kconfig
>> index 4557bb8a5256..d33a268bc256 100644
>> --- a/lib/Kconfig
>> +++ b/lib/Kconfig
>> @@ -628,7 +628,7 @@ config SIGNATURE
>> Implementation is done using GnuPG MPI library
>>
>> config DIMLIB
>> - bool
>> + tristate
>> help
>> Dynamic Interrupt Moderation library.
>> Implements an algorithm for dynamically changing CQ moderation values
>> diff --git a/lib/dim/Makefile b/lib/dim/Makefile
>> index 1d6858a108cb..c4cc4026c451 100644
>> --- a/lib/dim/Makefile
>> +++ b/lib/dim/Makefile
>> @@ -2,6 +2,6 @@
>> # DIM Dynamic Interrupt Moderation library
>> #
>>
>> -obj-$(CONFIG_DIMLIB) += dim.o
>> +obj-$(CONFIG_DIMLIB) += dimlib.o
>
> I guess you renamed it due to that there's already a module named 'dim'?
This is required to avoid the follow recursive dependency:
make[4]: Circular lib/dim/dim.o <- lib/dim/dim.o dependency dropped.
--
Florian
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:
On Mon, 6 May 2024 10:50:40 -0700 you wrote:
> Allow the Dynamic Interrupt Moderation (DIM) library to be built as a
> module. This is particularly useful in an Android GKI (Google Kernel
> Image) configuration where everything is built as a module, including
> Ethernet controller drivers. Having to build DIMLIB into the kernel
> image with potentially no user is wasteful.
>
> Signed-off-by: Florian Fainelli <[email protected]>
>
> [...]
Here is the summary with links:
- [net-next,v2] lib: Allow for the DIM library to be modular
https://git.kernel.org/netdev/net-next/c/0d5044b4e774
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
From: Florian Fainelli <[email protected]>
Date: Tue, 7 May 2024 10:08:19 -0700
> On 5/7/24 06:13, Alexander Lobakin wrote:
>> From: Florian Fainelli <[email protected]>
>> Date: Mon, 6 May 2024 10:50:40 -0700
>>
>>> Allow the Dynamic Interrupt Moderation (DIM) library to be built as a
>>> module. This is particularly useful in an Android GKI (Google Kernel
>>> Image) configuration where everything is built as a module, including
>>> Ethernet controller drivers. Having to build DIMLIB into the kernel
>>> image with potentially no user is wasteful.
>>
>> Some bloat-o-meter -c vmlinux.{before,after} would be good to have here.
>> The library is small, but I personally would like to see it modular.
>
> ./scripts/bloat-o-meter vmlinux vmlinux.after
> add/remove: 1/16 grow/shrink: 0/0 up/down: 8/-1980 (-1972)
> Function old new delta
> e843419@0740_00005048_4014 - 8 +8
> e843419@07b3_000055c6_5944 8 - -8
> dim_park_on_top 8 - -8
> dim_park_tired 16 - -16
> net_dim_get_def_tx_moderation 24 - -24
> net_dim_get_def_rx_moderation 24 - -24
> dim_turn 52 - -52
> net_dim_get_rx_moderation 60 - -60
> net_dim_get_tx_moderation 64 - -64
> tx_profile 80 - -80
> rx_profile 80 - -80
> dim_on_top 84 - -84
> net_dim_step 132 - -132
> dim_calc_stats 172 - -172
> net_dim_stats_compare 176 - -176
> net_dim 464 - -464
> rdma_dim 536 - -536
> Total: Before=12668884, After=12666912, chg -0.02%
>
> This is on arm64 FWIW.
-2 Kb sounds reasonable I'd say. This doesn't even require adding new
exports, nice.
>
>>
>>>
>>> Signed-off-by: Florian Fainelli <[email protected]>
>>
>> Reviewed-by: Alexander Lobakin <[email protected]>
>>
>>> ---
>>> Changes in v2:
>>>
>>> - Added MODULE_DESCRIPTION()
>>>
>>> lib/Kconfig | 2 +-
>>> lib/dim/Makefile | 4 ++--
>>> lib/dim/dim.c | 3 +++
>>> 3 files changed, 6 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/lib/Kconfig b/lib/Kconfig
>>> index 4557bb8a5256..d33a268bc256 100644
>>> --- a/lib/Kconfig
>>> +++ b/lib/Kconfig
>>> @@ -628,7 +628,7 @@ config SIGNATURE
>>> Implementation is done using GnuPG MPI library
>>> config DIMLIB
>>> - bool
>>> + tristate
>>> help
>>> Dynamic Interrupt Moderation library.
>>> Implements an algorithm for dynamically changing CQ
>>> moderation values
>>> diff --git a/lib/dim/Makefile b/lib/dim/Makefile
>>> index 1d6858a108cb..c4cc4026c451 100644
>>> --- a/lib/dim/Makefile
>>> +++ b/lib/dim/Makefile
>>> @@ -2,6 +2,6 @@
>>> # DIM Dynamic Interrupt Moderation library
>>> #
>>> -obj-$(CONFIG_DIMLIB) += dim.o
>>> +obj-$(CONFIG_DIMLIB) += dimlib.o
>>
>> I guess you renamed it due to that there's already a module named 'dim'?
>
> This is required to avoid the follow recursive dependency:
>
> make[4]: Circular lib/dim/dim.o <- lib/dim/dim.o dependency dropped.
Aaah I see!
Thanks,
Olek