2024-05-13 03:29:02

by Chen Ni

Subject: [PATCH] dpll: fix return value check for kmemdup

The return value of kmemdup() is dst->freq_supported, not
src->freq_supported. Update the check accordingly.

Fixes: 830ead5fb0c5 ("dpll: fix pin dump crash for rebound module")
Signed-off-by: Chen Ni <[email protected]>
---
drivers/dpll/dpll_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c
index d0f6693ca142..32019dc33cca 100644
--- a/drivers/dpll/dpll_core.c
+++ b/drivers/dpll/dpll_core.c
@@ -449,7 +449,7 @@ static int dpll_pin_prop_dup(const struct dpll_pin_properties *src,
sizeof(*src->freq_supported);
dst->freq_supported = kmemdup(src->freq_supported,
freq_size, GFP_KERNEL);
- if (!src->freq_supported)
+ if (!dst->freq_supported)
return -ENOMEM;
}
if (src->board_label) {
--
2.25.1

2024-05-13 08:15:53

by Przemek Kitszel

Subject: Re: [PATCH] dpll: fix return value check for kmemdup

On 5/13/24 05:28, Chen Ni wrote:
> The return value of kmemdup() is dst->freq_supported, not
> src->freq_supported. Update the check accordingly.
>
> Fixes: 830ead5fb0c5 ("dpll: fix pin dump crash for rebound module")
> Signed-off-by: Chen Ni <[email protected]>
> ---
> drivers/dpll/dpll_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c
> index d0f6693ca142..32019dc33cca 100644
> --- a/drivers/dpll/dpll_core.c
> +++ b/drivers/dpll/dpll_core.c
> @@ -449,7 +449,7 @@ static int dpll_pin_prop_dup(const struct dpll_pin_properties *src,
> sizeof(*src->freq_supported);
> dst->freq_supported = kmemdup(src->freq_supported,
> freq_size, GFP_KERNEL);
> - if (!src->freq_supported)
> + if (!dst->freq_supported)
> return -ENOMEM;
> }
> if (src->board_label) {

Reviewed-by: Przemek Kitszel <[email protected]>

2024-05-13 08:19:48

by Kubalewski, Arkadiusz

Subject: RE: [PATCH] dpll: fix return value check for kmemdup

>From: Chen Ni <[email protected]>
>Sent: Monday, May 13, 2024 5:28 AM
>
>The return value of kmemdup() is dst->freq_supported, not
>src->freq_supported. Update the check accordingly.
>
>Fixes: 830ead5fb0c5 ("dpll: fix pin dump crash for rebound module")
>Signed-off-by: Chen Ni <[email protected]>
>---
> drivers/dpll/dpll_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c
>index d0f6693ca142..32019dc33cca 100644
>--- a/drivers/dpll/dpll_core.c
>+++ b/drivers/dpll/dpll_core.c
>@@ -449,7 +449,7 @@ static int dpll_pin_prop_dup(const struct
>dpll_pin_properties *src,
> sizeof(*src->freq_supported);
> dst->freq_supported = kmemdup(src->freq_supported,
> freq_size, GFP_KERNEL);
>- if (!src->freq_supported)
>+ if (!dst->freq_supported)
> return -ENOMEM;
> }
> if (src->board_label) {
>--
>2.25.1

LGTM, Thanks!

Reviewed-by: Arkadiusz Kubalewski <[email protected]>

2024-05-13 11:54:54

by Jiri Pirko

Subject: Re: [PATCH] dpll: fix return value check for kmemdup

Mon, May 13, 2024 at 05:28:24AM CEST, [email protected] wrote:
>The return value of kmemdup() is dst->freq_supported, not
>src->freq_supported. Update the check accordingly.
>
>Fixes: 830ead5fb0c5 ("dpll: fix pin dump crash for rebound module")
>Signed-off-by: Chen Ni <[email protected]>

Reviewed-by: Jiri Pirko <[email protected]>

2024-05-14 00:10:37

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] dpll: fix return value check for kmemdup

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

On Mon, 13 May 2024 11:28:24 +0800 you wrote:
> The return value of kmemdup() is dst->freq_supported, not
> src->freq_supported. Update the check accordingly.
>
> Fixes: 830ead5fb0c5 ("dpll: fix pin dump crash for rebound module")
> Signed-off-by: Chen Ni <[email protected]>
> ---
> drivers/dpll/dpll_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- dpll: fix return value check for kmemdup
https://git.kernel.org/netdev/net/c/ad506586cb69

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html