2024-05-29 02:30:11

by John Hubbard

Subject: [PATCH v2 1/3] selftests/futex: don't redefine .PHONY targets (all, clean)

The .PHONY targets "all" and "clean" are both defined in the file that
is included in the very next line: ../lib.mk.

Reviewed-by: Davidlohr Bueso <[email protected]>
Signed-off-by: John Hubbard <[email protected]>
---
tools/testing/selftests/futex/Makefile | 2 --
1 file changed, 2 deletions(-)

diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
index 11e157d7533b..78ab2cd111f6 100644
--- a/tools/testing/selftests/futex/Makefile
+++ b/tools/testing/selftests/futex/Makefile
@@ -3,8 +3,6 @@ SUBDIRS := functional

TEST_PROGS := run.sh

-.PHONY: all clean
-
include ../lib.mk

all:
--
2.45.1

2024-05-30 19:03:34

by Shuah Khan

Subject: Re: [PATCH v2 1/3] selftests/futex: don't redefine .PHONY targets (all, clean)

On 5/28/24 20:29, John Hubbard wrote:
> The .PHONY targets "all" and "clean" are both defined in the file that
> is included in the very next line: ../lib.mk.
>

What problems are you seeing without this patch?
If I recall correctly, futex needs these defined.

Please provide information on why this change is
needed.

> Reviewed-by: Davidlohr Bueso <[email protected]>
> Signed-off-by: John Hubbard <[email protected]>
> ---
> tools/testing/selftests/futex/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index 11e157d7533b..78ab2cd111f6 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -3,8 +3,6 @@ SUBDIRS := functional
>
> TEST_PROGS := run.sh
>
> -.PHONY: all clean
> -
> include ../lib.mk
>
> all:

thanks,
-- Shuah

2024-05-30 21:14:51

by Shuah Khan

Subject: Re: [PATCH v2 1/3] selftests/futex: don't redefine .PHONY targets (all, clean)

On 5/30/24 13:13, John Hubbard wrote:
> On 5/30/24 12:03 PM, Shuah Khan wrote:
>> On 5/28/24 20:29, John Hubbard wrote:
>>> The .PHONY targets "all" and "clean"  are both defined in the file that
>>> is included in the very next line: ../lib.mk.
>>>
>>
>> What problems are you seeing without this patch?
>
> Code duplication. It's a sin. :)

Please mention that you are removing duplicate code.

futex Makefile overrides CLEAN - just making sure it
does the cleanup correctly.

thanks,
-- Shuah

2024-05-30 21:18:40

by John Hubbard

Subject: Re: [PATCH v2 1/3] selftests/futex: don't redefine .PHONY targets (all, clean)

On 5/30/24 2:12 PM, Shuah Khan wrote:
> On 5/30/24 13:13, John Hubbard wrote:
>> On 5/30/24 12:03 PM, Shuah Khan wrote:
>>> On 5/28/24 20:29, John Hubbard wrote:
>>>> The .PHONY targets "all" and "clean"  are both defined in the file that
>>>> is included in the very next line: ../lib.mk.
>>>>
>>>
>>> What problems are you seeing without this patch?
>>
>> Code duplication. It's a sin. :)
>
> Please mention that you are removing duplicate code.
>
> futex Makefile overrides CLEAN - just making sure it

(Overrides of Makefile things are per-item, so to speak, not per
file, just to be clear.)

> does the cleanup correctly.
>

OK sure, I'll update the commit message and post a v3, coming soon.


thanks,
--
John Hubbard
NVIDIA