2023-07-21 11:47:04

by Marco Felsch

Subject: [PATCH net-next v4 1/3] dt-bindings: net: snps,dwmac: add phy-supply support

Document the common phy-supply property to be able to specify a phy
regulator.

Signed-off-by: Marco Felsch <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
---
Changelog:
v4:
- no changes
v3:
- no changes
v2
- add ack-by

Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index ddf9522a5dc23..847ecb82b37ee 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -160,6 +160,9 @@ properties:
can be passive (no SW requirement), and requires that the MAC operate
in a different mode than the PHY in order to function.

+ phy-supply:
+ description: PHY regulator
+
snps,axi-config:
$ref: /schemas/types.yaml#/definitions/phandle
description:
--
2.39.2

2023-07-21 14:47:22

by Rob Herring (Arm)

Subject: Re: [PATCH net-next v4 1/3] dt-bindings: net: snps,dwmac: add phy-supply support

On Fri, Jul 21, 2023 at 01:03:43PM +0200, Marco Felsch wrote:
> Document the common phy-supply property to be able to specify a phy
> regulator.

What common property? I don't see any such property in
ethernet-controller.yaml.

>
> Signed-off-by: Marco Felsch <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>
> ---
> Changelog:
> v4:
> - no changes
> v3:
> - no changes
> v2
> - add ack-by
>
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index ddf9522a5dc23..847ecb82b37ee 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -160,6 +160,9 @@ properties:
> can be passive (no SW requirement), and requires that the MAC operate
> in a different mode than the PHY in order to function.
>
> + phy-supply:
> + description: PHY regulator

Is this for an serdes, sgmii, etc. type phy or ethernet phy? Either way,
this property belongs in the PHY's node because it is the PHY that has
supply connection. I'm guessing you put this here for the latter case
because ethernet PHYs on MDIO are "discoverable" except for the small
problem that powering them on is not discoverable.

Rob

2023-07-24 10:17:12

by Marco Felsch

Subject: Re: [PATCH net-next v4 1/3] dt-bindings: net: snps,dwmac: add phy-supply support

Hi Rob,

On 23-07-21, Rob Herring wrote:
> On Fri, Jul 21, 2023 at 01:03:43PM +0200, Marco Felsch wrote:
> > Document the common phy-supply property to be able to specify a phy
> > regulator.
>
> What common property? I don't see any such property in
> ethernet-controller.yaml.

Not in ethernet-controller.yaml but there are at least a few user of
this binding:
- allwinner,sun4i-a10-mdio.yaml
- allwinner,sun7i-a20-gmac.yaml
- allwinner,sun8i-a83t-emac.yaml
- fsl,fec.yaml
- rockchip-dwmac.yaml
- rockchip,emac.yaml

Also there is no <vendor>,phy-supply nor <ip-vendor>,phy-supply,
therefore I thought this is common.

> > Signed-off-by: Marco Felsch <[email protected]>
> > Acked-by: Krzysztof Kozlowski <[email protected]>
> > ---
> > Changelog:
> > v4:
> > - no changes
> > v3:
> > - no changes
> > v2
> > - add ack-by
> >
> > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > index ddf9522a5dc23..847ecb82b37ee 100644
> > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > @@ -160,6 +160,9 @@ properties:
> > can be passive (no SW requirement), and requires that the MAC operate
> > in a different mode than the PHY in order to function.
> >
> > + phy-supply:
> > + description: PHY regulator
>
> Is this for an serdes, sgmii, etc. type phy or ethernet phy? Either way,
> this property belongs in the PHY's node because it is the PHY that has
> supply connection. I'm guessing you put this here for the latter case
> because ethernet PHYs on MDIO are "discoverable" except for the small
> problem that powering them on is not discoverable.

All kind of ethernet phys connected to you etherent MAC which need to be
power controlled by software. You're right this sould belong to the PHY
node (as Krzysztof already mentioned) but this isn't the case yet. As
you can see there are at least 6 user of the exact same binding.

Regards,
Marco

2023-08-09 10:17:03

by Marco Felsch

Subject: Re: [PATCH net-next v4 1/3] dt-bindings: net: snps,dwmac: add phy-supply support

Hi Rob,

On 23-07-24, Marco Felsch wrote:
> Hi Rob,
>
> On 23-07-21, Rob Herring wrote:
> > On Fri, Jul 21, 2023 at 01:03:43PM +0200, Marco Felsch wrote:
> > > Document the common phy-supply property to be able to specify a phy
> > > regulator.
> >
> > What common property? I don't see any such property in
> > ethernet-controller.yaml.
>
> Not in ethernet-controller.yaml but there are at least a few user of
> this binding:
> - allwinner,sun4i-a10-mdio.yaml
> - allwinner,sun7i-a20-gmac.yaml
> - allwinner,sun8i-a83t-emac.yaml
> - fsl,fec.yaml
> - rockchip-dwmac.yaml
> - rockchip,emac.yaml
>
> Also there is no <vendor>,phy-supply nor <ip-vendor>,phy-supply,
> therefore I thought this is common.

any further comments else I would like to gentle ping this series.

Regards,
Marco

> > > Signed-off-by: Marco Felsch <[email protected]>
> > > Acked-by: Krzysztof Kozlowski <[email protected]>
> > > ---
> > > Changelog:
> > > v4:
> > > - no changes
> > > v3:
> > > - no changes
> > > v2
> > > - add ack-by
> > >
> > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > index ddf9522a5dc23..847ecb82b37ee 100644
> > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > @@ -160,6 +160,9 @@ properties:
> > > can be passive (no SW requirement), and requires that the MAC operate
> > > in a different mode than the PHY in order to function.
> > >
> > > + phy-supply:
> > > + description: PHY regulator
> >
> > Is this for an serdes, sgmii, etc. type phy or ethernet phy? Either way,
> > this property belongs in the PHY's node because it is the PHY that has
> > supply connection. I'm guessing you put this here for the latter case
> > because ethernet PHYs on MDIO are "discoverable" except for the small
> > problem that powering them on is not discoverable.
>
> All kind of ethernet phys connected to you etherent MAC which need to be
> power controlled by software. You're right this sould belong to the PHY
> node (as Krzysztof already mentioned) but this isn't the case yet. As
> you can see there are at least 6 user of the exact same binding.
>
> Regards,
> Marco
>
>

2023-08-29 13:38:27

by Marco Felsch

Subject: Re: [PATCH net-next v4 1/3] dt-bindings: net: snps, dwmac: add phy-supply support

Hi,

gentle ping on this series.

On 23-07-21, Marco Felsch wrote:
> Document the common phy-supply property to be able to specify a phy
> regulator.
>
> Signed-off-by: Marco Felsch <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>
> ---
> Changelog:
> v4:
> - no changes
> v3:
> - no changes
> v2
> - add ack-by
>
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index ddf9522a5dc23..847ecb82b37ee 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -160,6 +160,9 @@ properties:
> can be passive (no SW requirement), and requires that the MAC operate
> in a different mode than the PHY in order to function.
>
> + phy-supply:
> + description: PHY regulator
> +
> snps,axi-config:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
> --
> 2.39.2
>
>
>

2023-09-18 06:44:41

by Marco Felsch

Subject: Re: [PATCH net-next v4 1/3] dt-bindings: net: snps, dwmac: add phy-supply support

Hi,

On 23-08-29, Marco Felsch wrote:
>
> Hi,
>
> gentle ping on this series.

ping++

> On 23-07-21, Marco Felsch wrote:
> > Document the common phy-supply property to be able to specify a phy
> > regulator.
> >
> > Signed-off-by: Marco Felsch <[email protected]>
> > Acked-by: Krzysztof Kozlowski <[email protected]>
> > ---
> > Changelog:
> > v4:
> > - no changes
> > v3:
> > - no changes
> > v2
> > - add ack-by
> >
> > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > index ddf9522a5dc23..847ecb82b37ee 100644
> > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > @@ -160,6 +160,9 @@ properties:
> > can be passive (no SW requirement), and requires that the MAC operate
> > in a different mode than the PHY in order to function.
> >
> > + phy-supply:
> > + description: PHY regulator
> > +
> > snps,axi-config:
> > $ref: /schemas/types.yaml#/definitions/phandle
> > description:
> > --
> > 2.39.2
> >
> >
> >
>
>

2024-06-08 15:22:10

by Laurent Pinchart

Subject: Re: [PATCH net-next v4 1/3] dt-bindings: net: snps,dwmac: add phy-supply support

Hi Rob,

On Fri, Jul 21, 2023 at 08:24:33AM -0600, Rob Herring wrote:
> On Fri, Jul 21, 2023 at 01:03:43PM +0200, Marco Felsch wrote:
> > Document the common phy-supply property to be able to specify a phy
> > regulator.
>
> What common property? I don't see any such property in
> ethernet-controller.yaml.
>
> > Signed-off-by: Marco Felsch <[email protected]>
> > Acked-by: Krzysztof Kozlowski <[email protected]>
> > ---
> > Changelog:
> > v4:
> > - no changes
> > v3:
> > - no changes
> > v2
> > - add ack-by
> >
> > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > index ddf9522a5dc23..847ecb82b37ee 100644
> > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > @@ -160,6 +160,9 @@ properties:
> > can be passive (no SW requirement), and requires that the MAC operate
> > in a different mode than the PHY in order to function.
> >
> > + phy-supply:
> > + description: PHY regulator
>
> Is this for an serdes, sgmii, etc. type phy or ethernet phy? Either way,
> this property belongs in the PHY's node because it is the PHY that has
> supply connection. I'm guessing you put this here for the latter case
> because ethernet PHYs on MDIO are "discoverable" except for the small
> problem that powering them on is not discoverable.

Any idea on how to solve that problem generically ?

--
Regards,

Laurent Pinchart