2024-05-22 08:37:07

by Bhavya Kapoor

Subject: [PATCH] arm64: dts: ti: k3-j722s-evm: Mark eMMC as non removable

Mark the eMMC module on J722S as non removable since it
is always present on the evm.

Signed-off-by: Bhavya Kapoor <[email protected]>
---
arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
index bf3c246d13d1..fe810e32cb7a 100644
--- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
@@ -369,6 +369,7 @@ partition@3fc0000 {
&sdhci0 {
disable-wp;
bootph-all;
+ non-removable;
ti,driver-strength-ohm = <50>;
status = "okay";
};
--
2.34.1

2024-05-23 09:55:08

by Vignesh Raghavendra

Subject: Re: [PATCH] arm64: dts: ti: k3-j722s-evm: Mark eMMC as non removable

On 22/05/24 14:06, Bhavya Kapoor wrote:
> Mark the eMMC module on J722S as non removable since it
> is always present on the evm.

Nit s/evm/EVM

>
> Signed-off-by: Bhavya Kapoor <[email protected]>
> ---

This needs a Fixes tag?

> arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> index bf3c246d13d1..fe810e32cb7a 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> @@ -369,6 +369,7 @@ partition@3fc0000 {
> &sdhci0 {
> disable-wp;
> bootph-all;
> + non-removable;
> ti,driver-strength-ohm = <50>;
> status = "okay";
> };


--
Regards
Vignesh

2024-05-24 07:19:19

by Bhavya Kapoor

Subject: Re: [PATCH] arm64: dts: ti: k3-j722s-evm: Mark eMMC as non removable

On 23/05/24 3:24 pm, Vignesh Raghavendra wrote:
>
> On 22/05/24 14:06, Bhavya Kapoor wrote:
>> Mark the eMMC module on J722S as non removable since it
>> is always present on the evm.
> Nit s/evm/EVM
This definately demands a v2
>
>> Signed-off-by: Bhavya Kapoor <[email protected]>
>> ---
> This needs a Fixes tag?

Hi Vignesh, we are just adding up a property so i assume we should not
need a fixes tag.

We can take reference from how its done in this patch:
https://patchwork.kernel.org/project/linux-samsung-soc/patch/[email protected]/

>
>> arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> index bf3c246d13d1..fe810e32cb7a 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> @@ -369,6 +369,7 @@ partition@3fc0000 {
>> &sdhci0 {
>> disable-wp;
>> bootph-all;
>> + non-removable;
>> ti,driver-strength-ohm = <50>;
>> status = "okay";
>> };
>