2023-08-08 16:26:21

by Yue Haibing

Subject: [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo()

Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()")
removed the implementation but leave declaration.

Signed-off-by: Yue Haibing <[email protected]>
---
include/linux/device-mapper.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
index 69d0435c7ebb..5bc69c6a64e0 100644
--- a/include/linux/device-mapper.h
+++ b/include/linux/device-mapper.h
@@ -502,7 +502,6 @@ int dm_post_suspending(struct dm_target *ti);
int dm_noflush_suspending(struct dm_target *ti);
void dm_accept_partial_bio(struct bio *bio, unsigned int n_sectors);
void dm_submit_bio_remap(struct bio *clone, struct bio *tgt_clone);
-union map_info *dm_get_rq_mapinfo(struct request *rq);

#ifdef CONFIG_BLK_DEV_ZONED
struct dm_report_zones_args {
--
2.34.1

2023-08-08 19:09:06

by Hugo Villeneuve

Subject: Re: [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo()

On Tue, 8 Aug 2023 23:03:01 +0800
Yue Haibing <[email protected]> wrote:

Hi,

> Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()")
> removed the implementation but leave declaration.

Maybe change to "removed the implementation but not the declaration."

Hugo Villeneuve.


> Signed-off-by: Yue Haibing <[email protected]>
> ---
> include/linux/device-mapper.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
> index 69d0435c7ebb..5bc69c6a64e0 100644
> --- a/include/linux/device-mapper.h
> +++ b/include/linux/device-mapper.h
> @@ -502,7 +502,6 @@ int dm_post_suspending(struct dm_target *ti);
> int dm_noflush_suspending(struct dm_target *ti);
> void dm_accept_partial_bio(struct bio *bio, unsigned int n_sectors);
> void dm_submit_bio_remap(struct bio *clone, struct bio *tgt_clone);
> -union map_info *dm_get_rq_mapinfo(struct request *rq);
>
> #ifdef CONFIG_BLK_DEV_ZONED
> struct dm_report_zones_args {
> --
> 2.34.1
>

2023-08-09 04:03:07

by Yue Haibing

Subject: Re: [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo()

On 2023/8/9 1:03, Hugo Villeneuve wrote:
> On Tue, 8 Aug 2023 23:03:01 +0800
> Yue Haibing <[email protected]> wrote:
>
> Hi,
>
>> Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()")
>> removed the implementation but leave declaration.
>
> Maybe change to "removed the implementation but not the declaration."

Thanks， will do this in v2.

>
> Hugo Villeneuve.
>
>
>> Signed-off-by: Yue Haibing <[email protected]>
>> ---
>> include/linux/device-mapper.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
>> index 69d0435c7ebb..5bc69c6a64e0 100644
>> --- a/include/linux/device-mapper.h
>> +++ b/include/linux/device-mapper.h
>> @@ -502,7 +502,6 @@ int dm_post_suspending(struct dm_target *ti);
>> int dm_noflush_suspending(struct dm_target *ti);
>> void dm_accept_partial_bio(struct bio *bio, unsigned int n_sectors);
>> void dm_submit_bio_remap(struct bio *clone, struct bio *tgt_clone);
>> -union map_info *dm_get_rq_mapinfo(struct request *rq);
>>
>> #ifdef CONFIG_BLK_DEV_ZONED
>> struct dm_report_zones_args {
>> --
>> 2.34.1
>>
>
> .
>