The assignment of the else and if branches is the same, so the else
here is redundant, so we remove it.
./drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:545:3-5: WARNING: possible condition with no effect (if == else).
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
.../platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
index 03d0188804ba..771e554182dc 100644
--- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
+++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
@@ -541,14 +541,8 @@ void hp_exit_password_attributes(void)
struct kobject *attr_name_kobj =
bioscfg_drv.password_data[instance_id].attr_name_kobj;
- if (attr_name_kobj) {
- if (!strcmp(attr_name_kobj->name, SETUP_PASSWD))
- sysfs_remove_group(attr_name_kobj,
- &password_attr_group);
- else
- sysfs_remove_group(attr_name_kobj,
- &password_attr_group);
- }
+ if (attr_name_kobj)
+ sysfs_remove_group(attr_name_kobj, &password_attr_group);
}
bioscfg_drv.password_instances_count = 0;
kfree(bioscfg_drv.password_data);
--
2.20.1.7.g153144c
On Fri, 11 Aug 2023, Jiapeng Chong wrote:
> The assignment of the else and if branches is the same, so the else
> here is redundant, so we remove it.
>
> ./drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:545:3-5: WARNING: possible condition with no effect (if == else).
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> .../platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> index 03d0188804ba..771e554182dc 100644
> --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> @@ -541,14 +541,8 @@ void hp_exit_password_attributes(void)
> struct kobject *attr_name_kobj =
> bioscfg_drv.password_data[instance_id].attr_name_kobj;
>
> - if (attr_name_kobj) {
> - if (!strcmp(attr_name_kobj->name, SETUP_PASSWD))
> - sysfs_remove_group(attr_name_kobj,
> - &password_attr_group);
> - else
> - sysfs_remove_group(attr_name_kobj,
> - &password_attr_group);
> - }
> + if (attr_name_kobj)
> + sysfs_remove_group(attr_name_kobj, &password_attr_group);
> }
> bioscfg_drv.password_instances_count = 0;
> kfree(bioscfg_drv.password_data);
While this is a valid observation, I wonder why you didn't change the
create side too?
I hope it's not because you never took a look to understand the
SETUP_PASSWD related code, it'd be pretty impossible to not notice it.
This could have just as well have been a bug with inconsitent pairing
against create side, which is why reports from automated tools must not be
implemented blindly but the related code must be understood first.
--
i.
The redundant code is a remnant code from test phase.
I concur with your changes which were approved in a separate email.
Regards,
Jorge Lopez
HP Inc
"Once you stop learning, you start dying"
Albert Einstein
> -----Original Message-----
> From: Ilpo J?rvinen <[email protected]>
> Sent: Friday, August 11, 2023 3:04 AM
> To: Jiapeng Chong <[email protected]>
> Cc: Lopez, Jorge A (Security) <[email protected]>;
> [email protected]; [email protected]; platform-driver-
> [email protected]; LKML <[email protected]>; Abaci Robot
> <[email protected]>
> Subject: Re: [PATCH] platform/x86: hp-bioscfg: Remove useless else
>
> CAUTION: External Email
>
> On Fri, 11 Aug 2023, Jiapeng Chong wrote:
>
> > The assignment of the else and if branches is the same, so the else
> > here is redundant, so we remove it.
> >
> > ./drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:545:3-5:
> WARNING: possible condition with no effect (if == else).
> >
> > Reported-by: Abaci Robot <[email protected]>
> > Signed-off-by: Jiapeng Chong <[email protected]>
> > ---
> > .../platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 10
> > ++--------
> > 1 file changed, 2 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> > b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> > index 03d0188804ba..771e554182dc 100644
> > --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> > +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> > @@ -541,14 +541,8 @@ void hp_exit_password_attributes(void)
> > struct kobject *attr_name_kobj =
> >
> > bioscfg_drv.password_data[instance_id].attr_name_kobj;
> >
> > - if (attr_name_kobj) {
> > - if (!strcmp(attr_name_kobj->name, SETUP_PASSWD))
> > - sysfs_remove_group(attr_name_kobj,
> > - &password_attr_group);
> > - else
> > - sysfs_remove_group(attr_name_kobj,
> > - &password_attr_group);
> > - }
> > + if (attr_name_kobj)
> > + sysfs_remove_group(attr_name_kobj,
> > + &password_attr_group);
> > }
> > bioscfg_drv.password_instances_count = 0;
> > kfree(bioscfg_drv.password_data);
>
> While this is a valid observation, I wonder why you didn't change the create
> side too?
>
> I hope it's not because you never took a look to understand the
> SETUP_PASSWD related code, it'd be pretty impossible to not notice it.
> This could have just as well have been a bug with inconsitent pairing against
> create side, which is why reports from automated tools must not be
> implemented blindly but the related code must be understood first.
>
> --
> i.
Reviewed-by: Jorge Lopez <[email protected]>
Regards,
Jorge Lopez
HP Inc
"Once you stop learning, you start dying"
Albert Einstein
> -----Original Message-----
> From: Jiapeng Chong <[email protected]>
> Sent: Friday, August 11, 2023 1:30 AM
> To: Lopez, Jorge A (Security) <[email protected]>
> Cc: [email protected]; [email protected]; platform-driver-
> [email protected]; [email protected]; Jiapeng Chong
> <[email protected]>; Abaci Robot
> <[email protected]>
> Subject: [PATCH] platform/x86: hp-bioscfg: Remove useless else
>
> CAUTION: External Email
>
> The assignment of the else and if branches is the same, so the else here is
> redundant, so we remove it.
>
> ./drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:545:3-5:
> WARNING: possible condition with no effect (if == else).
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> .../platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> index 03d0188804ba..771e554182dc 100644
> --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> @@ -541,14 +541,8 @@ void hp_exit_password_attributes(void)
> struct kobject *attr_name_kobj =
> bioscfg_drv.password_data[instance_id].attr_name_kobj;
>
> - if (attr_name_kobj) {
> - if (!strcmp(attr_name_kobj->name, SETUP_PASSWD))
> - sysfs_remove_group(attr_name_kobj,
> - &password_attr_group);
> - else
> - sysfs_remove_group(attr_name_kobj,
> - &password_attr_group);
> - }
> + if (attr_name_kobj)
> + sysfs_remove_group(attr_name_kobj,
> + &password_attr_group);
> }
> bioscfg_drv.password_instances_count = 0;
> kfree(bioscfg_drv.password_data);
> --
> 2.20.1.7.g153144c